From 31dc693029a6a6f68262ecb68ea7b6dafd291003 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 9 Sep 2016 09:46:39 +0200 Subject: loplugin:refcounting: No more special-handling of SvXMLImportContext ...after 32ccb4ea863651c22bf33cc15012971d2a2d2810 "resolve the snafu with 2 separate refcounted bases" Change-Id: Iaf13deb0b83b6dfe1a2cf3863e07cf042c8e4f47 --- compilerplugins/clang/refcounting.cxx | 6 ------ 1 file changed, 6 deletions(-) (limited to 'compilerplugins') diff --git a/compilerplugins/clang/refcounting.cxx b/compilerplugins/clang/refcounting.cxx index 97eea57ba5f7..bcfc11bb5bbc 100644 --- a/compilerplugins/clang/refcounting.cxx +++ b/compilerplugins/clang/refcounting.cxx @@ -35,7 +35,6 @@ this is a bug =) since aFooMember assumes heap allocated lifecycle and not delete on last 'release'. TODO check that things that extend SvRefBase are managed by SvRef -TODO fix the SvXMLImportContext class (mentioned below) TODO fix the slideshow::internal::SlideView class (mentioned below) */ @@ -138,11 +137,6 @@ bool containsXInterfaceSubclass(const Type* pType0) { if (isDerivedFrom(pRecordDecl, "dbaui::OSbaWeakSubObject")) { // module dbaccess return false; } - // FIXME this class extends 2 different ref-counting bases, SvRefBase and XInterface (via. cppu::WeakImplHelper) - // I have no idea how to fix it - if (isDerivedFrom(pRecordDecl, "SvXMLImportContext")) { // module xmloff - return false; - } // The actual problem child is SlideView, of which this is the parent. // Everything in the hierarchy above this wants to be managed via boost::shared_ptr if (isDerivedFrom(pRecordDecl, "slideshow::internal::UnoView")) { // module slideshow -- cgit