From e3e66f7b07a920132c17a57e5434d0a472c6a250 Mon Sep 17 00:00:00 2001
From: Stephan Bergmann <sbergman@redhat.com>
Date: Fri, 26 Aug 2016 12:35:24 +0200
Subject: Minor improvements of loplugin:staticaccess

Change-Id: I731aab418fb42922208afdaa60d98ccd76377dab
---
 compilerplugins/clang/staticaccess.cxx | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

(limited to 'compilerplugins')

diff --git a/compilerplugins/clang/staticaccess.cxx b/compilerplugins/clang/staticaccess.cxx
index 7b825f39bafa..7fa1d392edb8 100644
--- a/compilerplugins/clang/staticaccess.cxx
+++ b/compilerplugins/clang/staticaccess.cxx
@@ -18,7 +18,9 @@ bool isStatic(ValueDecl const * decl, bool * memberEnumerator) {
     // clang::MemberExpr::getMemberDecl is documented to return either a
     // FieldDecl or a CXXMethodDecl, but can apparently also return a VarDecl
     // (as C++ static data members are modeled by VarDecl, not FieldDecl) or an
-    // EnumConstantDecl (struct { enum {E}; } s; s.E;):
+    // EnumConstantDecl (struct { enum {E}; } s; s.E;), see
+    // <https://reviews.llvm.org/D23907> "Fix documentation of
+    // MemberExpr::getMemberDecl":
     auto fd = dyn_cast<FieldDecl>(decl);
     if (fd != nullptr) {
         *memberEnumerator = false;
@@ -27,7 +29,8 @@ bool isStatic(ValueDecl const * decl, bool * memberEnumerator) {
     auto vd = dyn_cast<VarDecl>(decl);
     if (vd != nullptr) {
         *memberEnumerator = false;
-        return vd->isStaticDataMember();
+        assert(vd->isStaticDataMember());
+        return true;
     }
     auto md = dyn_cast<CXXMethodDecl>(decl);
     if (md != nullptr) {
-- 
cgit