From 0063cf285696951e336b9cec1da8881997b286ce Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 18 Nov 2014 10:01:21 +0200 Subject: java: make fields final where possible found by PMD Change-Id: I87780366119c141cd2dafe6ca1bf2d9798b10aec --- .../sun/star/sdbcx/comp/hsqldb/NativeInputStreamHelper.java | 11 +++-------- .../star/sdbcx/comp/hsqldb/NativeOutputStreamHelper.java | 13 +++---------- .../com/sun/star/sdbcx/comp/hsqldb/StorageFileAccess.java | 2 +- 3 files changed, 7 insertions(+), 19 deletions(-) (limited to 'connectivity/com/sun/star') diff --git a/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeInputStreamHelper.java b/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeInputStreamHelper.java index c8e7d5d84b03..66b6f5489862 100644 --- a/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeInputStreamHelper.java +++ b/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeInputStreamHelper.java @@ -15,18 +15,13 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ - /* - * NativeInputStreamHelper.java - * - * Created on 9. September 2004, 11:51 - */ package com.sun.star.sdbcx.comp.hsqldb; public class NativeInputStreamHelper extends java.io.InputStream{ - private String key; - private String file; - private StorageNativeInputStream in; + private final String key; + private final String file; + private final StorageNativeInputStream in; /** Creates a new instance of NativeInputStreamHelper */ public NativeInputStreamHelper(String key,String _file) { file = _file; diff --git a/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeOutputStreamHelper.java b/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeOutputStreamHelper.java index 24776f25c2f4..6445f24139d4 100644 --- a/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeOutputStreamHelper.java +++ b/connectivity/com/sun/star/sdbcx/comp/hsqldb/NativeOutputStreamHelper.java @@ -15,20 +15,13 @@ * except in compliance with the License. You may obtain a copy of * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ - -/* - * NativeOutputStreamHelper.java - * - * Created on 1. September 2004, 10:39 - */ - package com.sun.star.sdbcx.comp.hsqldb; public class NativeOutputStreamHelper extends java.io.OutputStream{ - private String key; - private String file; - private StorageNativeOutputStream out; + private final String key; + private final String file; + private final StorageNativeOutputStream out; /** Creates a new instance of NativeOutputStreamHelper */ public NativeOutputStreamHelper(String key,String _file) { file = _file; diff --git a/connectivity/com/sun/star/sdbcx/comp/hsqldb/StorageFileAccess.java b/connectivity/com/sun/star/sdbcx/comp/hsqldb/StorageFileAccess.java index 9248cdf5a546..2f3d99be6655 100644 --- a/connectivity/com/sun/star/sdbcx/comp/hsqldb/StorageFileAccess.java +++ b/connectivity/com/sun/star/sdbcx/comp/hsqldb/StorageFileAccess.java @@ -72,7 +72,7 @@ public class StorageFileAccess implements org.hsqldb.lib.FileAccess{ private class FileSync implements FileAccess.FileSync { - private NativeOutputStreamHelper os; + private final NativeOutputStreamHelper os; private FileSync(NativeOutputStreamHelper _os) { os = _os; -- cgit