From f14d64fa71565e86c98348f9c54cc6cab53649d8 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 31 Dec 2015 10:26:43 +0200 Subject: these fields can be static constants Change-Id: Id56e219782d7f858cdeb26232c7aabd4f643c9d9 Reviewed-on: https://gerrit.libreoffice.org/21020 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- .../qa/connectivity/commontools/FValue_test.cxx | 17 ++++++----------- 1 file changed, 6 insertions(+), 11 deletions(-) (limited to 'connectivity/qa') diff --git a/connectivity/qa/connectivity/commontools/FValue_test.cxx b/connectivity/qa/connectivity/commontools/FValue_test.cxx index 2e6e326db960..1db73c687d85 100644 --- a/connectivity/qa/connectivity/commontools/FValue_test.cxx +++ b/connectivity/qa/connectivity/commontools/FValue_test.cxx @@ -339,46 +339,41 @@ void FValueTest::test_bit_getString() void FValueTest::test_bool_creation() { - OUString s1("1"); - OUString s0("0"); - OUString sTrue("true"); - OUString sTrUe("tRuE"); - OUString sFalse("false"); ORowSetValue vTrue(true); ORowSetValue vFalse(false); { - ORowSetValue v(s1); + ORowSetValue v(OUString("1")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(s0); + ORowSetValue v(OUString("0")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } { - ORowSetValue v(sTrue); + ORowSetValue v(OUString("true")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(sTrUe); + ORowSetValue v(OUString("tRuE")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vTrue); } { - ORowSetValue v(sFalse); + ORowSetValue v(OUString("false")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } { - ORowSetValue v(s0); + ORowSetValue v(OUString("0")); v.setTypeKind(DataType::BOOLEAN); CPPUNIT_ASSERT_MESSAGE("ORowSetValue bool creation from string didn't work", v == vFalse); } -- cgit