From e2080e70fe8b085f18e868e46340454720fa94ca Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 18 Jun 2014 12:14:29 +0200 Subject: new compilerplugin returnbyref Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7 --- connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx | 2 +- connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'connectivity/source/drivers/mozab/bootstrap') diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx b/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx index b5795c1c668b..7a5a2acc4d45 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSINIParser.hxx @@ -62,7 +62,7 @@ class IniParser { IniSectionMap mAllSection; public: - IniSectionMap * getAllSection(){return &mAllSection;}; + IniSectionMap& getAllSection() { return mAllSection; } IniParser(OUString const & rIniName) throw(com::sun::star::io::IOException); }; diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx index 6660a5c9b690..1d5e5d34c820 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx @@ -148,7 +148,7 @@ namespace connectivity OUString regDir = getRegistryDir(product); OUString profilesIni = regDir + "profiles.ini"; IniParser parser( profilesIni ); - IniSectionMap &mAllSection = *(parser.getAllSection()); + IniSectionMap &mAllSection = parser.getAllSection(); IniSectionMap::iterator iBegin = mAllSection.begin(); IniSectionMap::iterator iEnd = mAllSection.end(); -- cgit