From 82572caae4a282cdf79456b977508ca71507c584 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 18 Sep 2019 14:15:59 +0200 Subject: improve and enable loplugin:fragiledestructor Where the problem was benign and the class was not extended, I marked the class as final. Where the problem was benign and the class was extended, I marked the relevant callee methods as final. Other cases were excluded in the plugin. Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc Reviewed-on: https://gerrit.libreoffice.org/79089 Tested-by: Jenkins Reviewed-by: Noel Grandin --- connectivity/source/inc/file/FConnection.hxx | 4 ++-- connectivity/source/inc/file/FResultSet.hxx | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'connectivity/source/inc/file') diff --git a/connectivity/source/inc/file/FConnection.hxx b/connectivity/source/inc/file/FConnection.hxx index 4041e060816f..e791e6ec3f07 100644 --- a/connectivity/source/inc/file/FConnection.hxx +++ b/connectivity/source/inc/file/FConnection.hxx @@ -90,7 +90,7 @@ namespace connectivity virtual sal_Bool SAL_CALL getAutoCommit( ) override; virtual void SAL_CALL commit( ) override; virtual void SAL_CALL rollback( ) override; - virtual sal_Bool SAL_CALL isClosed( ) override; + virtual sal_Bool SAL_CALL isClosed( ) override final; virtual css::uno::Reference< css::sdbc::XDatabaseMetaData > SAL_CALL getMetaData( ) override; virtual void SAL_CALL setReadOnly( sal_Bool readOnly ) override; virtual sal_Bool SAL_CALL isReadOnly( ) override; @@ -101,7 +101,7 @@ namespace connectivity virtual css::uno::Reference< css::container::XNameAccess > SAL_CALL getTypeMap( ) override; virtual void SAL_CALL setTypeMap( const css::uno::Reference< css::container::XNameAccess >& typeMap ) override; // XCloseable - virtual void SAL_CALL close( ) override; + virtual void SAL_CALL close( ) override final; // XWarningsSupplier virtual css::uno::Any SAL_CALL getWarnings( ) override; virtual void SAL_CALL clearWarnings( ) override; diff --git a/connectivity/source/inc/file/FResultSet.hxx b/connectivity/source/inc/file/FResultSet.hxx index 61bc7f033775..71f3d3b95ff5 100644 --- a/connectivity/source/inc/file/FResultSet.hxx +++ b/connectivity/source/inc/file/FResultSet.hxx @@ -163,7 +163,7 @@ namespace connectivity OResultSet( OStatement_Base* pStmt,connectivity::OSQLParseTreeIterator& _aSQLIterator); // ::cppu::OComponentHelper - virtual void SAL_CALL disposing() override; + virtual void SAL_CALL disposing() override final; // XInterface virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type & rType ) override; virtual void SAL_CALL acquire() throw() override; -- cgit tro/collabora/cp-4.1 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
AgeCommit message (Expand)Author
2019-11-10tdf#106638 oox: reset font settings if necessary.Mark Hung
2019-08-16use more TOOLS_WARN_EXCEPTIONNoel Grandin
2019-07-20loplugin:referencecasting in oox..pyunoNoel Grandin
2019-03-07log nice exception messages whereever possibleNoel Grandin