From 358be80f65d335910a4add147cd15e35d3505afd Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 14 Mar 2014 07:46:08 +0200 Subject: comphelper,connectivity: prefer passing OUString by reference Change-Id: I19b2613918ec62ee39bb3e447f3587c5dba1e36a --- connectivity/source/commontools/TColumnsHelper.cxx | 2 +- connectivity/source/commontools/TIndexes.cxx | 2 +- connectivity/source/commontools/TKeys.cxx | 2 +- connectivity/source/drivers/ado/AColumns.cxx | 2 +- connectivity/source/drivers/ado/AGroups.cxx | 2 +- connectivity/source/drivers/ado/AIndexes.cxx | 2 +- connectivity/source/drivers/ado/AKeys.cxx | 2 +- connectivity/source/drivers/ado/ATables.cxx | 2 +- connectivity/source/drivers/ado/AUsers.cxx | 2 +- connectivity/source/drivers/ado/AViews.cxx | 2 +- connectivity/source/drivers/dbase/DColumns.cxx | 2 +- connectivity/source/drivers/dbase/DIndexes.cxx | 2 +- connectivity/source/drivers/dbase/DTables.cxx | 2 +- connectivity/source/drivers/firebird/Indexes.cxx | 4 ++-- connectivity/source/drivers/firebird/Indexes.hxx | 2 +- connectivity/source/drivers/firebird/Keys.cxx | 4 ++-- connectivity/source/drivers/firebird/Keys.hxx | 4 ++-- connectivity/source/drivers/firebird/Tables.cxx | 4 ++-- connectivity/source/drivers/firebird/Tables.hxx | 4 ++-- connectivity/source/drivers/firebird/Users.cxx | 2 +- connectivity/source/drivers/firebird/Users.hxx | 2 +- connectivity/source/drivers/hsqldb/HTables.cxx | 2 +- connectivity/source/drivers/hsqldb/HTools.cxx | 2 +- connectivity/source/drivers/hsqldb/HUsers.cxx | 2 +- connectivity/source/drivers/hsqldb/HViews.cxx | 2 +- connectivity/source/drivers/jdbc/tools.cxx | 2 +- connectivity/source/drivers/mork/MNSProfileDiscover.cxx | 2 +- connectivity/source/drivers/mork/MNSProfileDiscover.hxx | 4 ++-- connectivity/source/drivers/mork/MQueryHelper.hxx | 6 +++--- connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx | 2 +- connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx | 4 ++-- connectivity/source/drivers/mysql/YTables.cxx | 2 +- connectivity/source/drivers/mysql/YUsers.cxx | 2 +- connectivity/source/drivers/mysql/YViews.cxx | 2 +- connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 2 +- connectivity/source/drivers/postgresql/pq_databasemetadata.hxx | 2 +- connectivity/source/drivers/postgresql/pq_tools.cxx | 4 ++-- connectivity/source/drivers/postgresql/pq_tools.hxx | 2 +- connectivity/source/inc/ado/AColumns.hxx | 2 +- connectivity/source/inc/ado/AGroups.hxx | 2 +- connectivity/source/inc/ado/AIndexes.hxx | 2 +- connectivity/source/inc/ado/AKeys.hxx | 2 +- connectivity/source/inc/ado/ATables.hxx | 2 +- connectivity/source/inc/ado/AUsers.hxx | 2 +- connectivity/source/inc/ado/AViews.hxx | 2 +- connectivity/source/inc/dbase/DColumns.hxx | 2 +- connectivity/source/inc/dbase/DIndexes.hxx | 2 +- connectivity/source/inc/dbase/DTables.hxx | 2 +- connectivity/source/inc/file/quotedstring.hxx | 2 +- connectivity/source/inc/hsqldb/HTables.hxx | 2 +- connectivity/source/inc/hsqldb/HTools.hxx | 2 +- connectivity/source/inc/hsqldb/HUsers.hxx | 2 +- connectivity/source/inc/hsqldb/HViews.hxx | 2 +- connectivity/source/inc/java/util/Property.hxx | 2 +- connectivity/source/inc/mysql/YTables.hxx | 2 +- connectivity/source/inc/mysql/YUsers.hxx | 2 +- connectivity/source/inc/mysql/YViews.hxx | 2 +- connectivity/source/parse/sqliterator.cxx | 2 +- connectivity/source/sdbcx/VCollection.cxx | 6 +++--- 59 files changed, 71 insertions(+), 71 deletions(-) (limited to 'connectivity') diff --git a/connectivity/source/commontools/TColumnsHelper.cxx b/connectivity/source/commontools/TColumnsHelper.cxx index 7705e5caaff0..d9dcd3c56bfa 100644 --- a/connectivity/source/commontools/TColumnsHelper.cxx +++ b/connectivity/source/commontools/TColumnsHelper.cxx @@ -192,7 +192,7 @@ sdbcx::ObjectType OColumnsHelper::appendObject( const OUString& _rForName, const } // XDrop -void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OColumnsHelper::dropObject(sal_Int32 /*_nPos*/, const OUString& _sElementName) { OSL_ENSURE(m_pTable,"OColumnsHelper::dropByName: Table is null!"); if ( m_pTable && !m_pTable->isNew() ) diff --git a/connectivity/source/commontools/TIndexes.cxx b/connectivity/source/commontools/TIndexes.cxx index 165c2fd93688..acf70f219d08 100644 --- a/connectivity/source/commontools/TIndexes.cxx +++ b/connectivity/source/commontools/TIndexes.cxx @@ -209,7 +209,7 @@ sdbcx::ObjectType OIndexesHelper::appendObject( const OUString& _rForName, const } // XDrop -void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OIndexesHelper::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { Reference< XConnection> xConnection = m_pTable->getConnection(); if( xConnection.is() && !m_pTable->isNew()) diff --git a/connectivity/source/commontools/TKeys.cxx b/connectivity/source/commontools/TKeys.cxx index 1841fd445169..abdb2f0bf6db 100644 --- a/connectivity/source/commontools/TKeys.cxx +++ b/connectivity/source/commontools/TKeys.cxx @@ -260,7 +260,7 @@ OUString OKeysHelper::getDropForeignKey() const } // XDrop -void OKeysHelper::dropObject(sal_Int32 _nPos,const OUString _sElementName) +void OKeysHelper::dropObject(sal_Int32 _nPos, const OUString& _sElementName) { Reference< XConnection> xConnection = m_pTable->getConnection(); if ( xConnection.is() && !m_pTable->isNew() ) diff --git a/connectivity/source/drivers/ado/AColumns.cxx b/connectivity/source/drivers/ado/AColumns.cxx index 08dda621be35..936510f155e3 100644 --- a/connectivity/source/drivers/ado/AColumns.cxx +++ b/connectivity/source/drivers/ado/AColumns.cxx @@ -127,7 +127,7 @@ sdbcx::ObjectType OColumns::appendObject( const OUString&, const Reference< XPro } // XDrop -void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OColumns::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { if(!m_aCollection.Delete(_sElementName)) ADOS::ThrowException(*m_pConnection->getConnection(),static_cast(this)); diff --git a/connectivity/source/drivers/ado/AGroups.cxx b/connectivity/source/drivers/ado/AGroups.cxx index ba19dbeb9a77..4eae0dc11030 100644 --- a/connectivity/source/drivers/ado/AGroups.cxx +++ b/connectivity/source/drivers/ado/AGroups.cxx @@ -66,7 +66,7 @@ sdbcx::ObjectType OGroups::appendObject( const OUString& _rForName, const Refere } // XDrop -void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OGroups::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { m_aCollection.Delete(_sElementName); } diff --git a/connectivity/source/drivers/ado/AIndexes.cxx b/connectivity/source/drivers/ado/AIndexes.cxx index e95fd3db114b..5dfc2930bc7c 100644 --- a/connectivity/source/drivers/ado/AIndexes.cxx +++ b/connectivity/source/drivers/ado/AIndexes.cxx @@ -71,7 +71,7 @@ sdbcx::ObjectType OIndexes::appendObject( const OUString& _rForName, const Refer } // XDrop -void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OIndexes::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { m_aCollection.Delete(_sElementName); } diff --git a/connectivity/source/drivers/ado/AKeys.cxx b/connectivity/source/drivers/ado/AKeys.cxx index 735b8c6fc215..b272dac406af 100644 --- a/connectivity/source/drivers/ado/AKeys.cxx +++ b/connectivity/source/drivers/ado/AKeys.cxx @@ -97,7 +97,7 @@ sdbcx::ObjectType OKeys::appendObject( const OUString&, const Reference< XProper } // XDrop -void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OKeys::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { if(!m_aCollection.Delete(OLEVariant(_sElementName))) ADOS::ThrowException(*m_pConnection->getConnection(),static_cast(this)); diff --git a/connectivity/source/drivers/ado/ATables.cxx b/connectivity/source/drivers/ado/ATables.cxx index d506ef2a7c27..cdd7df2775c3 100644 --- a/connectivity/source/drivers/ado/ATables.cxx +++ b/connectivity/source/drivers/ado/ATables.cxx @@ -77,7 +77,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString&, const Reference< XProp } // XDrop -void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OTables::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { OSL_ENSURE(m_aCollection.IsValid(),"Collection isn't valid"); if ( !m_aCollection.Delete(_sElementName) ) diff --git a/connectivity/source/drivers/ado/AUsers.cxx b/connectivity/source/drivers/ado/AUsers.cxx index 6c4643247464..e47ec19a99ea 100644 --- a/connectivity/source/drivers/ado/AUsers.cxx +++ b/connectivity/source/drivers/ado/AUsers.cxx @@ -66,7 +66,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen } // XDrop -void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { m_aCollection.Delete(_sElementName); } diff --git a/connectivity/source/drivers/ado/AViews.cxx b/connectivity/source/drivers/ado/AViews.cxx index 1401d17b5a4b..155866c1ec30 100644 --- a/connectivity/source/drivers/ado/AViews.cxx +++ b/connectivity/source/drivers/ado/AViews.cxx @@ -83,7 +83,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen } // XDrop -void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OViews::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { if(!m_aCollection.Delete(_sElementName)) ADOS::ThrowException(*m_pCatalog->getConnection()->getConnection(),static_cast(this)); diff --git a/connectivity/source/drivers/dbase/DColumns.cxx b/connectivity/source/drivers/dbase/DColumns.cxx index 00888a0c4e77..c3b19978ee27 100644 --- a/connectivity/source/drivers/dbase/DColumns.cxx +++ b/connectivity/source/drivers/dbase/DColumns.cxx @@ -70,7 +70,7 @@ sdbcx::ObjectType ODbaseColumns::appendObject( const OUString& _rForName, const // XDrop -void ODbaseColumns::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) +void ODbaseColumns::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/) { if(!m_pTable->isNew()) m_pTable->dropColumn(_nPos); diff --git a/connectivity/source/drivers/dbase/DIndexes.cxx b/connectivity/source/drivers/dbase/DIndexes.cxx index 56dd8a750c97..67625a786a84 100644 --- a/connectivity/source/drivers/dbase/DIndexes.cxx +++ b/connectivity/source/drivers/dbase/DIndexes.cxx @@ -104,7 +104,7 @@ sdbcx::ObjectType ODbaseIndexes::appendObject( const OUString& _rForName, const } // XDrop -void ODbaseIndexes::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) +void ODbaseIndexes::dropObject(sal_Int32 _nPos, const OUString& /*_sElementName*/) { Reference< XUnoTunnel> xTunnel(getObject(_nPos),UNO_QUERY); if ( xTunnel.is() ) diff --git a/connectivity/source/drivers/dbase/DTables.cxx b/connectivity/source/drivers/dbase/DTables.cxx index ef88e047297c..47ebfb88736f 100644 --- a/connectivity/source/drivers/dbase/DTables.cxx +++ b/connectivity/source/drivers/dbase/DTables.cxx @@ -92,7 +92,7 @@ sdbcx::ObjectType ODbaseTables::appendObject( const OUString& _rForName, const R } // XDrop -void ODbaseTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) +void ODbaseTables::dropObject(sal_Int32 _nPos, const OUString& _sElementName) { Reference< XUnoTunnel> xTunnel; try diff --git a/connectivity/source/drivers/firebird/Indexes.cxx b/connectivity/source/drivers/firebird/Indexes.cxx index fc03272674f4..2b94d8ea117b 100644 --- a/connectivity/source/drivers/firebird/Indexes.cxx +++ b/connectivity/source/drivers/firebird/Indexes.cxx @@ -26,8 +26,8 @@ Indexes::Indexes(Table* pTable, Mutex& rMutex, const vector< OUString>& rVector) } // XDrop -void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString sIndexName) +void Indexes::dropObject(sal_Int32 /*nPosition*/, const OUString& sIndexName) { OUString sSql("DROP INDEX \"" + sIndexName +"\""); m_pTable->getConnection()->createStatement()->execute(sSql); -} \ No newline at end of file +} diff --git a/connectivity/source/drivers/firebird/Indexes.hxx b/connectivity/source/drivers/firebird/Indexes.hxx index 32d035c1edfb..8938f66d09b4 100644 --- a/connectivity/source/drivers/firebird/Indexes.hxx +++ b/connectivity/source/drivers/firebird/Indexes.hxx @@ -30,7 +30,7 @@ namespace connectivity protected: // XDrop virtual void dropObject(sal_Int32 nPosition, - const ::rtl::OUString sIndexName); + const ::rtl::OUString& sIndexName); public: Indexes(Table* pTable, ::osl::Mutex& rMutex, diff --git a/connectivity/source/drivers/firebird/Keys.cxx b/connectivity/source/drivers/firebird/Keys.cxx index c1874919e361..e67723009dec 100644 --- a/connectivity/source/drivers/firebird/Keys.cxx +++ b/connectivity/source/drivers/firebird/Keys.cxx @@ -32,7 +32,7 @@ Keys::Keys(Table* pTable, Mutex& rMutex, const TStringVector& rNames): } //----- XDrop ---------------------------------------------------------------- -void Keys::dropObject(sal_Int32 nPosition, const OUString sName) +void Keys::dropObject(sal_Int32 nPosition, const OUString& sName) { Reference< XConnection> xConnection = m_pTable->getConnection(); @@ -53,4 +53,4 @@ void Keys::dropObject(sal_Int32 nPosition, const OUString sName) } } -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ \ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/firebird/Keys.hxx b/connectivity/source/drivers/firebird/Keys.hxx index a99edbdb2e1a..dd7489e10920 100644 --- a/connectivity/source/drivers/firebird/Keys.hxx +++ b/connectivity/source/drivers/firebird/Keys.hxx @@ -31,11 +31,11 @@ namespace connectivity const ::connectivity::TStringVector& rNames); // OKeysHelper / XDrop - void dropObject(sal_Int32 nPosition, const ::rtl::OUString sName); + void dropObject(sal_Int32 nPosition, const ::rtl::OUString& sName); }; } } #endif // CONNECTIVITY_FIREBIRD_KEYS_HXX -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ \ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/firebird/Tables.cxx b/connectivity/source/drivers/firebird/Tables.cxx index fc55d2ae5d13..63d94044b004 100644 --- a/connectivity/source/drivers/firebird/Tables.cxx +++ b/connectivity/source/drivers/firebird/Tables.cxx @@ -98,7 +98,7 @@ ObjectType Tables::appendObject(const OUString& rName, } //----- XDrop ----------------------------------------------------------------- -void Tables::dropObject(sal_Int32 nPosition, const OUString sName) +void Tables::dropObject(sal_Int32 nPosition, const OUString& sName) { uno::Reference< XPropertySet > xTable(getObject(nPosition)); @@ -117,4 +117,4 @@ void Tables::dropObject(sal_Int32 nPosition, const OUString sName) } } -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ \ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/firebird/Tables.hxx b/connectivity/source/drivers/firebird/Tables.hxx index b2e570f9ff92..276f0809199f 100644 --- a/connectivity/source/drivers/firebird/Tables.hxx +++ b/connectivity/source/drivers/firebird/Tables.hxx @@ -53,7 +53,7 @@ namespace connectivity // XAppend, etc., but all are optional. // XDrop - virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName); + virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName); }; @@ -63,4 +63,4 @@ namespace connectivity #endif // CONNECTIVITY_FIREBIRD_TABLES_HXX -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ \ No newline at end of file +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/connectivity/source/drivers/firebird/Users.cxx b/connectivity/source/drivers/firebird/Users.cxx index b84d034c3ebd..6e9f8667c0b3 100644 --- a/connectivity/source/drivers/firebird/Users.cxx +++ b/connectivity/source/drivers/firebird/Users.cxx @@ -75,7 +75,7 @@ ObjectType Users::appendObject(const OUString& rName, } //----- XDrop ----------------------------------------------------------------- -void Users::dropObject(sal_Int32 nPosition, const OUString sName) +void Users::dropObject(sal_Int32 nPosition, const OUString& sName) { uno::Reference< XPropertySet > xUser(getObject(nPosition)); diff --git a/connectivity/source/drivers/firebird/Users.hxx b/connectivity/source/drivers/firebird/Users.hxx index ce353680a160..fc603815f932 100644 --- a/connectivity/source/drivers/firebird/Users.hxx +++ b/connectivity/source/drivers/firebird/Users.hxx @@ -49,7 +49,7 @@ namespace connectivity // XAppend, etc., but all are optional. // XDrop - virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString rName); + virtual void dropObject(sal_Int32 nPosition, const ::rtl::OUString& rName); }; diff --git a/connectivity/source/drivers/hsqldb/HTables.cxx b/connectivity/source/drivers/hsqldb/HTables.cxx index 055445f0f6aa..eed4ffa44d7b 100644 --- a/connectivity/source/drivers/hsqldb/HTables.cxx +++ b/connectivity/source/drivers/hsqldb/HTables.cxx @@ -116,7 +116,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere } // XDrop -void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) +void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName) { Reference< XInterface > xObject( getObject( _nPos ) ); sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject ); diff --git a/connectivity/source/drivers/hsqldb/HTools.cxx b/connectivity/source/drivers/hsqldb/HTools.cxx index af568aafeca2..0288a7b698ab 100644 --- a/connectivity/source/drivers/hsqldb/HTools.cxx +++ b/connectivity/source/drivers/hsqldb/HTools.cxx @@ -27,7 +27,7 @@ namespace connectivity { namespace hsqldb void HTools::appendTableFilterCrit( OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog, - const OUString _rSchema, const OUString _rName, bool _bShortForm ) + const OUString& _rSchema, const OUString& _rName, bool _bShortForm ) { _inout_rBuffer.appendAscii( " WHERE " ); if ( !_rCatalog.isEmpty() ) diff --git a/connectivity/source/drivers/hsqldb/HUsers.cxx b/connectivity/source/drivers/hsqldb/HUsers.cxx index ffb34e7b00d8..947cde124515 100644 --- a/connectivity/source/drivers/hsqldb/HUsers.cxx +++ b/connectivity/source/drivers/hsqldb/HUsers.cxx @@ -87,7 +87,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen } // XDrop -void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString _sElementName) +void OUsers::dropObject(sal_Int32 /*nPos*/,const OUString& _sElementName) { { OUString aSql( "REVOKE ALL ON * FROM " ); diff --git a/connectivity/source/drivers/hsqldb/HViews.cxx b/connectivity/source/drivers/hsqldb/HViews.cxx index ef3922e9cdaf..2a01e30cc6b3 100644 --- a/connectivity/source/drivers/hsqldb/HViews.cxx +++ b/connectivity/source/drivers/hsqldb/HViews.cxx @@ -99,7 +99,7 @@ sdbcx::ObjectType HViews::appendObject( const OUString& _rForName, const Referen } // XDrop -void HViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) +void HViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/) { if ( m_bInDrop ) return; diff --git a/connectivity/source/drivers/jdbc/tools.cxx b/connectivity/source/drivers/jdbc/tools.cxx index c443b229edcb..1bc79f7a04a5 100644 --- a/connectivity/source/drivers/jdbc/tools.cxx +++ b/connectivity/source/drivers/jdbc/tools.cxx @@ -35,7 +35,7 @@ using namespace ::com::sun::star::sdbc; using namespace ::com::sun::star::container; using namespace ::com::sun::star::lang; -void java_util_Properties::setProperty(const OUString key, const OUString& value) +void java_util_Properties::setProperty(const OUString& key, const OUString& value) { SDBThreadAttach t; OSL_ENSURE(t.pEnv,"Java Enviroment geloescht worden!"); jobject out(0); diff --git a/connectivity/source/drivers/mork/MNSProfileDiscover.cxx b/connectivity/source/drivers/mork/MNSProfileDiscover.cxx index 579d7ce19f3f..4b7ac559f5e7 100644 --- a/connectivity/source/drivers/mork/MNSProfileDiscover.cxx +++ b/connectivity/source/drivers/mork/MNSProfileDiscover.cxx @@ -27,7 +27,7 @@ namespace connectivity { namespace mork { - ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName, + ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName, const OUString& aProfilePath ) { diff --git a/connectivity/source/drivers/mork/MNSProfileDiscover.hxx b/connectivity/source/drivers/mork/MNSProfileDiscover.hxx index 2ad9843a7f28..26a8eceae12d 100644 --- a/connectivity/source/drivers/mork/MNSProfileDiscover.hxx +++ b/connectivity/source/drivers/mork/MNSProfileDiscover.hxx @@ -49,7 +49,7 @@ namespace connectivity class ProfileStruct { public: - ProfileStruct(MozillaProductType aProduct,OUString aProfileName, + ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName, const OUString &aProfilePath ); MozillaProductType getProductType() { return product;} @@ -64,7 +64,7 @@ namespace connectivity class ProductStruct { public: - void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;} + void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;} OUString mCurrentProfileName; diff --git a/connectivity/source/drivers/mork/MQueryHelper.hxx b/connectivity/source/drivers/mork/MQueryHelper.hxx index 70e9502a0d2d..52ee78c0398d 100644 --- a/connectivity/source/drivers/mork/MQueryHelper.hxx +++ b/connectivity/source/drivers/mork/MQueryHelper.hxx @@ -81,9 +81,9 @@ namespace connectivity public: - MQueryExpressionString( OUString& lhs, + MQueryExpressionString( const OUString& lhs, MQueryOp::cond_type cond, - OUString rhs ) + const OUString& rhs ) : MQueryExpressionBase( MQueryExpressionBase::StringExpr ) , m_aName( lhs ) , m_aBooleanCondition( cond ) @@ -91,7 +91,7 @@ namespace connectivity { } - MQueryExpressionString( OUString& lhs, + MQueryExpressionString( const OUString& lhs, MQueryOp::cond_type cond ) : MQueryExpressionBase( MQueryExpressionBase::StringExpr ) , m_aName( lhs ) diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx index 7fcd034222a4..0280568e3014 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx @@ -85,7 +85,7 @@ namespace connectivity { namespace mozab { - ProfileStruct::ProfileStruct(MozillaProductType aProduct,OUString aProfileName, + ProfileStruct::ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName, #ifdef MINIMAL_PROFILEDISCOVER const OUString& aProfilePath #else diff --git a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx index 7a4afef4dd29..bb88a8d85799 100644 --- a/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx +++ b/connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx @@ -51,7 +51,7 @@ namespace connectivity class ProfileStruct { public: - ProfileStruct(MozillaProductType aProduct,OUString aProfileName, + ProfileStruct(MozillaProductType aProduct, const OUString& aProfileName, #ifdef MINIMAL_PROFILEDISCOVER const OUString &aProfilePath #else @@ -77,7 +77,7 @@ namespace connectivity class ProductStruct { public: - void setCurrentProfile(OUString aProfileName){mCurrentProfileName = aProfileName;} + void setCurrentProfile(const OUString& aProfileName){mCurrentProfileName = aProfileName;} OUString mCurrentProfileName; diff --git a/connectivity/source/drivers/mysql/YTables.cxx b/connectivity/source/drivers/mysql/YTables.cxx index eb9156aab7d2..c48a998eaba7 100644 --- a/connectivity/source/drivers/mysql/YTables.cxx +++ b/connectivity/source/drivers/mysql/YTables.cxx @@ -121,7 +121,7 @@ sdbcx::ObjectType OTables::appendObject( const OUString& _rForName, const Refere } // XDrop -void OTables::dropObject(sal_Int32 _nPos,const OUString _sElementName) +void OTables::dropObject(sal_Int32 _nPos,const OUString& _sElementName) { Reference< XInterface > xObject( getObject( _nPos ) ); sal_Bool bIsNew = connectivity::sdbcx::ODescriptor::isNew( xObject ); diff --git a/connectivity/source/drivers/mysql/YUsers.cxx b/connectivity/source/drivers/mysql/YUsers.cxx index 6791435eaac0..ff8e9fedcbda 100644 --- a/connectivity/source/drivers/mysql/YUsers.cxx +++ b/connectivity/source/drivers/mysql/YUsers.cxx @@ -91,7 +91,7 @@ sdbcx::ObjectType OUsers::appendObject( const OUString& _rForName, const Referen } // XDrop -void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString _sElementName) +void OUsers::dropObject(sal_Int32 /*_nPos*/,const OUString& _sElementName) { OUString aSql( "DROP USER " ); OUString aQuote = m_xConnection->getMetaData()->getIdentifierQuoteString( ); diff --git a/connectivity/source/drivers/mysql/YViews.cxx b/connectivity/source/drivers/mysql/YViews.cxx index 12fa1daad23f..4a87c34a6fb2 100644 --- a/connectivity/source/drivers/mysql/YViews.cxx +++ b/connectivity/source/drivers/mysql/YViews.cxx @@ -93,7 +93,7 @@ sdbcx::ObjectType OViews::appendObject( const OUString& _rForName, const Referen } // XDrop -void OViews::dropObject(sal_Int32 _nPos,const OUString /*_sElementName*/) +void OViews::dropObject(sal_Int32 _nPos,const OUString& /*_sElementName*/) { if ( m_bInDrop ) return; diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx index e17dde6e36b2..f7823716cbed 100644 --- a/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx +++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.cxx @@ -910,7 +910,7 @@ sal_Int32 DatabaseMetaData::getMaxCharLiteralLength( ) throw (SQLException, Run } // Copied / adapted / simplified from JDBC driver -sal_Int32 DatabaseMetaData::getIntSetting(OUString settingName) +sal_Int32 DatabaseMetaData::getIntSetting(const OUString& settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException) { MutexGuard guard( m_refMutex->mutex ); diff --git a/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx b/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx index 84ceafbc5661..be1357bbed5b 100644 --- a/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx +++ b/connectivity/source/drivers/postgresql/pq_databasemetadata.hxx @@ -57,7 +57,7 @@ class DatabaseMetaData : ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XPreparedStatement > m_getColumnPrivs_stmt; void checkClosed() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); - sal_Int32 getIntSetting(OUString settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); + sal_Int32 getIntSetting(const OUString& settingName) throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); sal_Int32 getMaxIndexKeys() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); sal_Int32 getMaxNameLength() throw (::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XResultSet > getImportedExportedKeys( diff --git a/connectivity/source/drivers/postgresql/pq_tools.cxx b/connectivity/source/drivers/postgresql/pq_tools.cxx index b7a54115df93..f95d02aa2978 100644 --- a/connectivity/source/drivers/postgresql/pq_tools.cxx +++ b/connectivity/source/drivers/postgresql/pq_tools.cxx @@ -92,12 +92,12 @@ OUString concatQualified( const OUString & a, const OUString &b) return buf.makeStringAndClear(); } -static inline OString iOUStringToOString( const OUString str, ConnectionSettings *settings) { +static inline OString iOUStringToOString( const OUString& str, ConnectionSettings *settings) { OSL_ENSURE(settings, "pgsql-sdbc: OUStringToOString got NULL settings"); return OUStringToOString( str, settings->encoding ); } -OString OUStringToOString( const OUString str, ConnectionSettings *settings) { +OString OUStringToOString( const OUString& str, ConnectionSettings *settings) { return iOUStringToOString( str, settings ); } diff --git a/connectivity/source/drivers/postgresql/pq_tools.hxx b/connectivity/source/drivers/postgresql/pq_tools.hxx index ae4a4d3f4031..23757046d34e 100644 --- a/connectivity/source/drivers/postgresql/pq_tools.hxx +++ b/connectivity/source/drivers/postgresql/pq_tools.hxx @@ -53,7 +53,7 @@ bool isWhitespace( sal_Unicode c ); OUString concatQualified( const OUString & a, const OUString &b); -OString OUStringToOString( OUString str, ConnectionSettings *settings); +OString OUStringToOString( const OUString& str, ConnectionSettings *settings); void bufferQuoteConstant( OUStringBuffer & buf, const OUString & str, ConnectionSettings *settings ); void bufferQuoteAnyConstant( OUStringBuffer & buf, const com::sun::star::uno::Any &val, ConnectionSettings *settings ); diff --git a/connectivity/source/inc/ado/AColumns.hxx b/connectivity/source/inc/ado/AColumns.hxx index 21ecda58f87e..475b03dbc6bc 100644 --- a/connectivity/source/inc/ado/AColumns.hxx +++ b/connectivity/source/inc/ado/AColumns.hxx @@ -40,7 +40,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OColumns( ::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/ado/AGroups.hxx b/connectivity/source/inc/ado/AGroups.hxx index 296de9520cd5..0d5c964297ac 100644 --- a/connectivity/source/inc/ado/AGroups.hxx +++ b/connectivity/source/inc/ado/AGroups.hxx @@ -38,7 +38,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OGroups(OCatalog* _pParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/ado/AIndexes.hxx b/connectivity/source/inc/ado/AIndexes.hxx index 16347b2c5fbd..0ef7c7a9fca2 100644 --- a/connectivity/source/inc/ado/AIndexes.hxx +++ b/connectivity/source/inc/ado/AIndexes.hxx @@ -37,7 +37,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OIndexes(::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/ado/AKeys.hxx b/connectivity/source/inc/ado/AKeys.hxx index c93ffc155dd9..bbd80eb3f711 100644 --- a/connectivity/source/inc/ado/AKeys.hxx +++ b/connectivity/source/inc/ado/AKeys.hxx @@ -38,7 +38,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OKeys(::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/ado/ATables.hxx b/connectivity/source/inc/ado/ATables.hxx index 5c8b4a134e50..81e6441947e2 100644 --- a/connectivity/source/inc/ado/ATables.hxx +++ b/connectivity/source/inc/ado/ATables.hxx @@ -38,7 +38,7 @@ namespace connectivity virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OTables(OCatalog* _pParent, ::osl::Mutex& _rMutex, const TStringVector &_rVector, diff --git a/connectivity/source/inc/ado/AUsers.hxx b/connectivity/source/inc/ado/AUsers.hxx index 761071b6c31d..65365dbe0ed7 100644 --- a/connectivity/source/inc/ado/AUsers.hxx +++ b/connectivity/source/inc/ado/AUsers.hxx @@ -38,7 +38,7 @@ namespace connectivity virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OUsers( OCatalog* _pParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/ado/AViews.hxx b/connectivity/source/inc/ado/AViews.hxx index b94f9653bf6f..02a3ba3bb73c 100644 --- a/connectivity/source/inc/ado/AViews.hxx +++ b/connectivity/source/inc/ado/AViews.hxx @@ -40,7 +40,7 @@ namespace connectivity virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); void setComments(const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ) throw(::com::sun::star::sdbc::SQLException, ::com::sun::star::uno::RuntimeException); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OViews(OCatalog* _pParent, ::osl::Mutex& _rMutex, const TStringVector &_rVector, diff --git a/connectivity/source/inc/dbase/DColumns.hxx b/connectivity/source/inc/dbase/DColumns.hxx index 1abf17341fae..c01604621616 100644 --- a/connectivity/source/inc/dbase/DColumns.hxx +++ b/connectivity/source/inc/dbase/DColumns.hxx @@ -33,7 +33,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); public: ODbaseColumns(file::OFileTable* _pTable, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/dbase/DIndexes.hxx b/connectivity/source/inc/dbase/DIndexes.hxx index 773797f457a3..14e397c1aa2a 100644 --- a/connectivity/source/inc/dbase/DIndexes.hxx +++ b/connectivity/source/inc/dbase/DIndexes.hxx @@ -39,7 +39,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); public: ODbaseIndexes(ODbaseTable* _pTable, ::osl::Mutex& _rMutex, const TStringVector &_rVector) : ODbaseIndexes_BASE(*_pTable,_pTable->getConnection()->getMetaData()->supportsMixedCaseQuotedIdentifiers(),_rMutex,_rVector) diff --git a/connectivity/source/inc/dbase/DTables.hxx b/connectivity/source/inc/dbase/DTables.hxx index 4c05ae1f2925..52e7d19f8b87 100644 --- a/connectivity/source/inc/dbase/DTables.hxx +++ b/connectivity/source/inc/dbase/DTables.hxx @@ -36,7 +36,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); public: ODbaseTables(const ::com::sun::star::uno::Reference< ::com::sun::star::sdbc::XDatabaseMetaData >& _rMetaData,::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, const TStringVector &_rVector) : ODbaseTables_BASE(_rMetaData,_rParent,_rMutex,_rVector) diff --git a/connectivity/source/inc/file/quotedstring.hxx b/connectivity/source/inc/file/quotedstring.hxx index 77c7b7a7c474..9f27eb39fa1f 100644 --- a/connectivity/source/inc/file/quotedstring.hxx +++ b/connectivity/source/inc/file/quotedstring.hxx @@ -39,7 +39,7 @@ namespace connectivity sal_Int32 GetTokenCount( sal_Unicode cTok , sal_Unicode cStrDel ) const; OUString GetTokenSpecial(sal_Int32& nStartPos, sal_Unicode cTok = ';', sal_Unicode cStrDel = '\0') const; inline OUString& GetString() { return m_sString; } - inline void SetString(OUString aStr) { m_sString = aStr;} + inline void SetString(const OUString& aStr) { m_sString = aStr;} inline sal_Int32 Len() const { return m_sString.getLength(); } inline operator OUString&() { return m_sString; } }; diff --git a/connectivity/source/inc/hsqldb/HTables.hxx b/connectivity/source/inc/hsqldb/HTables.hxx index e0a90bafa39e..2ed500729549 100644 --- a/connectivity/source/inc/hsqldb/HTables.hxx +++ b/connectivity/source/inc/hsqldb/HTables.hxx @@ -34,7 +34,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject); diff --git a/connectivity/source/inc/hsqldb/HTools.hxx b/connectivity/source/inc/hsqldb/HTools.hxx index 77a6a4af8052..bedef9122870 100644 --- a/connectivity/source/inc/hsqldb/HTools.hxx +++ b/connectivity/source/inc/hsqldb/HTools.hxx @@ -42,7 +42,7 @@ namespace connectivity { namespace hsqldb */ static void appendTableFilterCrit( OUStringBuffer& _inout_rBuffer, const OUString& _rCatalog, - const OUString _rSchema, const OUString _rName, + const OUString& _rSchema, const OUString& _rName, bool _bShortForm ); }; diff --git a/connectivity/source/inc/hsqldb/HUsers.hxx b/connectivity/source/inc/hsqldb/HUsers.hxx index b9a4a4bd100e..7ba5744b7ff6 100644 --- a/connectivity/source/inc/hsqldb/HUsers.hxx +++ b/connectivity/source/inc/hsqldb/HUsers.hxx @@ -39,7 +39,7 @@ namespace connectivity virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); public: OUsers( ::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/hsqldb/HViews.hxx b/connectivity/source/inc/hsqldb/HViews.hxx index a4fc4b348683..fc2cc726128a 100644 --- a/connectivity/source/inc/hsqldb/HViews.hxx +++ b/connectivity/source/inc/hsqldb/HViews.hxx @@ -36,7 +36,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); public: diff --git a/connectivity/source/inc/java/util/Property.hxx b/connectivity/source/inc/java/util/Property.hxx index 6e330b61b066..af2a5c36239e 100644 --- a/connectivity/source/inc/java/util/Property.hxx +++ b/connectivity/source/inc/java/util/Property.hxx @@ -34,7 +34,7 @@ namespace connectivity // A ctor that is needed for returning the object java_util_Properties( JNIEnv * pEnv, jobject myObj ) : java_lang_Object( pEnv, myObj ){} java_util_Properties( ); - void setProperty(const OUString key, const OUString& value); + void setProperty(const OUString& key, const OUString& value); }; } diff --git a/connectivity/source/inc/mysql/YTables.hxx b/connectivity/source/inc/mysql/YTables.hxx index 6ebd50782588..c6ae4b143faa 100644 --- a/connectivity/source/inc/mysql/YTables.hxx +++ b/connectivity/source/inc/mysql/YTables.hxx @@ -36,7 +36,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); void createTable( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); virtual OUString getNameForObject(const sdbcx::ObjectType& _xObject); diff --git a/connectivity/source/inc/mysql/YUsers.hxx b/connectivity/source/inc/mysql/YUsers.hxx index 6121dda76cba..6927b5ca1457 100644 --- a/connectivity/source/inc/mysql/YUsers.hxx +++ b/connectivity/source/inc/mysql/YUsers.hxx @@ -39,7 +39,7 @@ namespace connectivity virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos,const OUString& _sElementName); public: OUsers( ::cppu::OWeakObject& _rParent, ::osl::Mutex& _rMutex, diff --git a/connectivity/source/inc/mysql/YViews.hxx b/connectivity/source/inc/mysql/YViews.hxx index 83fa235afdac..12b33cefabab 100644 --- a/connectivity/source/inc/mysql/YViews.hxx +++ b/connectivity/source/inc/mysql/YViews.hxx @@ -35,7 +35,7 @@ namespace connectivity virtual void impl_refresh() throw(::com::sun::star::uno::RuntimeException); virtual ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet > createDescriptor(); virtual sdbcx::ObjectType appendObject( const OUString& _rForName, const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); - virtual void dropObject(sal_Int32 _nPos,const OUString _sElementName); + virtual void dropObject(sal_Int32 _nPos, const OUString& _sElementName); void createView( const ::com::sun::star::uno::Reference< ::com::sun::star::beans::XPropertySet >& descriptor ); public: diff --git a/connectivity/source/parse/sqliterator.cxx b/connectivity/source/parse/sqliterator.cxx index d024784b0f80..491fca43e886 100644 --- a/connectivity/source/parse/sqliterator.cxx +++ b/connectivity/source/parse/sqliterator.cxx @@ -119,7 +119,7 @@ namespace connectivity OUString m_sForbiddenQueryName; public: - ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString _rForbiddenQueryName ) + ForbidQueryName( OSQLParseTreeIteratorImpl& _rIteratorImpl, const OUString& _rForbiddenQueryName ) :m_rpAllForbiddenNames( _rIteratorImpl.m_pForbiddenQueryNames ) ,m_sForbiddenQueryName( _rForbiddenQueryName ) { diff --git a/connectivity/source/sdbcx/VCollection.cxx b/connectivity/source/sdbcx/VCollection.cxx index 597ca6a86661..0aec95bb8465 100644 --- a/connectivity/source/sdbcx/VCollection.cxx +++ b/connectivity/source/sdbcx/VCollection.cxx @@ -118,7 +118,7 @@ namespace m_aElements.push_back(m_aNameMap.insert(m_aNameMap.begin(), ObjectEntry(*i,ObjectType()))); } - virtual bool rename(const OUString _sOldName,const OUString _sNewName) + virtual bool rename(const OUString& _sOldName, const OUString& _sNewName) { bool bRet = false; ObjectIter aIter = m_aNameMap.find(_sOldName); @@ -518,7 +518,7 @@ void OCollection::insertElement(const OUString& _sElementName,const ObjectType& m_pElements->insert(_sElementName,_xElement); } -void OCollection::renameObject(const OUString _sOldName,const OUString _sNewName) +void OCollection::renameObject(const OUString& _sOldName, const OUString& _sNewName) { OSL_ENSURE(m_pElements->exists(_sOldName),"Element doesn't exist"); OSL_ENSURE(!m_pElements->exists(_sNewName),"Element already exists"); @@ -583,7 +583,7 @@ ObjectType OCollection::appendObject( const OUString& /*_rForName*/, const Refer return cloneDescriptor( descriptor ); } -void OCollection::dropObject(sal_Int32 /*_nPos*/,const OUString /*_sElementName*/) +void OCollection::dropObject(sal_Int32 /*_nPos*/, const OUString& /*_sElementName*/) { } -- cgit