From e3133ae2371b6e2d4b47daa6a3487ea4f2753315 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Thu, 23 Jan 2014 18:43:53 +0100 Subject: Let C++ inline functions return bool instead of sal_Bool ...to improve diagnosing misuses of boolean expressions in client code (cf. compilerplugins/clang/implicitboolconversion.cxx). This change should be transparent to client code. Missing overloads of insert() for bool have been added to OStringBuffer and OUStringBuffer (which required dropping one !VALID_CONVERSION check that would now pick that overload, but would be flagged by compilerplugins/clang/pointertobool.cxx). Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9 --- cppuhelper/source/implbase_ex.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'cppuhelper') diff --git a/cppuhelper/source/implbase_ex.cxx b/cppuhelper/source/implbase_ex.cxx index aeb054a67a52..c2a87fb72fb3 100644 --- a/cppuhelper/source/implbase_ex.cxx +++ b/cppuhelper/source/implbase_ex.cxx @@ -73,7 +73,7 @@ static inline bool __td_equals( SAL_THROW(()) { return ((pTDR1 == pTDR2) || - ((OUString const *)&pTDR1->pTypeName)->equals( *(OUString const *)&pTDR2->pTypeName ) != sal_False); + ((OUString const *)&pTDR1->pTypeName)->equals( *(OUString const *)&pTDR2->pTypeName )); } //-------------------------------------------------------------------------------------------------- static inline type_entry * __getTypeEntries( class_data * cd ) -- cgit