From a4b60b78ea36d55a2abf0e5efccd8530568d2209 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 30 Oct 2018 09:20:58 +0200 Subject: loplugin:returnconstant Change-Id: I5b859de6ccd908eee4356acbe1f12b441ab36df3 Reviewed-on: https://gerrit.libreoffice.org/62539 Tested-by: Jenkins Reviewed-by: Noel Grandin --- cui/source/tabpages/autocdlg.cxx | 6 +++--- cui/source/tabpages/macroass.cxx | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) (limited to 'cui/source/tabpages') diff --git a/cui/source/tabpages/autocdlg.cxx b/cui/source/tabpages/autocdlg.cxx index 2a08fa616064..1bc9ffc4b780 100644 --- a/cui/source/tabpages/autocdlg.cxx +++ b/cui/source/tabpages/autocdlg.cxx @@ -1652,10 +1652,11 @@ IMPL_LINK(OfaAutocorrExceptPage, NewDelButtonHdl, Button*, pBtn, void) IMPL_LINK(OfaAutocorrExceptPage, NewDelActionHdl, AutoCorrEdit&, rEdit, bool) { - return NewDelHdl(&rEdit); + NewDelHdl(&rEdit); + return false; } -bool OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) +void OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) { if((pBtn == m_pNewAbbrevPB || pBtn == m_pAbbrevED.get() ) && !m_pAbbrevED->GetText().isEmpty()) @@ -1679,7 +1680,6 @@ bool OfaAutocorrExceptPage::NewDelHdl(void const * pBtn) m_pDoubleCapsLB->RemoveEntry(m_pDoubleCapsED->GetText()); ModifyHdl(*m_pDoubleCapsED); } - return false; } IMPL_LINK(OfaAutocorrExceptPage, SelectHdl, ListBox&, rBox, void) diff --git a/cui/source/tabpages/macroass.cxx b/cui/source/tabpages/macroass.cxx index 9bd6a00f7d71..8f46be227a44 100644 --- a/cui/source/tabpages/macroass.cxx +++ b/cui/source/tabpages/macroass.cxx @@ -307,17 +307,18 @@ IMPL_LINK( SfxMacroTabPage, AssignDeleteClickHdl_Impl, Button*, pBtn, void ) IMPL_LINK( SfxMacroTabPage, AssignDeleteHdl_Impl, SvTreeListBox*, pBtn, bool ) { - return AssignDeleteHdl(pBtn); + AssignDeleteHdl(pBtn); + return false; } -bool SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) +void SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) { SvHeaderTabListBox& rListBox = mpImpl->pEventLB->GetListBox(); SvTreeListEntry* pE = rListBox.FirstSelected(); if( !pE || LISTBOX_ENTRY_NOTFOUND == rListBox.GetModel()->GetAbsPos( pE ) ) { DBG_ASSERT( pE, "Where does the empty entry come from?" ); - return false; + return; } const bool bAssEnabled = pBtn != mpImpl->pDeletePB && mpImpl->pAssignPB->IsEnabled(); @@ -351,7 +352,6 @@ bool SfxMacroTabPage::AssignDeleteHdl(Control const * pBtn) rListBox.SetUpdateMode( true ); EnableButtons(); - return false; } IMPL_LINK( SfxMacroTabPage, TimeOut_Impl, Timer*,, void ) -- cgit