From 2c16ea16b305dc546164e28cf6b212ebccc44ec4 Mon Sep 17 00:00:00 2001 From: Balazs Varga Date: Mon, 22 Jan 2024 13:19:26 +0100 Subject: tdf#159128 UI: Open Security settings option directly Open Security Option Setting page directly from Security pop up warning infobar. Follow up of 1f440348eb0892fd2c9597806d87b5fe9d60d49a (tdf#157482 UI: Turn Security Warnings popup windows into infobars) Change-Id: Iac116677801bdb13a9680bcfdf532ec3d874ce0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162393 Tested-by: Jenkins Reviewed-by: Balazs Varga --- cui/source/factory/dlgfact.cxx | 11 +++++ cui/source/factory/dlgfact.hxx | 8 ++++ cui/source/inc/securityoptions.hxx | 83 ++++++++++++++++++++++++++++++++++ cui/source/options/optinet2.cxx | 39 ++-------------- cui/source/options/securityoptions.cxx | 31 ++++++++++++- cui/source/options/securityoptions.hxx | 82 --------------------------------- 6 files changed, 135 insertions(+), 119 deletions(-) create mode 100644 cui/source/inc/securityoptions.hxx delete mode 100644 cui/source/options/securityoptions.hxx (limited to 'cui') diff --git a/cui/source/factory/dlgfact.cxx b/cui/source/factory/dlgfact.cxx index b5e852cbb292..6979167de569 100644 --- a/cui/source/factory/dlgfact.cxx +++ b/cui/source/factory/dlgfact.cxx @@ -116,6 +116,7 @@ IMPL_ABSTDLG_CLASS(AbstractScreenshotAnnotationDlg) IMPL_ABSTDLG_CLASS_ASYNC(AbstractSignatureLineDialog, SignatureLineDialog) IMPL_ABSTDLG_CLASS_ASYNC(AbstractSignSignatureLineDialog, SignSignatureLineDialog) IMPL_ABSTDLG_CLASS_ASYNC(AbstractSvxCharacterMapDialog, SvxCharacterMap) +IMPL_ABSTDLG_CLASS(AbstractSecurityOptionsDialog) IMPL_ABSTDLG_CLASS(AbstractSvxHpLinkDlg) IMPL_ABSTDLG_CLASS(AbstractSvxJSearchOptionsDialog) IMPL_ABSTDLG_CLASS(AbstractSvxMultiPathDialog) @@ -874,6 +875,16 @@ VclPtr AbstractDialogFactory_Impl::CreateFrameDialog(weld::Wi return nullptr; } +VclPtr AbstractDialogFactory_Impl::CreateSvxSecurityOptionsDialog(weld::Window* pParent) +{ + return VclPtr::Create(std::make_unique(pParent)); +} + +bool AbstractSecurityOptionsDialog_Impl::SetSecurityOptions() +{ + return m_xDlg->SetSecurityOptions(); +} + // TabDialog outside the drawing layer VclPtr AbstractDialogFactory_Impl::CreateAutoCorrTabDialog(weld::Window* pParent, const SfxItemSet* pAttrSet) { diff --git a/cui/source/factory/dlgfact.hxx b/cui/source/factory/dlgfact.hxx index 0125c975ae79..3c8601140164 100644 --- a/cui/source/factory/dlgfact.hxx +++ b/cui/source/factory/dlgfact.hxx @@ -49,6 +49,7 @@ #include #include #include +#include #include #include #include @@ -402,6 +403,11 @@ DECL_ABSTDLG_CLASS_SHARED_ASYNC(AbstractSvxCharacterMapDialog,SfxAbstractDialog, DECL_ABSTDLG_CLASS(AbstractScreenshotAnnotationDlg,ScreenshotAnnotationDlg) }; +// AbstractSecurityOptionsDialog_Impl +DECL_ABSTDLG_CLASS(AbstractSecurityOptionsDialog, svx::SecurityOptionsDialog) + virtual bool SetSecurityOptions() override; +}; + // AbstractSignatureLineDialog_Impl DECL_ABSTDLG_CLASS_ASYNC(AbstractSignatureLineDialog,SignatureLineDialog) virtual void Apply() override { m_xDlg->Apply(); } @@ -594,6 +600,8 @@ public: virtual VclPtr CreateScreenshotAnnotationDlg(weld::Dialog& rParentDialog) override; + virtual VclPtr CreateSvxSecurityOptionsDialog(weld::Window* pParent) override; + virtual VclPtr CreateSignatureLineDialog(weld::Window* pParent, const css::uno::Reference xModel, bool bEditExisting) override; diff --git a/cui/source/inc/securityoptions.hxx b/cui/source/inc/securityoptions.hxx new file mode 100644 index 000000000000..981c9ac29bf8 --- /dev/null +++ b/cui/source/inc/securityoptions.hxx @@ -0,0 +1,83 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + * + * This file incorporates work covered by the following license notice: + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed + * with this work for additional information regarding copyright + * ownership. The ASF licenses this file to you under the Apache + * License, Version 2.0 (the "License"); you may not use this file + * except in compliance with the License. You may obtain a copy of + * the License at http://www.apache.org/licenses/LICENSE-2.0 . + */ +#pragma once + +#include + +namespace svx +{ + class SecurityOptionsDialog : public weld::GenericDialogController + { + private: + std::unique_ptr m_xSaveOrSendDocsCB; + std::unique_ptr m_xSaveOrSendDocsImg; + std::unique_ptr m_xSignDocsCB; + std::unique_ptr m_xSignDocsImg; + std::unique_ptr m_xPrintDocsCB; + std::unique_ptr m_xPrintDocsImg; + std::unique_ptr m_xCreatePdfCB; + std::unique_ptr m_xCreatePdfImg; + + std::unique_ptr m_xRemovePersInfoCB; + std::unique_ptr m_xRemovePersInfoImg; + std::unique_ptr m_xRecommPasswdCB; + std::unique_ptr m_xRecommPasswdImg; + std::unique_ptr m_xCtrlHyperlinkCB; + std::unique_ptr m_xCtrlHyperlinkImg; + std::unique_ptr m_xBlockUntrustedRefererLinksCB; + std::unique_ptr m_xBlockUntrustedRefererLinksImg; + std::unique_ptr m_xDisableActiveContentCB; + std::unique_ptr m_xDisableActiveContentImg; + + std::unique_ptr m_xRedlineinfoCB; + std::unique_ptr m_xRedlineinfoImg; + std::unique_ptr m_xDocPropertiesCB; + std::unique_ptr m_xDocPropertiesImg; + std::unique_ptr m_xNoteAuthorCB; + std::unique_ptr m_xNoteAuthorImg; + std::unique_ptr m_xDocumentVersionCB; + std::unique_ptr m_xDocumentVersionImg; + + public: + SecurityOptionsDialog(weld::Window* pParent); + + void init(); + + bool IsSaveOrSendDocsChecked() const { return m_xSaveOrSendDocsCB->get_active(); } + bool IsSignDocsChecked() const { return m_xSignDocsCB->get_active(); } + bool IsPrintDocsChecked() const { return m_xPrintDocsCB->get_active(); } + bool IsCreatePdfChecked() const { return m_xCreatePdfCB->get_active(); } + bool IsRemovePersInfoChecked() const { return m_xRemovePersInfoCB->get_active(); } + bool IsRemoveRedlineInfoChecked() const { return m_xRedlineinfoCB->get_active(); } + bool IsRemoveDocUserInfoChecked() const { return m_xDocPropertiesCB->get_active(); } + bool IsRemoveNoteAuthorInfoChecked() const { return m_xNoteAuthorCB->get_active(); } + bool IsRemoveDocVersionInfoChecked() const { return m_xDocumentVersionCB->get_active(); } + bool IsRecommPasswdChecked() const { return m_xRecommPasswdCB->get_active(); } + bool IsCtrlHyperlinkChecked() const { return m_xCtrlHyperlinkCB->get_active(); } + bool IsBlockUntrustedRefererLinksChecked() const { return m_xBlockUntrustedRefererLinksCB->get_active(); } + bool IsDisableActiveContentChecked() const { return m_xDisableActiveContentCB->get_active(); } + + DECL_LINK(ShowPersonalInfosToggle, weld::Toggleable&, void); + + bool SetSecurityOptions(); + void changeKeepSecurityInfosEnabled(); + }; +} + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/cui/source/options/optinet2.cxx b/cui/source/options/optinet2.cxx index de34b031e8ce..eaf0e8616bfd 100644 --- a/cui/source/options/optinet2.cxx +++ b/cui/source/options/optinet2.cxx @@ -27,7 +27,6 @@ #include #include #include -#include #include #include @@ -52,7 +51,7 @@ #include #include #include -#include "securityoptions.hxx" +#include #include "webconninfo.hxx" #include "certpath.hxx" #include "tsaurls.hxx" @@ -834,25 +833,6 @@ DeactivateRC SvxSecurityTabPage::DeactivatePage( SfxItemSet* _pSet ) return DeactivateRC::LeavePage; } -namespace -{ - bool CheckAndSave( SvtSecurityOptions::EOption _eOpt, const bool _bIsChecked, bool& _rModified ) - { - bool bModified = false; - if ( !SvtSecurityOptions::IsReadOnly( _eOpt ) ) - { - bModified = SvtSecurityOptions::IsOptionSet( _eOpt ) != _bIsChecked; - if ( bModified ) - { - SvtSecurityOptions::SetOption( _eOpt, _bIsChecked ); - _rModified = true; - } - } - - return bModified; - } -} - OUString SvxSecurityTabPage::GetAllStrings() { OUString sAllStrings; @@ -892,21 +872,8 @@ bool SvxSecurityTabPage::FillItemSet( SfxItemSet* ) { bool bModified = false; - if (m_xSecOptDlg) - { - CheckAndSave( SvtSecurityOptions::EOption::DocWarnSaveOrSend, m_xSecOptDlg->IsSaveOrSendDocsChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnSigning, m_xSecOptDlg->IsSignDocsChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnPrint, m_xSecOptDlg->IsPrintDocsChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnCreatePdf, m_xSecOptDlg->IsCreatePdfChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnRemovePersonalInfo, m_xSecOptDlg->IsRemovePersInfoChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnKeepRedlineInfo, m_xSecOptDlg->IsRemoveRedlineInfoChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnKeepDocUserInfo, m_xSecOptDlg->IsRemoveDocUserInfoChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnKeepNoteAuthorDateInfo, m_xSecOptDlg->IsRemoveNoteAuthorInfoChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnKeepDocVersionInfo, m_xSecOptDlg->IsRemoveDocVersionInfoChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DocWarnRecommendPassword, m_xSecOptDlg->IsRecommPasswdChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::CtrlClickHyperlink, m_xSecOptDlg->IsCtrlHyperlinkChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::BlockUntrustedRefererLinks, m_xSecOptDlg->IsBlockUntrustedRefererLinksChecked(), bModified ); - CheckAndSave( SvtSecurityOptions::EOption::DisableActiveContent, m_xSecOptDlg->IsDisableActiveContentChecked(), bModified ); + if (m_xSecOptDlg) { + bModified = m_xSecOptDlg->SetSecurityOptions(); } std::shared_ptr pBatch( diff --git a/cui/source/options/securityoptions.cxx b/cui/source/options/securityoptions.cxx index 8f970331d9a3..f42b0c35dd4b 100644 --- a/cui/source/options/securityoptions.cxx +++ b/cui/source/options/securityoptions.cxx @@ -17,8 +17,8 @@ * the License at http://www.apache.org/licenses/LICENSE-2.0 . */ +#include #include -#include "securityoptions.hxx" namespace { @@ -31,6 +31,15 @@ namespace rCheckBox.set_active(SvtSecurityOptions::IsOptionSet(eOption)); return bEnable; } + + void CheckAndSave(SvtSecurityOptions::EOption _eOpt, const bool _bIsChecked, bool& _rModified) + { + if (!SvtSecurityOptions::IsReadOnly(_eOpt) && SvtSecurityOptions::IsOptionSet(_eOpt) != _bIsChecked) + { + SvtSecurityOptions::SetOption(_eOpt, _bIsChecked); + _rModified = true; + } + } } namespace svx @@ -107,6 +116,26 @@ void SecurityOptionsDialog::init() changeKeepSecurityInfosEnabled(); } +bool SecurityOptionsDialog::SetSecurityOptions() +{ + bool bModified = false; + CheckAndSave(SvtSecurityOptions::EOption::DocWarnSaveOrSend, IsSaveOrSendDocsChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnSigning, IsSignDocsChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnPrint, IsPrintDocsChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnCreatePdf, IsCreatePdfChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnRemovePersonalInfo, IsRemovePersInfoChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnKeepRedlineInfo, IsRemoveRedlineInfoChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnKeepDocUserInfo, IsRemoveDocUserInfoChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnKeepNoteAuthorDateInfo, IsRemoveNoteAuthorInfoChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnKeepDocVersionInfo, IsRemoveDocVersionInfoChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DocWarnRecommendPassword, IsRecommPasswdChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::CtrlClickHyperlink, IsCtrlHyperlinkChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::BlockUntrustedRefererLinks, IsBlockUntrustedRefererLinksChecked(), bModified); + CheckAndSave(SvtSecurityOptions::EOption::DisableActiveContent, IsDisableActiveContentChecked(), bModified); + + return bModified; +} + void SecurityOptionsDialog::changeKeepSecurityInfosEnabled() { bool bEnable = m_xRemovePersInfoCB->get_active(); diff --git a/cui/source/options/securityoptions.hxx b/cui/source/options/securityoptions.hxx deleted file mode 100644 index 10534d4426a7..000000000000 --- a/cui/source/options/securityoptions.hxx +++ /dev/null @@ -1,82 +0,0 @@ -/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ -/* - * This file is part of the LibreOffice project. - * - * This Source Code Form is subject to the terms of the Mozilla Public - * License, v. 2.0. If a copy of the MPL was not distributed with this - * file, You can obtain one at http://mozilla.org/MPL/2.0/. - * - * This file incorporates work covered by the following license notice: - * - * Licensed to the Apache Software Foundation (ASF) under one or more - * contributor license agreements. See the NOTICE file distributed - * with this work for additional information regarding copyright - * ownership. The ASF licenses this file to you under the Apache - * License, Version 2.0 (the "License"); you may not use this file - * except in compliance with the License. You may obtain a copy of - * the License at http://www.apache.org/licenses/LICENSE-2.0 . - */ -#pragma once - -#include - -namespace svx -{ - class SecurityOptionsDialog : public weld::GenericDialogController - { - private: - std::unique_ptr m_xSaveOrSendDocsCB; - std::unique_ptr m_xSaveOrSendDocsImg; - std::unique_ptr m_xSignDocsCB; - std::unique_ptr m_xSignDocsImg; - std::unique_ptr m_xPrintDocsCB; - std::unique_ptr m_xPrintDocsImg; - std::unique_ptr m_xCreatePdfCB; - std::unique_ptr m_xCreatePdfImg; - - std::unique_ptr m_xRemovePersInfoCB; - std::unique_ptr m_xRemovePersInfoImg; - std::unique_ptr m_xRecommPasswdCB; - std::unique_ptr m_xRecommPasswdImg; - std::unique_ptr m_xCtrlHyperlinkCB; - std::unique_ptr m_xCtrlHyperlinkImg; - std::unique_ptr m_xBlockUntrustedRefererLinksCB; - std::unique_ptr m_xBlockUntrustedRefererLinksImg; - std::unique_ptr m_xDisableActiveContentCB; - std::unique_ptr m_xDisableActiveContentImg; - - std::unique_ptr m_xRedlineinfoCB; - std::unique_ptr m_xRedlineinfoImg; - std::unique_ptr m_xDocPropertiesCB; - std::unique_ptr m_xDocPropertiesImg; - std::unique_ptr m_xNoteAuthorCB; - std::unique_ptr m_xNoteAuthorImg; - std::unique_ptr m_xDocumentVersionCB; - std::unique_ptr m_xDocumentVersionImg; - - public: - SecurityOptionsDialog(weld::Window* pParent); - - void init(); - - bool IsSaveOrSendDocsChecked() const { return m_xSaveOrSendDocsCB->get_active(); } - bool IsSignDocsChecked() const { return m_xSignDocsCB->get_active(); } - bool IsPrintDocsChecked() const { return m_xPrintDocsCB->get_active(); } - bool IsCreatePdfChecked() const { return m_xCreatePdfCB->get_active(); } - bool IsRemovePersInfoChecked() const { return m_xRemovePersInfoCB->get_active(); } - bool IsRemoveRedlineInfoChecked() const { return m_xRedlineinfoCB->get_active(); } - bool IsRemoveDocUserInfoChecked() const { return m_xDocPropertiesCB->get_active(); } - bool IsRemoveNoteAuthorInfoChecked() const { return m_xNoteAuthorCB->get_active(); } - bool IsRemoveDocVersionInfoChecked() const { return m_xDocumentVersionCB->get_active(); } - bool IsRecommPasswdChecked() const { return m_xRecommPasswdCB->get_active(); } - bool IsCtrlHyperlinkChecked() const { return m_xCtrlHyperlinkCB->get_active(); } - bool IsBlockUntrustedRefererLinksChecked() const { return m_xBlockUntrustedRefererLinksCB->get_active(); } - bool IsDisableActiveContentChecked() const { return m_xDisableActiveContentCB->get_active(); } - - DECL_LINK(ShowPersonalInfosToggle, weld::Toggleable&, void); - - void changeKeepSecurityInfosEnabled(); - }; -} - -/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit