From 40fa3a61ac7dbe2ba73b5ee71bb85cc3bb4a27af Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 27 Oct 2020 23:18:23 +0100 Subject: Extend loplugin:elidestringvar to OString (In VisitVarDecl, filtering out AbstractConditionalOperator avoids an unhelpful > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:63:32: error: replace single use of literal 'rtl::OString' variable with a literal [loplugin:elidestringvar] > aXmlWriter.content(sPdfConformance); > ^~~~~~~~~~~~~~~ > ~/lo/core/vcl/source/pdf/XmpMetadata.cxx:52:21: note: literal 'rtl::OString' variable defined here [loplugin:elidestringvar] > OString sPdfConformance = (mnPDF_A == 1) ? "A" : "B"; > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ) Change-Id: I7d0410f04827d79b4b526752917c37d33cad2671 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104911 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- cui/source/dialogs/AdditionsDialog.cxx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'cui') diff --git a/cui/source/dialogs/AdditionsDialog.cxx b/cui/source/dialogs/AdditionsDialog.cxx index cf9a605d5970..dd994839681a 100644 --- a/cui/source/dialogs/AdditionsDialog.cxx +++ b/cui/source/dialogs/AdditionsDialog.cxx @@ -511,9 +511,7 @@ AdditionsDialog::AdditionsDialog(weld::Window* pParent, const OUString& sAdditio m_sTag = "allextensions"; // Means empty parameter } //FIXME: Temporary URL - OString sPrefixURL = "https://yusufketen.com/api/"; - OString sSuffixURL = ".json"; - OString rURL = sPrefixURL + m_sTag + sSuffixURL; + OString rURL = "https://yusufketen.com/api/" + m_sTag + ".json"; m_sURL = rURL; m_xExtensionManager -- cgit