From b9955b2083ffdc1f99bc8be6b09d806fa3279a16 Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Mon, 2 Apr 2018 08:54:59 +0100 Subject: tdf#93173: Remove arbitrary line spacing limit OASIS Open Document Format for Office Applications (OpenDocument) v.1.2 doesn't limit the value of fo:line-height. But we have arbitrary limits in proportional mode for both minimal (50%) and maximal (200%) values. The implementation uses sal_uInt16 to store the value, so fix places where sal_uInt8 was unreasonably used to set it, change the upper limit to max sal_uInt16 value, and set lower limit to 6% (to match Word's minimal factor of 0.06). Change-Id: I4c2ac5f0acf65d7573328e71bcf36ac9abb5ffd5 Reviewed-on: https://gerrit.libreoffice.org/52252 Tested-by: Jenkins Reviewed-by: Noel Grandin Reviewed-by: Katarina Behrens --- cui/source/tabpages/paragrph.cxx | 2 +- cui/uiconfig/ui/paraindentspacing.ui | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'cui') diff --git a/cui/source/tabpages/paragrph.cxx b/cui/source/tabpages/paragrph.cxx index 61cdb6603321..8d00045bcebd 100644 --- a/cui/source/tabpages/paragrph.cxx +++ b/cui/source/tabpages/paragrph.cxx @@ -124,7 +124,7 @@ void SetLineSpace_Impl( SvxLineSpacingItem& rLineSpace, case LLINESPACE_PROP: rLineSpace.SetLineSpaceRule( SvxLineSpaceRule::Auto ); - rLineSpace.SetPropLineSpace( static_cast(lValue) ); + rLineSpace.SetPropLineSpace( static_cast(lValue) ); break; case LLINESPACE_MIN: diff --git a/cui/uiconfig/ui/paraindentspacing.ui b/cui/uiconfig/ui/paraindentspacing.ui index fa98c493d871..7bb095e945f0 100644 --- a/cui/uiconfig/ui/paraindentspacing.ui +++ b/cui/uiconfig/ui/paraindentspacing.ui @@ -14,8 +14,8 @@ 10 - 50 - 200 + 6 + 65535 100 1 10 -- cgit