From 6e67c03dc0225fc66343546b14e902b9d238b1a3 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 14 Mar 2012 13:27:56 +0100 Subject: Enable -Wnon-virtual-dtor for GCC 4.6 ...which has the necessary features to support it. Change a lot of classes to either contain a protected non-virtual dtor (which is backwards compatible, so even works for cppumaker-generated UNO headers) or a public virtual one. cppuhelper/propertysetmixin.hxx still needs to disable the warning, as the relevant class has a non-virtual dtor but friends, which would still cause GCC to warn. Includes a patch for libcmis, intended to be upstreamed. --- dbaccess/inc/IController.hxx | 3 +++ dbaccess/inc/IReference.hxx | 3 +++ 2 files changed, 6 insertions(+) (limited to 'dbaccess/inc') diff --git a/dbaccess/inc/IController.hxx b/dbaccess/inc/IController.hxx index 962782ea5e18..78cce794e77e 100644 --- a/dbaccess/inc/IController.hxx +++ b/dbaccess/inc/IController.hxx @@ -130,6 +130,9 @@ namespace dbaui /** allows interception of user input, aka mouse clicks and key events */ virtual bool interceptUserInput( const NotifyEvent& _rEvent ) = 0; + + protected: + ~IController() {} }; } #endif // DBAUI_ICONTROLLER_HXX diff --git a/dbaccess/inc/IReference.hxx b/dbaccess/inc/IReference.hxx index 01534f6063e0..959a0b199d1f 100644 --- a/dbaccess/inc/IReference.hxx +++ b/dbaccess/inc/IReference.hxx @@ -38,6 +38,9 @@ namespace dbaui public: virtual void SAL_CALL acquire( ) throw () = 0; virtual void SAL_CALL release( ) throw () = 0; + + protected: + ~IReference() {} }; } #endif // DBAUI_IREFERENCE_HXX -- cgit