From 2a33953f6eb5da62042ea3731ef9d61666d5556f Mon Sep 17 00:00:00 2001 From: Alexander Wilms Date: Tue, 25 Feb 2014 18:11:51 +0100 Subject: Remove visual noise from dbaccess MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I1130439e5883672b4ca462838d72197acd6bc1f2 Reviewed-on: https://gerrit.libreoffice.org/8251 Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- .../qa/complex/dbaccess/ApplicationController.java | 14 ++-- dbaccess/qa/complex/dbaccess/Beamer.java | 8 +- dbaccess/qa/complex/dbaccess/CRMBasedTestCase.java | 10 +-- dbaccess/qa/complex/dbaccess/CopyTableWizard.java | 8 +- dbaccess/qa/complex/dbaccess/DataSource.java | 6 +- dbaccess/qa/complex/dbaccess/DatabaseDocument.java | 74 ++++++++--------- dbaccess/qa/complex/dbaccess/Parser.java | 12 +-- dbaccess/qa/complex/dbaccess/PropertyBag.java | 6 +- dbaccess/qa/complex/dbaccess/Query.java | 8 +- dbaccess/qa/complex/dbaccess/QueryInQuery.java | 16 ++-- dbaccess/qa/complex/dbaccess/RowSet.java | 92 +++++++++++----------- .../dbaccess/SingleSelectQueryComposer.java | 8 +- dbaccess/qa/complex/dbaccess/TestCase.java | 24 +++--- dbaccess/qa/complex/dbaccess/UISettings.java | 4 +- 14 files changed, 145 insertions(+), 145 deletions(-) (limited to 'dbaccess/qa') diff --git a/dbaccess/qa/complex/dbaccess/ApplicationController.java b/dbaccess/qa/complex/dbaccess/ApplicationController.java index 2a66d5e096b8..674115e8cf6c 100644 --- a/dbaccess/qa/complex/dbaccess/ApplicationController.java +++ b/dbaccess/qa/complex/dbaccess/ApplicationController.java @@ -40,7 +40,7 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + /** complex test case for Base's application UI */ @@ -56,13 +56,13 @@ public class ApplicationController extends TestCase super(); } - // -------------------------------------------------------------------------------------------------------- + public String getTestObjectName() { return getClass().getName(); } - // -------------------------------------------------------------------------------------------------------- + private void impl_closeDocument() { if (m_database != null) @@ -74,7 +74,7 @@ public class ApplicationController extends TestCase } } - // -------------------------------------------------------------------------------------------------------- + private void impl_switchToDocument(String _documentURL) throws java.lang.Exception { // close previous database document @@ -101,7 +101,7 @@ public class ApplicationController extends TestCase docModel.getCurrentController()); } - // -------------------------------------------------------------------------------------------------------- + @Before @Override public void before() throws java.lang.Exception @@ -110,7 +110,7 @@ public class ApplicationController extends TestCase impl_switchToDocument(null); } - // -------------------------------------------------------------------------------------------------------- + @After @Override public void after() throws java.lang.Exception @@ -118,7 +118,7 @@ public class ApplicationController extends TestCase impl_closeDocument(); super.after(); } - // -------------------------------------------------------------------------------------------------------- + @Test public void checkSaveAs() throws Exception, IOException, java.lang.Exception diff --git a/dbaccess/qa/complex/dbaccess/Beamer.java b/dbaccess/qa/complex/dbaccess/Beamer.java index 97c4c6b4f45b..effc4cc555a5 100644 --- a/dbaccess/qa/complex/dbaccess/Beamer.java +++ b/dbaccess/qa/complex/dbaccess/Beamer.java @@ -47,7 +47,7 @@ import org.junit.Before; import org.junit.Test; // import org.openoffice.test.OfficeConnection; import static org.junit.Assert.*; -// ------------------------------------------ + /** complex test case for Base's application UI @@ -62,7 +62,7 @@ public class Beamer extends TestCase super(); } - // -------------------------------------------------------------------------------------------------------- + @Before @Override public void before() throws Exception, java.lang.Exception @@ -75,14 +75,14 @@ public class Beamer extends TestCase docModel = UnoRuntime.queryInterface(XModel.class, loadedComponent); } - // -------------------------------------------------------------------------------------------------------- + @After @Override public void after() { } - // -------------------------------------------------------------------------------------------------------- + @Test public void testBeamer() throws Exception, IOException, java.lang.Exception { diff --git a/dbaccess/qa/complex/dbaccess/CRMBasedTestCase.java b/dbaccess/qa/complex/dbaccess/CRMBasedTestCase.java index ea91937cbda0..81ffdbebf514 100644 --- a/dbaccess/qa/complex/dbaccess/CRMBasedTestCase.java +++ b/dbaccess/qa/complex/dbaccess/CRMBasedTestCase.java @@ -26,13 +26,13 @@ import java.util.logging.Logger; import org.junit.After; import org.junit.Before; import static org.junit.Assert.*; -// ------------------------------------------ + public abstract class CRMBasedTestCase extends TestCase { protected CRMDatabase m_database; - // -------------------------------------------------------------------------------------------------------- + protected void createTestCase() { try @@ -46,7 +46,7 @@ public abstract class CRMBasedTestCase extends TestCase } } - // -------------------------------------------------------------------------------------------------------- + @Before @Override public void before() @@ -54,7 +54,7 @@ public abstract class CRMBasedTestCase extends TestCase createTestCase(); } - // -------------------------------------------------------------------------------------------------------- + @After @Override public void after() @@ -72,7 +72,7 @@ public abstract class CRMBasedTestCase extends TestCase } } - // -------------------------------------------------------------------------------------------------------- + /** creates a SingleSelectQueryComposer for our connection */ protected final XSingleSelectQueryComposer createQueryComposer() throws com.sun.star.uno.Exception diff --git a/dbaccess/qa/complex/dbaccess/CopyTableWizard.java b/dbaccess/qa/complex/dbaccess/CopyTableWizard.java index 68fba3ddb793..419d6782d19e 100644 --- a/dbaccess/qa/complex/dbaccess/CopyTableWizard.java +++ b/dbaccess/qa/complex/dbaccess/CopyTableWizard.java @@ -42,7 +42,7 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + /** complex test case for Base's application UI */ @@ -58,7 +58,7 @@ public class CopyTableWizard extends CRMBasedTestCase super(); } - // -------------------------------------------------------------------------------------------------------- + @After @Override @@ -88,7 +88,7 @@ public class CopyTableWizard extends CRMBasedTestCase } } - // -------------------------------------------------------------------------------------------------------- + class CopyThread implements Runnable { @@ -217,5 +217,5 @@ public class CopyTableWizard extends CRMBasedTestCase { } } - // -------------------------------------------------------------------------------------------------------- + } diff --git a/dbaccess/qa/complex/dbaccess/DataSource.java b/dbaccess/qa/complex/dbaccess/DataSource.java index 7233c8838445..8adff3a23ed4 100644 --- a/dbaccess/qa/complex/dbaccess/DataSource.java +++ b/dbaccess/qa/complex/dbaccess/DataSource.java @@ -27,7 +27,7 @@ import connectivity.tools.HsqlDatabase; // ---------- junit imports ----------------- import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + public class DataSource extends TestCase @@ -36,7 +36,7 @@ public class DataSource extends TestCase HsqlDatabase m_database; connectivity.tools.DataSource m_dataSource; - // -------------------------------------------------------------------------------------------------------- + private void createTestCase() { try @@ -58,7 +58,7 @@ public class DataSource extends TestCase } } - // -------------------------------------------------------------------------------------------------------- + @Test public void testRegistrationName() { diff --git a/dbaccess/qa/complex/dbaccess/DatabaseDocument.java b/dbaccess/qa/complex/dbaccess/DatabaseDocument.java index 7f1ab1309811..6102084f48a3 100644 --- a/dbaccess/qa/complex/dbaccess/DatabaseDocument.java +++ b/dbaccess/qa/complex/dbaccess/DatabaseDocument.java @@ -82,7 +82,7 @@ import org.junit.After; import org.junit.Before; import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + public class DatabaseDocument extends TestCase implements com.sun.star.document.XDocumentEventListener { @@ -98,7 +98,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. private static short STATE_ON_LOAD_RECEIVED = 3; private short m_loadDocState = STATE_NOT_STARTED; - // ======================================================================================================== + /** a helper class which can be used by the Basic scripts in our test documents * to notify us of events in this document */ @@ -132,13 +132,13 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } }; - // ======================================================================================================== + private static String getCallbackComponentServiceName() { return "org.openoffice.complex.dbaccess.EventCallback"; } - // ======================================================================================================== + /** a factory for a CallbackComponent */ private class CallbackComponentFactory implements XSingleComponentFactory, XServiceInfo, XComponent @@ -200,7 +200,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } }; - // ======================================================================================================== + private class MacroExecutionApprove implements XInteractionHandler { @@ -244,8 +244,8 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } }; - // ======================================================================================================== - // -------------------------------------------------------------------------------------------------------- + + @Before public void before() throws java.lang.Exception { @@ -273,7 +273,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } } - // -------------------------------------------------------------------------------------------------------- + @After public void after() throws java.lang.Exception { @@ -298,7 +298,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. super.after(); } - // -------------------------------------------------------------------------------------------------------- + private static class UnoMethodDescriptor { @@ -312,7 +312,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } } - // -------------------------------------------------------------------------------------------------------- + private void impl_checkDocumentInitState(Object _document, boolean _isInitialized) { // things you cannot do with an uninitialized document: @@ -335,7 +335,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } } - // -------------------------------------------------------------------------------------------------------- + private XModel impl_createDocument() throws Exception { final XModel databaseDoc = UnoRuntime.queryInterface(XModel.class, getMSF().createInstance("com.sun.star.sdb.OfficeDatabaseDocument")); @@ -346,14 +346,14 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return databaseDoc; } - // -------------------------------------------------------------------------------------------------------- + private void impl_closeDocument(XModel _databaseDoc) throws CloseVetoException, IOException, Exception { final XCloseable closeDoc = UnoRuntime.queryInterface(XCloseable.class, _databaseDoc); closeDoc.close(true); } - // -------------------------------------------------------------------------------------------------------- + private XModel impl_createEmptyEmbeddedHSQLDocument() throws Exception, IOException { final XModel databaseDoc = UnoRuntime.queryInterface(XModel.class, getMSF().createInstance("com.sun.star.sdb.OfficeDatabaseDocument")); @@ -388,7 +388,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return databaseDoc; } - // -------------------------------------------------------------------------------------------------------- + @Test public void testLoadable() throws Exception, IOException { @@ -397,12 +397,12 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. // there's three methods how you can initialize a database document: - // .................................................................... + // 1. XStorable::storeAsURL // (this is for compatibility reasons, to not break existing code) // this test is already made in impl_createEmptyEmbeddedHSQLDocument - // .................................................................... + // 2. XLoadable::load databaseDoc = UnoRuntime.queryInterface(XModel.class, getMSF().createInstance("com.sun.star.sdb.OfficeDatabaseDocument")); documentURL = copyToTempFile(documentURL); @@ -423,7 +423,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. assureException( databaseDoc, XLoadable.class, "load", new Object[] { new PropertyValue[0] }, DoubleInitializationException.class ); - // .................................................................... + // 3. XLoadable::initNew impl_closeDocument(databaseDoc); databaseDoc = impl_createDocument(); @@ -439,7 +439,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. DoubleInitializationException.class ); } - // -------------------------------------------------------------------------------------------------------- + private PropertyValue[] impl_getMarkerLoadArgs() { return new PropertyValue[] @@ -449,7 +449,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. }; } - // -------------------------------------------------------------------------------------------------------- + private boolean impl_hasMarker( final PropertyValue[] _args ) { for ( int i=0; i<_args.length; ++i ) @@ -462,7 +462,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return false; } - // -------------------------------------------------------------------------------------------------------- + private PropertyValue[] impl_getDefaultLoadArgs() { return new PropertyValue[] @@ -471,7 +471,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. }; } - // -------------------------------------------------------------------------------------------------------- + private PropertyValue[] impl_getMacroExecLoadArgs() { return new PropertyValue[] @@ -482,7 +482,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. }; } - // -------------------------------------------------------------------------------------------------------- + private int impl_setMacroSecurityLevel(int _level) throws Exception { final XMultiServiceFactory configProvider = theDefaultProvider.get( @@ -503,14 +503,14 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return oldValue; } - // -------------------------------------------------------------------------------------------------------- + private XModel impl_loadDocument( final String _documentURL, final PropertyValue[] _loadArgs ) throws Exception { final XComponentLoader loader = UnoRuntime.queryInterface(XComponentLoader.class, getMSF().createInstance("com.sun.star.frame.Desktop")); return UnoRuntime.queryInterface(XModel.class, loader.loadComponentFromURL(_documentURL, _BLANK, 0, _loadArgs)); } - // -------------------------------------------------------------------------------------------------------- + private void impl_storeDocument( final XModel _document ) throws Exception, IOException { // store the document @@ -520,7 +520,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } - // -------------------------------------------------------------------------------------------------------- + private XModel impl_createDocWithMacro( final String _libName, final String _moduleName, final String _code ) throws Exception, IOException { // create an empty document @@ -535,7 +535,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return databaseDoc; } - // -------------------------------------------------------------------------------------------------------- + /** tests various aspects of database document "revenants" * * Well, I do not really have a good term for this ... The point is, database documents are in real @@ -604,7 +604,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. impl_closeDocument( databaseDoc ); } - // -------------------------------------------------------------------------------------------------------- + @Test public void testDocumentEvents() throws Exception, IOException { @@ -673,7 +673,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. impl_closeDocument(databaseDoc); } - // -------------------------------------------------------------------------------------------------------- + @Test public void testGlobalEvents() throws Exception, IOException { @@ -817,7 +817,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. impl_closeDocument(otherDoc); } - // -------------------------------------------------------------------------------------------------------- + private URL impl_getURL(String _completeURL) throws Exception { final URL[] url = @@ -830,7 +830,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return url[0]; } - // -------------------------------------------------------------------------------------------------------- + private void impl_raise(XModel _document) { final XFrame frame = _document.getCurrentController().getFrame(); @@ -838,7 +838,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. topWindow.toFront(); } - // -------------------------------------------------------------------------------------------------------- + private void impl_startObservingEvents(String _context) { System.out.println(" " + _context + " {"); @@ -852,7 +852,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } } - // -------------------------------------------------------------------------------------------------------- + private void impl_stopObservingEvents(ArrayList _actualEvents, String[] _expectedEvents, String _context) { try @@ -898,13 +898,13 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. } } - // -------------------------------------------------------------------------------------------------------- + int impl_waitForEvent(ArrayList _eventQueue, String _expectedEvent, int _maxMilliseconds) { return impl_waitForEvent(_eventQueue, _expectedEvent, _maxMilliseconds, 0); } - // -------------------------------------------------------------------------------------------------------- + int impl_waitForEvent(ArrayList _eventQueue, String _expectedEvent, int _maxMilliseconds, int _firstQueueElementToCheck) { synchronized (_eventQueue) @@ -938,7 +938,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. return -1; } - // -------------------------------------------------------------------------------------------------------- + void onDocumentEvent(DocumentEvent _Event) { if ("OnTitleChanged".equals(_Event.EventName)) @@ -967,7 +967,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. System.out.println(" document event: " + _Event.EventName); } - // -------------------------------------------------------------------------------------------------------- + public void documentEventOccured(DocumentEvent _Event) { if ("OnTitleChanged".equals(_Event.EventName)) @@ -985,7 +985,7 @@ public class DatabaseDocument extends TestCase implements com.sun.star.document. System.out.println(" global event: " + _Event.EventName); } - // -------------------------------------------------------------------------------------------------------- + public void disposing(EventObject _Event) { // not interested in diff --git a/dbaccess/qa/complex/dbaccess/Parser.java b/dbaccess/qa/complex/dbaccess/Parser.java index 0562c9021dcd..2c72173548dd 100644 --- a/dbaccess/qa/complex/dbaccess/Parser.java +++ b/dbaccess/qa/complex/dbaccess/Parser.java @@ -30,11 +30,11 @@ import com.sun.star.uno.UnoRuntime; // ---------- junit imports ----------------- import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + public class Parser extends CRMBasedTestCase { - // -------------------------------------------------------------------------------------------------------- + @Override protected void createTestCase() { @@ -50,7 +50,7 @@ public class Parser extends CRMBasedTestCase } } - // -------------------------------------------------------------------------------------------------------- + @Test public void checkWhere() throws Exception { @@ -88,7 +88,7 @@ public class Parser extends CRMBasedTestCase composer.setQuery( SELECT + queries[i]); } } - // -------------------------------------------------------------------------------------------------------- + /** verifies that aliases for inner queries work as expected */ @Test @@ -133,7 +133,7 @@ public class Parser extends CRMBasedTestCase "test is bogus!", caughtExpected ); } - // -------------------------------------------------------------------------------------------------------- + private void impl_checkParameters( final String _statement, final String[] _expectedParameterNames, final int[] _expectedParameterTypes,final String _context ) throws Exception { final XSingleSelectQueryComposer composer = createQueryComposer(); @@ -157,7 +157,7 @@ public class Parser extends CRMBasedTestCase } } - // -------------------------------------------------------------------------------------------------------- + /** verifies that the parser properly recognizes the types of parameters */ @Test diff --git a/dbaccess/qa/complex/dbaccess/PropertyBag.java b/dbaccess/qa/complex/dbaccess/PropertyBag.java index 608cd1d9916d..ea1c570b86b2 100644 --- a/dbaccess/qa/complex/dbaccess/PropertyBag.java +++ b/dbaccess/qa/complex/dbaccess/PropertyBag.java @@ -34,7 +34,7 @@ import com.sun.star.lang.XMultiServiceFactory; import org.junit.Before; import org.junit.Test; import static org.junit.Assert.*; -// ------------------------------------------ + public class PropertyBag extends TestCase { @@ -152,7 +152,7 @@ public class PropertyBag extends TestCase System.out.println( "checking PropertySetAccess via sequences" ); createStandardBag( false ); - // --------------------------------- + // XPropertyAccess.setPropertyValues final PropertyValue expectedValues[] = { @@ -175,7 +175,7 @@ public class PropertyBag extends TestCase } } - // --------------------------------- + // XPropertyAccess.getPropertyValues final PropertyValue currentValues[] = m_access.getPropertyValues(); for ( int i=0; i