From 94de7c0be2739de7fdaf11e9e55a1cc7083992f0 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 6 Mar 2019 16:41:25 +0100 Subject: Blacklist some dialogs which won't get properly initialized ...so that at least Clang -fsanitize=implicit-signed-integer-truncation would generate warnings for them Change-Id: I76fd0aaa8e61784053e2b367b302fdd68c3859b4 Reviewed-on: https://gerrit.libreoffice.org/68815 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- dbaccess/qa/unit/data/dbaccess-dialogs-test.txt | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) (limited to 'dbaccess/qa') diff --git a/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt b/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt index 1fd47cd605a4..bcf728a0f006 100644 --- a/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt +++ b/dbaccess/qa/unit/data/dbaccess-dialogs-test.txt @@ -33,6 +33,22 @@ # currently deactivated, leads to problems and the test to not work # This is typically a hint that these should be hard-coded in the # test case since they need some document and model data to work +# dbaccess/ui/joindialog.ui <- not calling ORelationControl::lateInit for +# DlgQryJoin::m_pTableControl member OTableListBoxControl::m_pRC_Tables leaves its +# BrowseBox::mvCols empty, causing "implicit conversion from type 'int' of value -1 (32-bit, +# signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit, +# unsigned)" when calling +# GetColumnId( static_cast(mvCols.size()) - 1 ); +# in BrowseBox::AutoSizeLastColumn (svtools/source/brwbox/brwbox1.cxx) with Clang +# -fsanitize=implicit-signed-integer-truncation +# dbaccess/ui/relationdialog.ui <- not calling ORelationControl::lateInit for +# ORelationDialog::m_xTableControl member OTableListBoxControl::m_pRC_Tables leaves its +# BrowseBox::mvCols empty, causing "implicit conversion from type 'int' of value -1 (32-bit, +# signed) to type 'sal_uInt16' (aka 'unsigned short') changed the value to 65535 (16-bit, +# unsigned)" when calling +# GetColumnId( static_cast(mvCols.size()) - 1 ); +# in BrowseBox::AutoSizeLastColumn (svtools/source/brwbox/brwbox1.cxx) with Clang +# -fsanitize=implicit-signed-integer-truncation # dbaccess/ui/rtfcopytabledialog.ui -> hangs execution, seems to wait for interaction somehow (?) dbaccess/ui/advancedsettingsdialog.ui @@ -88,11 +104,9 @@ dbaccess/ui/parametersdialog.ui dbaccess/ui/queryfilterdialog.ui dbaccess/ui/sortdialog.ui dbaccess/ui/querypropertiesdialog.ui -dbaccess/ui/relationdialog.ui dbaccess/ui/sqlexception.ui dbaccess/ui/textconnectionsettings.ui dbaccess/ui/password.ui -dbaccess/ui/joindialog.ui dbaccess/ui/tablesfilterdialog.ui dbaccess/ui/tablesjoindialog.ui dbaccess/ui/savemodifieddialog.ui -- cgit