From 009b889616561176a230bc041699271697f95bf6 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 31 May 2023 15:31:36 +0200 Subject: do not throw DisposedException when inside a dispose() method There is no need to do this, as the documentation of css.lang.XComponent::dispose at udkapi/com/sun/star/lang/XComponent.idl states: After this method has been called, the object should behave as passive as possible, thus it should ignore all calls Otherwise, the effect of throwing here is mostly to disturb the flow of logic in caller code, preventing other parts of teardown from proceeding smoothly. Change-Id: I30e6d1b35f85b727debf4405a995fdc0a4fccde6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152450 Tested-by: Noel Grandin Reviewed-by: Noel Grandin --- dbaccess/source/core/api/RowSet.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'dbaccess') diff --git a/dbaccess/source/core/api/RowSet.cxx b/dbaccess/source/core/api/RowSet.cxx index b6d73a0d4869..ec4edf6f0fb4 100644 --- a/dbaccess/source/core/api/RowSet.cxx +++ b/dbaccess/source/core/api/RowSet.cxx @@ -2872,7 +2872,7 @@ void ORowSetClone::close() { MutexGuard aGuard( m_aMutex ); if (WeakComponentImplHelper::rBHelper.bDisposed) - throw DisposedException(); + return; } dispose(); } -- cgit