From 442ab9ceeef471a0d08a97c5d248808e2cb03e2f Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 22 Jul 2015 20:12:48 +0100 Subject: cppcheck: noExplicitConstructor Change-Id: Ib80e7f6d055bead246db3028b4eab6edfabe3d2c --- .../source/ui/querydesign/QueryAddTabConnUndoAction.hxx | 4 ++-- dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx | 14 +++++++------- dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx | 4 ++-- dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx | 2 +- dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx | 3 ++- dbaccess/source/ui/querydesign/limitboxcontroller.hxx | 2 +- dbaccess/source/ui/querydesign/querycontroller.cxx | 2 +- dbaccess/source/ui/tabledesign/TEditControl.hxx | 2 +- dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx | 2 +- dbaccess/source/ui/tabledesign/TableUndo.hxx | 2 +- dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx | 2 +- dbaccess/source/ui/uno/ColumnControl.hxx | 2 +- dbaccess/source/ui/uno/ColumnModel.hxx | 2 +- dbaccess/source/ui/uno/DBTypeWizDlg.hxx | 2 +- 14 files changed, 23 insertions(+), 22 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx b/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx index 494e4fba1dcd..0c0db3f649b1 100644 --- a/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx +++ b/dbaccess/source/ui/querydesign/QueryAddTabConnUndoAction.hxx @@ -29,7 +29,7 @@ namespace dbaui class OQueryAddTabConnUndoAction : public OQueryTabConnUndoAction { public: - OQueryAddTabConnUndoAction(OQueryTableView* pOwner); + explicit OQueryAddTabConnUndoAction(OQueryTableView* pOwner); virtual void Undo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE; @@ -40,7 +40,7 @@ namespace dbaui class OQueryDelTabConnUndoAction : public OQueryTabConnUndoAction { public: - OQueryDelTabConnUndoAction(OQueryTableView* pOwner); + explicit OQueryDelTabConnUndoAction(OQueryTableView* pOwner); virtual void Undo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE; diff --git a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx index a009832b5624..b9a9f4a60463 100644 --- a/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx +++ b/dbaccess/source/ui/querydesign/QueryDesignFieldUndoAct.hxx @@ -57,12 +57,12 @@ namespace dbaui sal_Int32 m_nCellIndex; public: - OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox) + explicit OTabFieldCellModifiedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_MODIFY_CELL) ,m_nCellIndex(BROWSER_INVALIDID){ } - inline void SetCellContents(const OUString& str) { m_strNextCellContents = str; } - inline void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex = nIndex; } + void SetCellContents(const OUString& str) { m_strNextCellContents = str; } + void SetCellIndex(sal_Int32 nIndex) { m_nCellIndex = nIndex; } virtual void Undo() SAL_OVERRIDE; virtual void Redo() SAL_OVERRIDE { Undo(); } @@ -76,7 +76,7 @@ namespace dbaui long m_nNextWidth; public: - OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN), m_nNextWidth(0) { } + explicit OTabFieldSizedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OQueryDesignFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_SIZE_COLUMN), m_nNextWidth(0) { } inline void SetOriginalWidth(long nWidth) { m_nNextWidth = nWidth; } @@ -106,7 +106,7 @@ namespace dbaui virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->RemoveColumn(pDescr->GetColumnId());pOwner->LeaveUndoMode(); } public: - OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { } + explicit OTabFieldDelUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDDELETE) { } }; // OTabFieldDelUndoAct - Undo-Klasse fuer Anlegen eines Feldes @@ -119,7 +119,7 @@ namespace dbaui virtual void Redo() SAL_OVERRIDE { pOwner->EnterUndoMode();pOwner->InsertColumn(pDescr, m_nColumnPostion);pOwner->LeaveUndoMode();} public: - OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { } + explicit OTabFieldCreateUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDCREATE) { } }; // OTabFieldMovedUndoAct - Undo class when a field was moved inside the selection @@ -134,7 +134,7 @@ namespace dbaui } public: - OTabFieldMovedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDMOVED) { } + explicit OTabFieldMovedUndoAct(OSelectionBrowseBox* pSelBrwBox) : OTabFieldUndoAct(pSelBrwBox, STR_QUERY_UNDO_TABFIELDMOVED) { } }; } #endif // INCLUDED_DBACCESS_SOURCE_UI_QUERYDESIGN_QUERYDESIGNFIELDUNDOACT_HXX diff --git a/dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx b/dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx index afe22ca862e9..83dd52b3f2a5 100644 --- a/dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx +++ b/dbaccess/source/ui/querydesign/QueryTabWinShowUndoAct.hxx @@ -29,7 +29,7 @@ namespace dbaui class OQueryTabWinShowUndoAct : public OQueryTabWinUndoAct { public: - OQueryTabWinShowUndoAct(OQueryTableView* pOwner); + explicit OQueryTabWinShowUndoAct(OQueryTableView* pOwner); virtual ~OQueryTabWinShowUndoAct(); virtual void Undo() SAL_OVERRIDE; @@ -41,7 +41,7 @@ namespace dbaui class OQueryTabWinDelUndoAct : public OQueryTabWinUndoAct { public: - OQueryTabWinDelUndoAct(OQueryTableView* pOwner); + explicit OQueryTabWinDelUndoAct(OQueryTableView* pOwner); virtual ~OQueryTabWinDelUndoAct(); virtual void Undo() SAL_OVERRIDE; diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx index 954638d91316..2b0955c370f6 100644 --- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx +++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.cxx @@ -250,7 +250,7 @@ namespace protected: virtual void Select() SAL_OVERRIDE; public: - OSelectionBrwBoxHeader(OSelectionBrowseBox* pParent); + explicit OSelectionBrwBoxHeader(OSelectionBrowseBox* pParent); virtual ~OSelectionBrwBoxHeader() { disposeOnce(); } virtual void dispose() SAL_OVERRIDE { m_pBrowseBox.clear(); ::svt::EditBrowserHeader::dispose(); } }; diff --git a/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx b/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx index 4a1276767862..6e48bf033d1d 100644 --- a/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx +++ b/dbaccess/source/ui/querydesign/SelectionBrowseBox.hxx @@ -78,7 +78,8 @@ namespace dbaui bool m_bInUndoMode; DECL_LINK_TYPED(OnInvalidateTimer, Timer*, void); - public: OSelectionBrowseBox( vcl::Window* pParent ); + public: + explicit OSelectionBrowseBox( vcl::Window* pParent ); virtual ~OSelectionBrowseBox(); virtual void dispose() SAL_OVERRIDE; diff --git a/dbaccess/source/ui/querydesign/limitboxcontroller.hxx b/dbaccess/source/ui/querydesign/limitboxcontroller.hxx index 93401164eca1..1ced90514142 100644 --- a/dbaccess/source/ui/querydesign/limitboxcontroller.hxx +++ b/dbaccess/source/ui/querydesign/limitboxcontroller.hxx @@ -31,7 +31,7 @@ class LimitBoxController: public svt::ToolboxController, public ::com::sun::star::lang::XServiceInfo { public: - LimitBoxController( + explicit LimitBoxController( const com::sun::star::uno::Reference< com::sun::star::uno::XComponentContext >& rxContext ); virtual ~LimitBoxController(); diff --git a/dbaccess/source/ui/querydesign/querycontroller.cxx b/dbaccess/source/ui/querydesign/querycontroller.cxx index 24ae4e5e1506..d06a78f0c097 100644 --- a/dbaccess/source/ui/querydesign/querycontroller.cxx +++ b/dbaccess/source/ui/querydesign/querycontroller.cxx @@ -110,7 +110,7 @@ namespace dbaui } public: - OViewController(const Reference< XComponentContext >& _rM) : OQueryController(_rM){} + explicit OViewController(const Reference< XComponentContext >& _rM) : OQueryController(_rM){} // need by registration static OUString getImplementationName_Static() throw( RuntimeException ) diff --git a/dbaccess/source/ui/tabledesign/TEditControl.hxx b/dbaccess/source/ui/tabledesign/TEditControl.hxx index b56e8d8bb666..fe02afd68fef 100644 --- a/dbaccess/source/ui/tabledesign/TEditControl.hxx +++ b/dbaccess/source/ui/tabledesign/TEditControl.hxx @@ -121,7 +121,7 @@ namespace dbaui DECL_LINK(ControlPreNotifyHdl, NotifyEvent*); public: - OTableEditorCtrl(vcl::Window* pParentWin); + explicit OTableEditorCtrl(vcl::Window* pParentWin); virtual ~OTableEditorCtrl(); virtual void dispose() SAL_OVERRIDE; virtual bool CursorMoving(long nNewRow, sal_uInt16 nNewCol) SAL_OVERRIDE; diff --git a/dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx b/dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx index 68e43b70a048..f38f0fd99c26 100644 --- a/dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx +++ b/dbaccess/source/ui/tabledesign/TableFieldDescWin.hxx @@ -53,7 +53,7 @@ namespace dbaui virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) SAL_OVERRIDE; public: - OTableFieldDescWin( vcl::Window* pParent); + explicit OTableFieldDescWin( vcl::Window* pParent); virtual ~OTableFieldDescWin(); virtual void dispose() SAL_OVERRIDE; diff --git a/dbaccess/source/ui/tabledesign/TableUndo.hxx b/dbaccess/source/ui/tabledesign/TableUndo.hxx index 7646684e3a09..7022dea104a0 100644 --- a/dbaccess/source/ui/tabledesign/TableUndo.hxx +++ b/dbaccess/source/ui/tabledesign/TableUndo.hxx @@ -98,7 +98,7 @@ namespace dbaui virtual void Redo() SAL_OVERRIDE; public: TYPEINFO_OVERRIDE(); - OTableEditorDelUndoAct( OTableEditorCtrl* pOwner ); + explicit OTableEditorDelUndoAct( OTableEditorCtrl* pOwner ); virtual ~OTableEditorDelUndoAct(); }; diff --git a/dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx b/dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx index 3e2cb86fb94e..40ba3603258a 100644 --- a/dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx +++ b/dbaccess/source/ui/uno/AdvancedSettingsDlg.cxx @@ -39,7 +39,7 @@ namespace dbaui { protected: - OAdvancedSettingsDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); + explicit OAdvancedSettingsDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); public: // XTypeProvider diff --git a/dbaccess/source/ui/uno/ColumnControl.hxx b/dbaccess/source/ui/uno/ColumnControl.hxx index 5bb30cd1cc86..c02622fea2b6 100644 --- a/dbaccess/source/ui/uno/ColumnControl.hxx +++ b/dbaccess/source/ui/uno/ColumnControl.hxx @@ -33,7 +33,7 @@ namespace dbaui private: ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext> m_xContext; public: - OColumnControl(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext>& rxContext); + explicit OColumnControl(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext>& rxContext); // UnoControl virtual OUString GetComponentServiceName() SAL_OVERRIDE; diff --git a/dbaccess/source/ui/uno/ColumnModel.hxx b/dbaccess/source/ui/uno/ColumnModel.hxx index 1fa4941b7f6f..db2dc10c918e 100644 --- a/dbaccess/source/ui/uno/ColumnModel.hxx +++ b/dbaccess/source/ui/uno/ColumnModel.hxx @@ -68,7 +68,7 @@ protected: OColumnControlModel(const OColumnControlModel* _pSource ,const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory); public: - OColumnControlModel(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory); + explicit OColumnControlModel(const ::com::sun::star::uno::Reference< ::com::sun::star::lang::XMultiServiceFactory>& _rxFactory); // UNO Anbindung DECLARE_XINTERFACE( ) diff --git a/dbaccess/source/ui/uno/DBTypeWizDlg.hxx b/dbaccess/source/ui/uno/DBTypeWizDlg.hxx index 80e8830792b1..48217e2f09dc 100644 --- a/dbaccess/source/ui/uno/DBTypeWizDlg.hxx +++ b/dbaccess/source/ui/uno/DBTypeWizDlg.hxx @@ -31,7 +31,7 @@ class ODBTypeWizDialog { protected: - ODBTypeWizDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); + explicit ODBTypeWizDialog(const ::com::sun::star::uno::Reference< ::com::sun::star::uno::XComponentContext >& _rxORB); public: // XTypeProvider -- cgit