From 938821fb08e427864db6a10642f385bde9803f6c Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 22 Jul 2016 14:35:27 +0200 Subject: new loplugin overrideparam verify that parameters on override methods have the same set of default values for their params as their parent/super-methods do. Change-Id: Ibdbc1c6e417fbaa680ea025a6bbf5ba9c2e5bcd2 Reviewed-on: https://gerrit.libreoffice.org/27437 Tested-by: Jenkins Reviewed-by: Noel Grandin --- dbaccess/source/ui/dlg/detailpages.hxx | 2 +- dbaccess/source/ui/dlg/indexdialog.cxx | 2 +- dbaccess/source/ui/inc/indexdialog.hxx | 2 +- dbaccess/source/ui/inc/listviewitems.hxx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/ui/dlg/detailpages.hxx b/dbaccess/source/ui/dlg/detailpages.hxx index 5ce4eabf3e51..efd3456efc7c 100644 --- a/dbaccess/source/ui/dlg/detailpages.hxx +++ b/dbaccess/source/ui/dlg/detailpages.hxx @@ -175,7 +175,7 @@ namespace dbaui virtual bool FillItemSet( SfxItemSet* _rCoreAttrs ) override; virtual void implInitControls(const SfxItemSet& _rSet, bool _bSaveValue) override; - virtual void callModifiedHdl(void* pControl) override; + virtual void callModifiedHdl(void* pControl = nullptr) override; DECL_LINK_TYPED(OnTestJavaClickHdl, Button*, void); diff --git a/dbaccess/source/ui/dlg/indexdialog.cxx b/dbaccess/source/ui/dlg/indexdialog.cxx index 17707c8fd3f6..c864a2c105c0 100644 --- a/dbaccess/source/ui/dlg/indexdialog.cxx +++ b/dbaccess/source/ui/dlg/indexdialog.cxx @@ -145,7 +145,7 @@ namespace dbaui void DbaIndexList::SelectNoHandlerCall( SvTreeListEntry* _pEntry ) { disableSelectHandler(); - Select(_pEntry, true); + Select(_pEntry ); enableSelectHandler(); } diff --git a/dbaccess/source/ui/inc/indexdialog.hxx b/dbaccess/source/ui/inc/indexdialog.hxx index 41fd44166cf7..ee1534573e9f 100644 --- a/dbaccess/source/ui/inc/indexdialog.hxx +++ b/dbaccess/source/ui/inc/indexdialog.hxx @@ -54,7 +54,7 @@ namespace dbaui void SetEndEditHdl(const Link& _rHdl) { m_aEndEditHdl = _rHdl; } - virtual bool Select(SvTreeListEntry* pEntry, bool bSelect) override; + virtual bool Select(SvTreeListEntry* pEntry, bool bSelect = true) override; void enableSelectHandler(); void disableSelectHandler(); diff --git a/dbaccess/source/ui/inc/listviewitems.hxx b/dbaccess/source/ui/inc/listviewitems.hxx index 5244941adadf..134d0f641d28 100644 --- a/dbaccess/source/ui/inc/listviewitems.hxx +++ b/dbaccess/source/ui/inc/listviewitems.hxx @@ -43,7 +43,7 @@ namespace dbaui virtual void Paint(const Point& rPos, SvTreeListBox& rOutDev, vcl::RenderContext& rRenderContext, const SvViewDataEntry* pView, const SvTreeListEntry& rEntry) override; - virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* _pViewData) override; + virtual void InitViewData( SvTreeListBox* pView,SvTreeListEntry* pEntry, SvViewDataItem* _pViewData = nullptr) override; bool isEmphasized() const { return m_bEmphasized; } void emphasize(bool _bEmphasize) { m_bEmphasized = _bEmphasize; } -- cgit