From a7411c2ee537355dc8051b7059e3a4d0bc708c04 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Fri, 4 Oct 2019 10:34:24 +0100 Subject: document 0 len case of set_max_length MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change-Id: I8300ff2d68f35da38e2314eefa7f2a2184981eab Reviewed-on: https://gerrit.libreoffice.org/80194 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- dbaccess/source/ui/control/FieldDescControl.cxx | 4 ++-- dbaccess/source/ui/misc/WCPage.cxx | 4 +--- 2 files changed, 3 insertions(+), 5 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/ui/control/FieldDescControl.cxx b/dbaccess/source/ui/control/FieldDescControl.cxx index b9e20c788516..222cfe3808f9 100644 --- a/dbaccess/source/ui/control/FieldDescControl.cxx +++ b/dbaccess/source/ui/control/FieldDescControl.cxx @@ -496,7 +496,7 @@ void OFieldDescControl::ActivateAggregate( EControlType eType ) return; m_nPos++; { - sal_Int32 nMax = EDIT_NOLIMIT; + sal_Int32 nMax(0); OUString aTmpString; try { @@ -516,7 +516,7 @@ void OFieldDescControl::ActivateAggregate( EControlType eType ) m_xColumnName = std::make_unique( m_xBuilder->weld_entry("ColumnName"), aTmpString, STR_HELP_DEFAULT_VALUE, FIELD_PROPERTY_COLUMNNAME); - m_xColumnName->set_max_length(nMax ? nMax : EDIT_NOLIMIT); + m_xColumnName->set_max_length(nMax); m_xColumnName->setCheck( isSQL92CheckEnabled(getConnection()) ); } diff --git a/dbaccess/source/ui/misc/WCPage.cxx b/dbaccess/source/ui/misc/WCPage.cxx index 4ab6480ca136..d5f30a2d08ed 100644 --- a/dbaccess/source/ui/misc/WCPage.cxx +++ b/dbaccess/source/ui/misc/WCPage.cxx @@ -63,8 +63,6 @@ OCopyTable::OCopyTable(weld::Container* pPage, OCopyTableWizard* pWizard) , m_xFT_KeyName(m_xBuilder->weld_label("keynamelabel")) , m_xEdKeyName(m_xBuilder->weld_entry("keyname")) { - m_xEdTableName->set_max_length(EDIT_NOLIMIT); - if ( m_pParent->m_xDestConnection.is() ) { if (!m_pParent->supportsViews()) @@ -88,7 +86,7 @@ OCopyTable::OCopyTable(weld::Container* pPage, OCopyTableWizard* pWizard) m_xEdKeyName->set_text(m_pParent->createUniqueName("ID")); const sal_Int32 nMaxLen = m_pParent->getMaxColumnNameLength(); - m_xEdKeyName->set_max_length(nMaxLen ? nMaxLen : EDIT_NOLIMIT); + m_xEdKeyName->set_max_length(nMaxLen); } SetPageTitle(DBA_RES(STR_COPYTABLE_TITLE_COPY)); -- cgit