From e9c3583c2cc27fc88ee81047c236ec99dd51e8de Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 3 Jul 2015 11:31:14 +0200 Subject: improve the returnbyref loplugin Change-Id: I1b510a6194282dfa4a9001d473127c5ebc8b44eb Reviewed-on: https://gerrit.libreoffice.org/16731 Tested-by: Jenkins Reviewed-by: Noel Grandin --- dbaccess/source/ui/browser/dsEntriesNoExp.cxx | 10 +++++----- dbaccess/source/ui/control/tabletree.cxx | 10 +++++----- 2 files changed, 10 insertions(+), 10 deletions(-) (limited to 'dbaccess') diff --git a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx index 50d477d68625..85630214bb10 100644 --- a/dbaccess/source/ui/browser/dsEntriesNoExp.cxx +++ b/dbaccess/source/ui/browser/dsEntriesNoExp.cxx @@ -231,14 +231,14 @@ void SbaTableQueryBrowser::notifyHiContrastChanged() sal_uInt16 nCount = pEntryLoop->ItemCount(); for (sal_uInt16 i=0;iGetItem(i); - if (!pItem || pItem->GetType() != SV_ITEM_ID_LBOXCONTEXTBMP) + SvLBoxItem& rItem = pEntryLoop->GetItem(i); + if (rItem.GetType() != SV_ITEM_ID_LBOXCONTEXTBMP) continue; - SvLBoxContextBmp* pContextBitmapItem = static_cast< SvLBoxContextBmp* >( pItem ); + SvLBoxContextBmp& rContextBitmapItem = static_cast< SvLBoxContextBmp& >( rItem ); - pContextBitmapItem->SetBitmap1( aImage ); - pContextBitmapItem->SetBitmap2( aImage ); + rContextBitmapItem.SetBitmap1( aImage ); + rContextBitmapItem.SetBitmap2( aImage ); break; } diff --git a/dbaccess/source/ui/control/tabletree.cxx b/dbaccess/source/ui/control/tabletree.cxx index ed0083b5b56b..352b85c945ba 100644 --- a/dbaccess/source/ui/control/tabletree.cxx +++ b/dbaccess/source/ui/control/tabletree.cxx @@ -112,10 +112,10 @@ void OTableTreeListBox::notifyHiContrastChanged() size_t nCount = pEntryLoop->ItemCount(); for (size_t i=0;iGetItem(i); - if (pItem && pItem->GetType() == SV_ITEM_ID_LBOXCONTEXTBMP) + SvLBoxItem& rItem = pEntryLoop->GetItem(i); + if (rItem.GetType() == SV_ITEM_ID_LBOXCONTEXTBMP) { - SvLBoxContextBmp* pContextBitmapItem = static_cast< SvLBoxContextBmp* >( pItem ); + SvLBoxContextBmp& rContextBitmapItem = static_cast< SvLBoxContextBmp& >( rItem ); Image aImage; if ( isFolderEntry( pEntryLoop ) ) @@ -128,8 +128,8 @@ void OTableTreeListBox::notifyHiContrastChanged() m_xImageProvider->getImages( sCompleteName, DatabaseObject::TABLE, aImage ); } - pContextBitmapItem->SetBitmap1( aImage ); - pContextBitmapItem->SetBitmap2( aImage ); + rContextBitmapItem.SetBitmap1( aImage ); + rContextBitmapItem.SetBitmap2( aImage ); break; } } -- cgit