From 3428bd5fa3626844355f20997ba690fd04297982 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 11 Sep 2017 08:54:30 +0200 Subject: clang-tidy modernize-use-emplace in d* Change-Id: I79ac90faf24b4c741545e411dbaea7826c2df531 Reviewed-on: https://gerrit.libreoffice.org/42150 Tested-by: Jenkins Reviewed-by: Noel Grandin --- desktop/source/deployment/registry/component/dp_component.cxx | 5 ++--- desktop/source/deployment/registry/dp_backenddb.cxx | 4 ++-- desktop/source/deployment/registry/package/dp_package.cxx | 5 ++--- 3 files changed, 6 insertions(+), 8 deletions(-) (limited to 'desktop/source/deployment/registry') diff --git a/desktop/source/deployment/registry/component/dp_component.cxx b/desktop/source/deployment/registry/component/dp_component.cxx index 847fbf30fba9..4c5805b4b54a 100644 --- a/desktop/source/deployment/registry/component/dp_component.cxx +++ b/desktop/source/deployment/registry/component/dp_component.cxx @@ -1136,9 +1136,8 @@ void extractComponentData( css::uno::Reference< css::registry::XRegistryKey > > singletonKeys(singletons->openKeys()); for (sal_Int32 j = 0; j < singletonKeys.getLength(); ++j) { - data->singletons.push_back( - std::pair< OUString, OUString >( - singletonKeys[j]->getKeyName().copy(prefix2), name)); + data->singletons.emplace_back( + singletonKeys[j]->getKeyName().copy(prefix2), name); } } if (factories != nullptr) { diff --git a/desktop/source/deployment/registry/dp_backenddb.cxx b/desktop/source/deployment/registry/dp_backenddb.cxx index f44b1d7ac2f1..58f6e1137db5 100644 --- a/desktop/source/deployment/registry/dp_backenddb.cxx +++ b/desktop/source/deployment/registry/dp_backenddb.cxx @@ -368,8 +368,8 @@ BackendDb::readVectorOfPair( xpathApi->selectSingleNode(aPair, sExprSecond); OSL_ASSERT(first.is() && second.is()); - retVector.push_back(std::make_pair( - first->getNodeValue(), second->getNodeValue())); + retVector.emplace_back( + first->getNodeValue(), second->getNodeValue()); } return retVector; } diff --git a/desktop/source/deployment/registry/package/dp_package.cxx b/desktop/source/deployment/registry/package/dp_package.cxx index e5c061d021f9..d3d29d904dfc 100644 --- a/desktop/source/deployment/registry/package/dp_package.cxx +++ b/desktop/source/deployment/registry/package/dp_package.cxx @@ -861,9 +861,8 @@ void BackendImpl::PackageImpl::processPackage_( ::cppu::throwException(exc); } } - data.items.push_back( - std::make_pair(xPackage->getURL(), - xPackage->getPackageType()->getMediaType())); + data.items.emplace_back(xPackage->getURL(), + xPackage->getPackageType()->getMediaType()); } getMyBackend()->addDataToDb(getURL(), data); } -- cgit