From df5ec49bcaa57aa0a137db45d7c0766733f7e508 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 24 Jun 2015 17:35:37 +0100 Subject: cppcheck: noExplicitConstructor Change-Id: I80cd2975f17bb7fa57fa669873ef1dd8f3595a11 --- desktop/source/deployment/gui/dp_gui.h | 2 +- desktop/source/deployment/gui/dp_gui_dialog2.cxx | 4 ++-- desktop/source/deployment/gui/dp_gui_extlistbox.cxx | 2 +- desktop/source/deployment/gui/dp_gui_extlistbox.hxx | 6 +++--- desktop/source/deployment/gui/dp_gui_shared.hxx | 2 +- desktop/source/deployment/gui/dp_gui_updatedata.hxx | 2 +- desktop/source/deployment/gui/dp_gui_updatedialog.hxx | 2 +- desktop/source/deployment/manager/dp_commandenvironments.hxx | 6 +++--- desktop/source/deployment/manager/dp_extensionmanager.hxx | 2 +- desktop/source/deployment/manager/dp_informationprovider.cxx | 2 +- desktop/source/deployment/manager/dp_manager.cxx | 2 +- desktop/source/deployment/manager/dp_managerfac.cxx | 2 +- desktop/source/deployment/misc/dp_descriptioninfoset.cxx | 2 +- 13 files changed, 18 insertions(+), 18 deletions(-) (limited to 'desktop/source/deployment') diff --git a/desktop/source/deployment/gui/dp_gui.h b/desktop/source/deployment/gui/dp_gui.h index 0de1148b66f0..b99099f91f2b 100644 --- a/desktop/source/deployment/gui/dp_gui.h +++ b/desktop/source/deployment/gui/dp_gui.h @@ -68,7 +68,7 @@ enum PackageState { REGISTERED, NOT_REGISTERED, AMBIGUOUS, NOT_AVAILABLE }; class SelectedPackage: public salhelper::SimpleReferenceObject { public: SelectedPackage() {} - SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage) + explicit SelectedPackage( const ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage> &xPackage) : m_xPackage( xPackage ) {} diff --git a/desktop/source/deployment/gui/dp_gui_dialog2.cxx b/desktop/source/deployment/gui/dp_gui_dialog2.cxx index 2bea724819c0..86adb0289ff2 100644 --- a/desktop/source/deployment/gui/dp_gui_dialog2.cxx +++ b/desktop/source/deployment/gui/dp_gui_dialog2.cxx @@ -136,8 +136,8 @@ class ExtBoxWithBtns_Impl : public ExtensionBox_Impl DECL_DLLPRIVATE_LINK( HandleRemoveBtn, void * ); public: - ExtBoxWithBtns_Impl(vcl::Window* pParent); - virtual ~ExtBoxWithBtns_Impl(); + explicit ExtBoxWithBtns_Impl(vcl::Window* pParent); + virtual ~ExtBoxWithBtns_Impl(); virtual void dispose() SAL_OVERRIDE; void InitFromDialog(ExtMgrDialog *pParentDialog); diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx index 35b62467d148..3ff477c7afbb 100644 --- a/desktop/source/deployment/gui/dp_gui_extlistbox.cxx +++ b/desktop/source/deployment/gui/dp_gui_extlistbox.cxx @@ -47,7 +47,7 @@ struct FindWeakRef { const uno::Reference m_extension; - FindWeakRef( uno::Reference const & ext): m_extension(ext) {} + explicit FindWeakRef( uno::Reference const & ext): m_extension(ext) {} bool operator () (uno::WeakReference< deployment::XPackage > const & ref); }; diff --git a/desktop/source/deployment/gui/dp_gui_extlistbox.hxx b/desktop/source/deployment/gui/dp_gui_extlistbox.hxx index 6a027c48ba12..0d5ca8f6e4cd 100644 --- a/desktop/source/deployment/gui/dp_gui_extlistbox.hxx +++ b/desktop/source/deployment/gui/dp_gui_extlistbox.hxx @@ -96,8 +96,8 @@ class ExtensionRemovedListener : public ::cppu::WeakImplHelper1 const & aExt): + explicit UpdateData( ::com::sun::star::uno::Reference< ::com::sun::star::deployment::XPackage > const & aExt): bIsShared(false), aInstalledPackage(aExt), aUpdateSource(NULL), m_nID(0), m_bIgnored(false){}; //When entries added to the listbox then there can be one for the user update and one diff --git a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx index 18fa9de6ebde..76851b4301c1 100644 --- a/desktop/source/deployment/gui/dp_gui_updatedialog.hxx +++ b/desktop/source/deployment/gui/dp_gui_updatedialog.hxx @@ -115,7 +115,7 @@ private: sal_uInt16 getItemCount() const; private: - CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION; + explicit CheckListBox(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION; void operator =(UpdateDialog::CheckListBox &) SAL_DELETED_FUNCTION; virtual void MouseButtonDown(MouseEvent const & event) SAL_OVERRIDE; diff --git a/desktop/source/deployment/manager/dp_commandenvironments.hxx b/desktop/source/deployment/manager/dp_commandenvironments.hxx index d51d161591ed..b45c28ddd10b 100644 --- a/desktop/source/deployment/manager/dp_commandenvironments.hxx +++ b/desktop/source/deployment/manager/dp_commandenvironments.hxx @@ -44,7 +44,7 @@ protected: public: virtual ~BaseCommandEnv(); BaseCommandEnv(); - BaseCommandEnv( + explicit BaseCommandEnv( css::uno::Reference< css::task::XInteractionHandler> const & handler); // XCommandEnvironment @@ -70,7 +70,7 @@ class TmpRepositoryCommandEnv : public BaseCommandEnv { public: TmpRepositoryCommandEnv(); - TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler); + explicit TmpRepositoryCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler); // XInteractionHandler virtual void SAL_CALL handle( @@ -111,7 +111,7 @@ class NoLicenseCommandEnv : public BaseCommandEnv public: NoLicenseCommandEnv(){}; - NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler); + explicit NoLicenseCommandEnv(css::uno::Reference< css::task::XInteractionHandler> const & handler); // XInteractionHandler virtual void SAL_CALL handle( diff --git a/desktop/source/deployment/manager/dp_extensionmanager.hxx b/desktop/source/deployment/manager/dp_extensionmanager.hxx index 47a3e963292c..1c2cea9147bb 100644 --- a/desktop/source/deployment/manager/dp_extensionmanager.hxx +++ b/desktop/source/deployment/manager/dp_extensionmanager.hxx @@ -44,7 +44,7 @@ class ExtensionManager : private ::dp_misc::MutexHolder, public ::cppu::WeakComponentImplHelper1< css::deployment::XExtensionManager > { public: - ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext); + explicit ExtensionManager( css::uno::Reference< css::uno::XComponentContext >const& xContext); virtual ~ExtensionManager(); static css::uno::Sequence< OUString > getServiceNames(); diff --git a/desktop/source/deployment/manager/dp_informationprovider.cxx b/desktop/source/deployment/manager/dp_informationprovider.cxx index be263726fb03..b550f091482d 100644 --- a/desktop/source/deployment/manager/dp_informationprovider.cxx +++ b/desktop/source/deployment/manager/dp_informationprovider.cxx @@ -63,7 +63,7 @@ class PackageInformationProvider : { public: - PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext); + explicit PackageInformationProvider( uno::Reference< uno::XComponentContext >const& xContext); virtual ~PackageInformationProvider(); // XPackageInformationProvider diff --git a/desktop/source/deployment/manager/dp_manager.cxx b/desktop/source/deployment/manager/dp_manager.cxx index 0610d0e35bf4..c7a44295d34b 100644 --- a/desktop/source/deployment/manager/dp_manager.cxx +++ b/desktop/source/deployment/manager/dp_manager.cxx @@ -78,7 +78,7 @@ namespace dp_manager { struct MatchTempDir { OUString m_str; - MatchTempDir( OUString const & str ) : m_str( str ) {} + explicit MatchTempDir( OUString const & str ) : m_str( str ) {} bool operator () ( ActivePackages::Entries::value_type const & v ) const { return v.second.temporaryName.equalsIgnoreAsciiCase( m_str ); } diff --git a/desktop/source/deployment/manager/dp_managerfac.cxx b/desktop/source/deployment/manager/dp_managerfac.cxx index 49238f948209..06a5acd4227b 100644 --- a/desktop/source/deployment/manager/dp_managerfac.cxx +++ b/desktop/source/deployment/manager/dp_managerfac.cxx @@ -56,7 +56,7 @@ protected: public: virtual ~PackageManagerFactoryImpl(); - PackageManagerFactoryImpl( + explicit PackageManagerFactoryImpl( Reference const & xComponentContext ); // XPackageManagerFactory diff --git a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx index 292d0bfd724d..dab93e30f576 100644 --- a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx +++ b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx @@ -148,7 +148,7 @@ class FileDoesNotExistFilter public: virtual ~FileDoesNotExistFilter(); - FileDoesNotExistFilter( + explicit FileDoesNotExistFilter( const css::uno::Reference< css::ucb::XCommandEnvironment >& xCmdEnv); bool exist() { return m_bExist;} -- cgit