From 80f990b8e3d05e47e041685a7811f1352d03ad4d Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 4 Sep 2018 18:03:28 +0200 Subject: clang-tidy performance-inefficient-vector-operation Change-Id: Iebcaea7b08c5284946d83b6b6b9ed26b218025d4 Reviewed-on: https://gerrit.libreoffice.org/59992 Tested-by: Jenkins Reviewed-by: Noel Grandin --- desktop/source/app/cmdlineargs.cxx | 1 + desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) (limited to 'desktop') diff --git a/desktop/source/app/cmdlineargs.cxx b/desktop/source/app/cmdlineargs.cxx index a1377168abf8..0745116b07ac 100644 --- a/desktop/source/app/cmdlineargs.cxx +++ b/desktop/source/app/cmdlineargs.cxx @@ -63,6 +63,7 @@ std::vector< OUString > translateExternalUris( std::vector< OUString > const & input) { std::vector< OUString > t; + t.reserve(input.size()); for (auto const& elem : input) { t.push_back(translateExternalUris(elem)); diff --git a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx index 8ceaf58f3a31..c690ae401b2a 100644 --- a/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx +++ b/desktop/source/deployment/gui/dp_gui_extensioncmdqueue.cxx @@ -369,8 +369,8 @@ void ProgressCmdEnv::handle( uno::Reference< task::XInteractionRequest > const & else if (request >>= depExc) { std::vector< OUString > deps; - for (sal_Int32 i = 0; i < depExc.UnsatisfiedDependencies.getLength(); - ++i) + deps.reserve(depExc.UnsatisfiedDependencies.getLength()); + for (sal_Int32 i = 0; i < depExc.UnsatisfiedDependencies.getLength(); ++i) { deps.push_back( dp_misc::Dependencies::getErrorText( depExc.UnsatisfiedDependencies[i]) ); -- cgit