From b8eb2946511ce617323b13dffe2b1d9704e0be60 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Thu, 14 Apr 2016 10:20:52 +0200 Subject: loplugin:passstuffbyref in various Change-Id: I80070c83204e531c2f599f8a56193d6ffe0e5022 --- desktop/source/app/cmdlineargs.hxx | 14 +++++++------- desktop/source/deployment/gui/dp_gui_theextmgr.hxx | 4 ++-- .../source/deployment/gui/dp_gui_updateinstalldialog.hxx | 2 +- desktop/source/deployment/misc/dp_descriptioninfoset.cxx | 2 +- desktop/source/deployment/registry/inc/dp_backend.h | 2 +- desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx | 2 +- 6 files changed, 13 insertions(+), 13 deletions(-) (limited to 'desktop') diff --git a/desktop/source/app/cmdlineargs.hxx b/desktop/source/app/cmdlineargs.hxx index f110567b42e1..94648558ad94 100644 --- a/desktop/source/app/cmdlineargs.hxx +++ b/desktop/source/app/cmdlineargs.hxx @@ -55,7 +55,7 @@ class CommandLineArgs CommandLineArgs(const CommandLineArgs&) = delete; const CommandLineArgs& operator=(const CommandLineArgs&) = delete; - boost::optional< OUString > getCwdUrl() const { return m_cwdUrl; } + const boost::optional< OUString >& getCwdUrl() const { return m_cwdUrl; } // Access to bool parameters bool IsMinimized() const { return m_minimized;} @@ -93,7 +93,7 @@ class CommandLineArgs bool WantsToLoadDocument() const { return m_bDocumentArgs;} bool IsTextCat() const { return m_textcat;} - OUString GetUnknown() const { return m_unknown;} + const OUString& GetUnknown() const { return m_unknown;} // Access to string parameters bool HasSplashPipe() const { return m_splashpipe;} @@ -106,13 +106,13 @@ class CommandLineArgs std::vector< OUString > GetForceNewList() const; std::vector< OUString > GetPrintList() const; std::vector< OUString > GetPrintToList() const; - OUString GetPrinterName() const { return m_printername;} - OUString GetLanguage() const { return m_language;} + const OUString& GetPrinterName() const { return m_printername;} + const OUString& GetLanguage() const { return m_language;} std::vector< OUString > const & GetInFilter() const { return m_infilter;} std::vector< OUString > GetConversionList() const; - OUString GetConversionParams() const { return m_conversionparams;} - OUString GetConversionOut() const; - OUString GetPidfileName() const { return m_pidfile;} + const OUString& GetConversionParams() const { return m_conversionparams;} + OUString GetConversionOut() const; + const OUString& GetPidfileName() const { return m_pidfile;} // Special analyzed states (does not match directly to a command line parameter!) bool IsEmpty() const { return m_bEmpty;} diff --git a/desktop/source/deployment/gui/dp_gui_theextmgr.hxx b/desktop/source/deployment/gui/dp_gui_theextmgr.hxx index 263fe20cab57..756c0e9303fa 100644 --- a/desktop/source/deployment/gui/dp_gui_theextmgr.hxx +++ b/desktop/source/deployment/gui/dp_gui_theextmgr.hxx @@ -100,8 +100,8 @@ public: // Tools bool supportsOptions( const css::uno::Reference< css::deployment::XPackage > &xPackage ) const; static PackageState getPackageState( const css::uno::Reference< css::deployment::XPackage > &xPackage ); - css::uno::Reference< css::uno::XComponentContext > getContext() const { return m_xContext; } - css::uno::Reference< css::deployment::XExtensionManager > getExtensionManager() const { return m_xExtensionManager; } + const css::uno::Reference< css::uno::XComponentContext >& getContext() const { return m_xContext; } + const css::uno::Reference< css::deployment::XExtensionManager >& getExtensionManager() const { return m_xExtensionManager; } bool isReadOnly( const css::uno::Reference< css::deployment::XPackage > &xPackage ) const; diff --git a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx index 026693eb2c9c..040a9f790863 100644 --- a/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx +++ b/desktop/source/deployment/gui/dp_gui_updateinstalldialog.hxx @@ -86,7 +86,7 @@ private: }; void setError(INSTALL_ERROR err, OUString const & sExtension, OUString const & exceptionMessage); void setError(OUString const & exceptionMessage); - css::uno::Reference< css::deployment::XExtensionManager > getExtensionManager() const + const css::uno::Reference< css::deployment::XExtensionManager >& getExtensionManager() const { return m_xExtensionManager; } rtl::Reference< Thread > m_thread; diff --git a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx index 1e0563378b20..bfb2fd68e7da 100644 --- a/desktop/source/deployment/misc/dp_descriptioninfoset.cxx +++ b/desktop/source/deployment/misc/dp_descriptioninfoset.cxx @@ -124,7 +124,7 @@ public: ~ExtensionDescription(); - css::uno::Reference getRootElement() const + const css::uno::Reference& getRootElement() const { return m_xRoot; } diff --git a/desktop/source/deployment/registry/inc/dp_backend.h b/desktop/source/deployment/registry/inc/dp_backend.h index d5c29eade70d..cb7b8fcbe026 100644 --- a/desktop/source/deployment/registry/inc/dp_backend.h +++ b/desktop/source/deployment/registry/inc/dp_backend.h @@ -346,7 +346,7 @@ public: inline OUString const & getCachePath() const { return m_cachePath; } inline bool transientMode() const { return m_cachePath.isEmpty(); } - inline OUString getContext() const {return m_context; } + const OUString& getContext() const {return m_context; } // XEventListener virtual void SAL_CALL disposing( css::lang::EventObject const & evt ) diff --git a/desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx b/desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx index 0c7459d42d0b..d637116fefae 100644 --- a/desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx +++ b/desktop/source/deployment/registry/sfwk/dp_parceldesc.hxx @@ -45,7 +45,7 @@ private: sal_Int32 skipIndex; public: ParcelDescDocHandler():m_bIsParsed( false ), skipIndex( 0 ){} - OUString getParcelLanguage() { return m_sLang; } + const OUString& getParcelLanguage() { return m_sLang; } bool isParsed() { return m_bIsParsed; } // XDocumentHandler virtual void SAL_CALL startDocument() -- cgit