From dac4ca5f682fdd0c3eee7f7ee1d98c9b3c8b7ce4 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 25 Jun 2014 14:57:44 +0200 Subject: new loplugin: externalandnotdefined Find "missing headers," where a function is declared directly in the .cxx (as extern) and not defined, and should arguably instead be declared in an include file. Change-Id: I6d83ee432b2ab0cd050aec2b27c3658d32ac02a2 --- desktop/inc/app.hxx | 2 ++ desktop/source/app/cmdlinehelp.cxx | 2 -- desktop/source/app/sofficemain.cxx | 3 +-- 3 files changed, 3 insertions(+), 4 deletions(-) (limited to 'desktop') diff --git a/desktop/inc/app.hxx b/desktop/inc/app.hxx index 02a94b9c2b2b..b067ae6101b3 100644 --- a/desktop/inc/app.hxx +++ b/desktop/inc/app.hxx @@ -192,6 +192,8 @@ class Desktop : public Application OUString GetURL_Impl( const OUString& rName, boost::optional< OUString > const & cwdUrl ); +OUString ReplaceStringHookProc(const OUString& rStr); + } #endif // INCLUDED_DESKTOP_INC_APP_HXX diff --git a/desktop/source/app/cmdlinehelp.cxx b/desktop/source/app/cmdlinehelp.cxx index a956038c06f4..f042b46ab721 100644 --- a/desktop/source/app/cmdlinehelp.cxx +++ b/desktop/source/app/cmdlinehelp.cxx @@ -132,8 +132,6 @@ namespace desktop " Eg. -env:UserInstallation=file:///tmp/test to set a non-default user profile path.\n"\ "\nRemaining arguments will be treated as filenames or URLs of documents to open.\n\n"; - OUString ReplaceStringHookProc(const OUString& rStr); - void displayCmdlineHelp(OUString const & unknown) { // if you put variables in other chunks don't forget to call the replace routines diff --git a/desktop/source/app/sofficemain.cxx b/desktop/source/app/sofficemain.cxx index a7072cba50f7..baf6a1be1da1 100644 --- a/desktop/source/app/sofficemain.cxx +++ b/desktop/source/app/sofficemain.cxx @@ -28,6 +28,7 @@ #include #include +#include #ifdef ANDROID @@ -43,8 +44,6 @@ #include #endif -int SVMain(); - extern "C" int DESKTOP_DLLPUBLIC soffice_main() { #if defined ANDROID -- cgit