From 3d604d1cd6cc70ef96782ef769f0479b509987a8 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Wed, 5 Sep 2018 13:51:39 +0200 Subject: clang-tidy performance-move-const-arg Change-Id: I607891e120688b746c8a4c577018d97147a79217 Reviewed-on: https://gerrit.libreoffice.org/60029 Tested-by: Jenkins Reviewed-by: Noel Grandin --- editeng/source/editeng/eertfpar.cxx | 16 ++++++++-------- editeng/source/items/frmitems.cxx | 22 +++++++++++----------- editeng/source/uno/unotext.cxx | 2 +- 3 files changed, 20 insertions(+), 20 deletions(-) (limited to 'editeng') diff --git a/editeng/source/editeng/eertfpar.cxx b/editeng/source/editeng/eertfpar.cxx index ccecfa5723de..16f202d24a28 100644 --- a/editeng/source/editeng/eertfpar.cxx +++ b/editeng/source/editeng/eertfpar.cxx @@ -62,14 +62,14 @@ RtfImportInfo::~RtfImportInfo() { } -EditRTFParser::EditRTFParser( - SvStream& rIn, EditSelection aSel, SfxItemPool& rAttrPool, EditEngine* pEditEngine) : - SvxRTFParser(rAttrPool, rIn), - aCurSel(std::move(aSel)), - mpEditEngine(pEditEngine), - aRTFMapMode(MapUnit::MapTwip), - nDefFont(0), - bLastActionInsertParaBreak(false) +EditRTFParser::EditRTFParser(SvStream& rIn, EditSelection aSel, SfxItemPool& rAttrPool, + EditEngine* pEditEngine) + : SvxRTFParser(rAttrPool, rIn) + , aCurSel(aSel) + , mpEditEngine(pEditEngine) + , aRTFMapMode(MapUnit::MapTwip) + , nDefFont(0) + , bLastActionInsertParaBreak(false) { SetInsPos(EditPosition(mpEditEngine, &aCurSel)); diff --git a/editeng/source/items/frmitems.cxx b/editeng/source/items/frmitems.cxx index e690d36ffb85..2c40069d5d47 100644 --- a/editeng/source/items/frmitems.cxx +++ b/editeng/source/items/frmitems.cxx @@ -3241,15 +3241,15 @@ SvxBrushItem::SvxBrushItem(const SvxBrushItem& rItem) } SvxBrushItem::SvxBrushItem(SvxBrushItem&& rItem) - : SfxPoolItem(std::move(rItem)) - , aColor(std::move(rItem.aColor)) - , nShadingValue(std::move(rItem.nShadingValue)) + : SfxPoolItem(rItem) + , aColor(rItem.aColor) + , nShadingValue(rItem.nShadingValue) , xGraphicObject(std::move(rItem.xGraphicObject)) - , nGraphicTransparency(std::move(rItem.nGraphicTransparency)) + , nGraphicTransparency(rItem.nGraphicTransparency) , maStrLink(std::move(rItem.maStrLink)) , maStrFilter(std::move(rItem.maStrFilter)) - , eGraphicPos(std::move(rItem.eGraphicPos)) - , bLoadAgain(std::move(rItem.bLoadAgain)) + , eGraphicPos(rItem.eGraphicPos) + , bLoadAgain(rItem.bLoadAgain) { } @@ -3519,14 +3519,14 @@ SvxBrushItem& SvxBrushItem::operator=(const SvxBrushItem& rItem) SvxBrushItem& SvxBrushItem::operator=(SvxBrushItem&& rItem) { - aColor = std::move(rItem.aColor); - nShadingValue = std::move(rItem.nShadingValue); + aColor = rItem.aColor; + nShadingValue = rItem.nShadingValue; xGraphicObject = std::move(rItem.xGraphicObject); - nGraphicTransparency = std::move(rItem.nGraphicTransparency); + nGraphicTransparency = rItem.nGraphicTransparency; maStrLink = std::move(rItem.maStrLink); maStrFilter = std::move(rItem.maStrFilter); - eGraphicPos = std::move(rItem.eGraphicPos); - bLoadAgain = std::move(rItem.bLoadAgain); + eGraphicPos = rItem.eGraphicPos; + bLoadAgain = rItem.bLoadAgain; return *this; } diff --git a/editeng/source/uno/unotext.cxx b/editeng/source/uno/unotext.cxx index 22699090a93c..4e52a5099a9f 100644 --- a/editeng/source/uno/unotext.cxx +++ b/editeng/source/uno/unotext.cxx @@ -287,7 +287,7 @@ void SvxUnoTextRangeBase::attachField( std::unique_ptr pData ) thr if( pForwarder ) { SvxFieldItem aField( std::move(pData), EE_FEATURE_FIELD ); - pForwarder->QuickInsertField( std::move(aField), maSelection ); + pForwarder->QuickInsertField(aField, maSelection); } } -- cgit