From 5cf725b626428b09072e6a3464765c3069f1e43f Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Mon, 11 Apr 2016 11:20:44 +0200 Subject: clang-tidy performance-unnecessary-value-param in editeng Change-Id: Idfebcc36c756023e491baf2c4259bd580785dd44 --- editeng/source/editeng/editeng.cxx | 4 ++-- editeng/source/editeng/editview.cxx | 4 ++-- editeng/source/editeng/impedit.hxx | 14 +++++++------- editeng/source/editeng/impedit2.cxx | 2 +- editeng/source/editeng/impedit4.cxx | 10 +++++----- editeng/source/outliner/outlin2.cxx | 4 ++-- 6 files changed, 19 insertions(+), 19 deletions(-) (limited to 'editeng') diff --git a/editeng/source/editeng/editeng.cxx b/editeng/source/editeng/editeng.cxx index 09e4b2d7dae8..485f2f7472ce 100644 --- a/editeng/source/editeng/editeng.cxx +++ b/editeng/source/editeng/editeng.cxx @@ -2136,7 +2136,7 @@ void EditEngine::SetAllMisspellRanges( const std::vectorSetAllMisspellRanges(rRanges); } -void EditEngine::SetForbiddenCharsTable( rtl::Reference xForbiddenChars ) +void EditEngine::SetForbiddenCharsTable( const rtl::Reference& xForbiddenChars ) { ImpEditEngine::SetForbiddenCharsTable( xForbiddenChars ); } @@ -2281,7 +2281,7 @@ bool EditEngine::UpdateFieldsOnly() return pImpEditEngine->UpdateFields(); } -void EditEngine::RemoveFields( std::function isFieldData ) +void EditEngine::RemoveFields( const std::function& isFieldData ) { pImpEditEngine->UpdateFields(); diff --git a/editeng/source/editeng/editview.cxx b/editeng/source/editeng/editview.cxx index 8c89c96cccb9..a3ed225779f8 100644 --- a/editeng/source/editeng/editview.cxx +++ b/editeng/source/editeng/editview.cxx @@ -75,8 +75,8 @@ using namespace com::sun::star::beans; // static LanguageType EditView::CheckLanguage( const OUString &rText, - Reference< linguistic2::XSpellChecker1 > xSpell, - Reference< linguistic2::XLanguageGuessing > xLangGuess, + const Reference< linguistic2::XSpellChecker1 >& xSpell, + const Reference< linguistic2::XLanguageGuessing >& xLangGuess, bool bIsParaText ) { LanguageType nLang = LANGUAGE_NONE; diff --git a/editeng/source/editeng/impedit.hxx b/editeng/source/editeng/impedit.hxx index 7ab03f84e03a..fa70b1e61bb7 100644 --- a/editeng/source/editeng/impedit.hxx +++ b/editeng/source/editeng/impedit.hxx @@ -952,14 +952,14 @@ public: void AddPortionIterated( EditView& rEditView, const EditSelection &rSel, - css::uno::Reference< css::linguistic2::XSpellAlternatives > xAlt, + const css::uno::Reference< css::linguistic2::XSpellAlternatives >& xAlt, svx::SpellPortions& rToFill); //adds one portion to the SpellPortions - void AddPortion( - const EditSelection &rSel, - css::uno::Reference< css::linguistic2::XSpellAlternatives > xAlt, - svx::SpellPortions& rToFill, - bool bIsField ); + void AddPortion( + const EditSelection &rSel, + const css::uno::Reference< css::linguistic2::XSpellAlternatives >& xAlt, + svx::SpellPortions& rToFill, + bool bIsField ); bool Search( const SvxSearchItem& rSearchItem, EditView* pView ); bool ImpSearch( const SvxSearchItem& rSearchItem, const EditSelection& rSearchSelection, const EditPaM& rStartPos, EditSelection& rFoundSel ); @@ -1008,7 +1008,7 @@ public: bool IsAddExtLeading() const { return bAddExtLeading; } rtl::Reference GetForbiddenCharsTable() const; - static void SetForbiddenCharsTable( rtl::Reference xForbiddenChars ); + static void SetForbiddenCharsTable( const rtl::Reference& xForbiddenChars ); /** sets a link that is called at the beginning of a drag operation at an edit view */ void SetBeginDropHdl( const Link& rLink ) { maBeginDropHdl = rLink; } diff --git a/editeng/source/editeng/impedit2.cxx b/editeng/source/editeng/impedit2.cxx index ce82d719d5bf..b934c3038561 100644 --- a/editeng/source/editeng/impedit2.cxx +++ b/editeng/source/editeng/impedit2.cxx @@ -4280,7 +4280,7 @@ rtl::Reference ImpEditEngine::GetForbiddenCharsTabl return xF; } -void ImpEditEngine::SetForbiddenCharsTable( rtl::Reference xForbiddenChars ) +void ImpEditEngine::SetForbiddenCharsTable( const rtl::Reference& xForbiddenChars ) { EE_DLL().GetGlobalData()->SetForbiddenCharsTable( xForbiddenChars ); } diff --git a/editeng/source/editeng/impedit4.cxx b/editeng/source/editeng/impedit4.cxx index bbce370ad091..64960f1396cb 100644 --- a/editeng/source/editeng/impedit4.cxx +++ b/editeng/source/editeng/impedit4.cxx @@ -2018,9 +2018,9 @@ bool ImpEditEngine::SpellSentence(EditView& rEditView, // Adds one portion to the SpellPortions void ImpEditEngine::AddPortion( const EditSelection& rSel, - uno::Reference< XSpellAlternatives > xAlt, - svx::SpellPortions& rToFill, - bool bIsField) + const uno::Reference< XSpellAlternatives >& xAlt, + svx::SpellPortions& rToFill, + bool bIsField) { if(rSel.HasRange()) { @@ -2042,8 +2042,8 @@ void ImpEditEngine::AddPortion( void ImpEditEngine::AddPortionIterated( EditView& rEditView, const EditSelection& rSel, - Reference< XSpellAlternatives > xAlt, - svx::SpellPortions& rToFill) + const Reference< XSpellAlternatives >& xAlt, + svx::SpellPortions& rToFill) { if (rSel.HasRange()) { diff --git a/editeng/source/outliner/outlin2.cxx b/editeng/source/outliner/outlin2.cxx index 7126a918a867..927b947b3d2a 100644 --- a/editeng/source/outliner/outlin2.cxx +++ b/editeng/source/outliner/outlin2.cxx @@ -153,7 +153,7 @@ bool Outliner::UpdateFields() return pEditEngine->UpdateFields(); } -void Outliner::RemoveFields( std::function isFieldData ) +void Outliner::RemoveFields( const std::function& isFieldData ) { pEditEngine->RemoveFields( isFieldData ); } @@ -398,7 +398,7 @@ Reference< XSpellChecker1 > Outliner::GetSpeller() return pEditEngine->GetSpeller(); } -void Outliner::SetForbiddenCharsTable( rtl::Reference xForbiddenChars ) +void Outliner::SetForbiddenCharsTable( const rtl::Reference& xForbiddenChars ) { EditEngine::SetForbiddenCharsTable( xForbiddenChars ); } -- cgit