From 5fad6eb1b38d369f4f7ca401f3c651292667486e Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Fri, 21 Jul 2017 12:31:18 +0200 Subject: loplugin:unusedfields in editeng Change-Id: I61ddd2ce8ded65251fdf1903e6cb67f0d18c9451 Reviewed-on: https://gerrit.libreoffice.org/40293 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- editeng/source/outliner/outleeng.cxx | 6 ------ editeng/source/outliner/outleeng.hxx | 1 - editeng/source/outliner/outliner.cxx | 11 ----------- editeng/source/rtf/svxrtf.cxx | 6 +----- editeng/source/uno/unoforou.cxx | 3 +-- 5 files changed, 2 insertions(+), 25 deletions(-) (limited to 'editeng') diff --git a/editeng/source/outliner/outleeng.cxx b/editeng/source/outliner/outleeng.cxx index 185bef339690..97b63edf9f3f 100644 --- a/editeng/source/outliner/outleeng.cxx +++ b/editeng/source/outliner/outleeng.cxx @@ -169,12 +169,6 @@ void OutlinerEditEng::DrawingTab( const Point& rStartPos, long nWidth, const OUS bEndOfLine, bEndOfParagraph, rOverlineColor, rTextLineColor ); } -void OutlinerEditEng::FieldClicked( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos ) -{ - EditEngine::FieldClicked( rField, nPara, nPos ); // If URL - pOwner->FieldClicked( rField, nPara, nPos ); -} - OUString OutlinerEditEng::CalcFieldValue( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos, Color*& rpTxtColor, Color*& rpFldColor ) { return pOwner->CalcFieldValue( rField, nPara, nPos, rpTxtColor, rpFldColor ); diff --git a/editeng/source/outliner/outleeng.hxx b/editeng/source/outliner/outleeng.hxx index 093ef2991c8e..2b45610c16d3 100644 --- a/editeng/source/outliner/outleeng.hxx +++ b/editeng/source/outliner/outleeng.hxx @@ -71,7 +71,6 @@ public: // for text conversion virtual bool ConvertNextDocument() override; - virtual void FieldClicked( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos ) override; virtual OUString CalcFieldValue( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos, Color*& rTxtColor, Color*& rFldColor ) override; virtual tools::Rectangle GetBulletArea( sal_Int32 nPara ) override; diff --git a/editeng/source/outliner/outliner.cxx b/editeng/source/outliner/outliner.cxx index a1fc3a229b6b..f89d5895a89f 100644 --- a/editeng/source/outliner/outliner.cxx +++ b/editeng/source/outliner/outliner.cxx @@ -632,17 +632,6 @@ void Outliner::AddText( const OutlinerParaObject& rPObj ) pEditEngine->SetUpdateMode( bUpdate ); } -void Outliner::FieldClicked( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos ) -{ - - if ( aFieldClickedHdl.IsSet() ) - { - EditFieldInfo aFldInfo( this, rField, nPara, nPos ); - aFieldClickedHdl.Call( &aFldInfo ); - } -} - - OUString Outliner::CalcFieldValue( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos, Color*& rpTxtColor, Color*& rpFldColor ) { if ( !aCalcFieldValueHdl.IsSet() ) diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx index c93841466570..419482a91903 100644 --- a/editeng/source/rtf/svxrtf.cxx +++ b/editeng/source/rtf/svxrtf.cxx @@ -72,7 +72,6 @@ SvxRTFParser::SvxRTFParser( SfxItemPool& rPool, SvStream& rIn, , bIsSetDfltTab( false) , bChkStyleAttr( false ) , bCalcValue( false ) - , bReadDocInfo( false ) , bIsLeftToRightDef( true) , bIsInReadStyleTab( false) { @@ -214,10 +213,7 @@ INSINGLECHAR: bNewGroup = false; break; case RTF_INFO: - if (bReadDocInfo && bNewDoc && m_xDocProps.is()) - ReadInfo(); - else - SkipGroup(); + SkipGroup(); break; // !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! diff --git a/editeng/source/uno/unoforou.cxx b/editeng/source/uno/unoforou.cxx index 050f3c8c85b1..e5f6275c13b3 100644 --- a/editeng/source/uno/unoforou.cxx +++ b/editeng/source/uno/unoforou.cxx @@ -228,9 +228,8 @@ OUString SvxOutlinerForwarder::CalcFieldValue( const SvxFieldItem& rField, sal_I return rOutliner.CalcFieldValue( rField, nPara, nPos, rpTxtColor, rpFldColor ); } -void SvxOutlinerForwarder::FieldClicked( const SvxFieldItem& rField, sal_Int32 nPara, sal_Int32 nPos ) +void SvxOutlinerForwarder::FieldClicked( const SvxFieldItem& /*rField*/, sal_Int32 /*nPara*/, sal_Int32 /*nPos*/ ) { - rOutliner.FieldClicked( rField, nPara, nPos ); } bool SvxOutlinerForwarder::IsValid() const -- cgit