From 62633dfe026bc3badf7066e5fb454036bae9cfdc Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 12 Apr 2016 12:08:00 +0200 Subject: clang-tidy performance-unnecessary-value-param in various Change-Id: I7168d44dab8e6a8e37bb7920d744ff32f5e52907 Reviewed-on: https://gerrit.libreoffice.org/24019 Tested-by: Jenkins Reviewed-by: Noel Grandin --- embeddedobj/source/inc/oleembobj.hxx | 2 +- embeddedobj/source/msole/oleembed.cxx | 6 +++--- embeddedobj/source/msole/olevisual.cxx | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'embeddedobj') diff --git a/embeddedobj/source/inc/oleembobj.hxx b/embeddedobj/source/inc/oleembobj.hxx index f5dca11e67ab..84680366b5db 100644 --- a/embeddedobj/source/inc/oleembobj.hxx +++ b/embeddedobj/source/inc/oleembobj.hxx @@ -254,7 +254,7 @@ protected: bool HasVisReplInStream(); css::embed::VisualRepresentation GetVisualRepresentationInNativeFormat_Impl( - const css::uno::Reference< css::io::XStream > xCachedVisRepr ) + const css::uno::Reference< css::io::XStream >& xCachedVisRepr ) throw ( css::uno::Exception ); css::uno::Reference< css::io::XStream > TryToRetrieveCachedVisualRepresentation_Impl( diff --git a/embeddedobj/source/msole/oleembed.cxx b/embeddedobj/source/msole/oleembed.cxx index 473df8956c2b..6d42cabcebdd 100644 --- a/embeddedobj/source/msole/oleembed.cxx +++ b/embeddedobj/source/msole/oleembed.cxx @@ -664,7 +664,7 @@ sal_Int32 SAL_CALL OleEmbeddedObject::getCurrentState() namespace { #ifndef _WIN32 - bool lcl_CopyStream(uno::Reference xIn, uno::Reference xOut) + bool lcl_CopyStream(const uno::Reference& xIn, const uno::Reference& xOut) { const sal_Int32 nChunkSize = 4096; uno::Sequence< sal_Int8 > aData(nChunkSize); @@ -683,8 +683,8 @@ namespace //Dump the objects content to a tempfile, just the "CONTENTS" stream if //there is one for non-compound documents, otherwise the whole content. //On success a file is returned which must be removed by the caller - OUString lcl_ExtractObject(css::uno::Reference< css::lang::XMultiServiceFactory > xFactory, - css::uno::Reference< css::io::XStream > xObjectStream) + OUString lcl_ExtractObject(const css::uno::Reference< css::lang::XMultiServiceFactory >& xFactory, + const css::uno::Reference< css::io::XStream >& xObjectStream) { OUString sUrl; diff --git a/embeddedobj/source/msole/olevisual.cxx b/embeddedobj/source/msole/olevisual.cxx index d53ef5fea033..0445c09a94dc 100644 --- a/embeddedobj/source/msole/olevisual.cxx +++ b/embeddedobj/source/msole/olevisual.cxx @@ -38,7 +38,7 @@ using namespace ::com::sun::star; using namespace ::comphelper; embed::VisualRepresentation OleEmbeddedObject::GetVisualRepresentationInNativeFormat_Impl( - const uno::Reference< io::XStream > xCachedVisRepr ) + const uno::Reference< io::XStream >& xCachedVisRepr ) throw ( uno::Exception ) { embed::VisualRepresentation aVisualRepr; -- cgit