From 7ceee0f1ec0e349d0df4980d7fdedbd13c7917c5 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Tue, 9 Oct 2018 10:28:48 +0200 Subject: Extend loplugin:redundantinline to catch inline functions w/o external linkage ...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- extensions/source/logging/csvformatter.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'extensions/source/logging') diff --git a/extensions/source/logging/csvformatter.cxx b/extensions/source/logging/csvformatter.cxx index 2e98243864a0..12ebce788433 100644 --- a/extensions/source/logging/csvformatter.cxx +++ b/extensions/source/logging/csvformatter.cxx @@ -89,7 +89,7 @@ namespace const sal_Unicode comma_char = ','; const OUString dos_newline = "\r\n"; - inline bool needsQuoting(const OUString& str) + bool needsQuoting(const OUString& str) { static const OUString quote_trigger_chars = "\",\n\r"; sal_Int32 len = str.getLength(); @@ -99,7 +99,7 @@ namespace return false; }; - inline void appendEncodedString(OUStringBuffer& buf, const OUString& str) + void appendEncodedString(OUStringBuffer& buf, const OUString& str) { if(needsQuoting(str)) { -- cgit