From 556373c41fddbac6cbee1c89e7707631270a1852 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Wed, 11 Mar 2015 09:06:08 +0000 Subject: V668 no sense in testing the result of new against null Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39 --- extensions/source/plugin/win/winmgr.cxx | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'extensions/source/plugin') diff --git a/extensions/source/plugin/win/winmgr.cxx b/extensions/source/plugin/win/winmgr.cxx index 881ec270b0e3..b84315e1873f 100644 --- a/extensions/source/plugin/win/winmgr.cxx +++ b/extensions/source/plugin/win/winmgr.cxx @@ -332,7 +332,7 @@ Sequence< PluginDescription > XPluginManager_Impl::impl_getPluginDescriptions() continue; char * pVersionData = new char[dwSize]; - if (pVersionData && ::GetFileVersionInfo( arFileName, 0, dwSize, pVersionData )) + if (::GetFileVersionInfo( arFileName, 0, dwSize, pVersionData)) { // optional comment OUString aComment; @@ -433,8 +433,7 @@ Sequence< PluginDescription > XPluginManager_Impl::impl_getPluginDescriptions() OSL_FAIL( "### cannot get MIME type or extensions!" ); #endif } - if (pVersionData) - delete[] pVersionData; + delete[] pVersionData; } s_bInit = TRUE; -- cgit