From 3a0c5b782001fc398740b46f2adc9e07055505d6 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Fri, 24 Mar 2023 19:12:58 +0200
Subject: loplugin:stringadd in editeng..framework

after my patch to merge the bufferadd loplugin into stringadd

Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 extensions/source/logging/csvformatter.cxx           | 9 +++------
 extensions/source/logging/plaintextformatter.cxx     | 9 +++------
 extensions/source/propctrlr/eventhandler.cxx         | 6 ++----
 extensions/source/propctrlr/formcomponenthandler.cxx | 9 +++------
 extensions/source/propctrlr/standardcontrol.cxx      | 4 +---
 extensions/source/propctrlr/stringrepresentation.cxx | 3 +--
 6 files changed, 13 insertions(+), 27 deletions(-)

(limited to 'extensions')

diff --git a/extensions/source/logging/csvformatter.cxx b/extensions/source/logging/csvformatter.cxx
index ddbf3a9a2c36..c495bbe1ea95 100644
--- a/extensions/source/logging/csvformatter.cxx
+++ b/extensions/source/logging/csvformatter.cxx
@@ -202,8 +202,7 @@ namespace logging
         sal_Int32 columns = m_Columnnames.getLength();
         for(sal_Int32 i=0; i<columns; i++)
         {
-            buf.append(m_Columnnames[i]);
-            buf.append(comma_char);
+            buf.append(m_Columnnames[i] + OUStringChar(comma_char));
         }
         buf.setLength(buf.getLength()-1);
         buf.append(dos_newline);
@@ -216,14 +215,12 @@ namespace logging
 
         if(m_LogEventNo)
         {
-            aLogEntry.append( record.SequenceNumber );
-            aLogEntry.append(comma_char);
+            aLogEntry.append(record.SequenceNumber + comma_char);
         }
 
         if(m_LogThread)
         {
-            aLogEntry.append( record.ThreadID );
-            aLogEntry.append(comma_char);
+            aLogEntry.append(record.ThreadID + OUStringChar(comma_char));
         }
 
         if(m_LogTimestamp)
diff --git a/extensions/source/logging/plaintextformatter.cxx b/extensions/source/logging/plaintextformatter.cxx
index 23392b61c491..2c534a2a2e8f 100644
--- a/extensions/source/logging/plaintextformatter.cxx
+++ b/extensions/source/logging/plaintextformatter.cxx
@@ -105,14 +105,11 @@ namespace logging
 
         if ( !(_rRecord.SourceClassName.isEmpty() || _rRecord.SourceMethodName.isEmpty()) )
         {
-            aLogEntry.append( _rRecord.SourceClassName );
-            aLogEntry.append( "::" );
-            aLogEntry.append( _rRecord.SourceMethodName );
-            aLogEntry.append( ": " );
+            aLogEntry.append( _rRecord.SourceClassName + "::"
+                + _rRecord.SourceMethodName + ": " );
         }
 
-        aLogEntry.append( _rRecord.Message );
-        aLogEntry.append( "\n" );
+        aLogEntry.append( _rRecord.Message + "\n" );
 
         return aLogEntry.makeStringAndClear();
     }
diff --git a/extensions/source/propctrlr/eventhandler.cxx b/extensions/source/propctrlr/eventhandler.cxx
index ea99755244af..136dcb35dac3 100644
--- a/extensions/source/propctrlr/eventhandler.cxx
+++ b/extensions/source/propctrlr/eventhandler.cxx
@@ -131,8 +131,7 @@ namespace pcr
         ,sUniqueBrowseId(std::move( _sUniqueBrowseId ))
         ,nId( _nId )
     {
-        OUStringBuffer aQualifiedListenerClass;
-        aQualifiedListenerClass.append( "com.sun.star." );
+        OUStringBuffer aQualifiedListenerClass( "com.sun.star." );
         aQualifiedListenerClass.appendAscii( _pListenerNamespaceAscii );
         aQualifiedListenerClass.append( "." );
         aQualifiedListenerClass.appendAscii( _pListenerClassAsciiName );
@@ -608,8 +607,7 @@ namespace pcr
                     OSL_ENSURE( !sLocation.isEmpty(), "EventHandler::convertToControlValue: unexpected: no location!" );
                     if ( !sLocation.isEmpty() )
                     {
-                        aComposeBuffer.append( sLocation );
-                        aComposeBuffer.append( ", " );
+                        aComposeBuffer.append( sLocation + ", " );
                     }
 
                     // language
diff --git a/extensions/source/propctrlr/formcomponenthandler.cxx b/extensions/source/propctrlr/formcomponenthandler.cxx
index 81f90518d2c5..9385d0bdc5af 100644
--- a/extensions/source/propctrlr/formcomponenthandler.cxx
+++ b/extensions/source/propctrlr/formcomponenthandler.cxx
@@ -739,8 +739,7 @@ namespace pcr
             else
             {
                 // font name
-                displayName.append( aFont.Name );
-                displayName.append( ", " );
+                displayName.append( aFont.Name + ", " );
 
                 // font style
                 ::FontWeight  eWeight = vcl::unohelper::ConvertFontWeight( aFont.Weight );
@@ -762,8 +761,7 @@ namespace pcr
                 // font size
                 if ( aFont.Height )
                 {
-                    displayName.append( ", " );
-                    displayName.append( sal_Int32( aFont.Height ) );
+                    displayName.append( ", " + OUString::number( sal_Int32( aFont.Height ) ) );
                 }
             }
 
@@ -2526,8 +2524,7 @@ namespace pcr
             OUStringBuffer sTemp;
             if ( bAdd )
             {
-                sTemp.append(_sName);
-                sTemp.append("/");
+                sTemp.append(OUString::Concat(_sName) + "/");
             }
             sTemp.append(rQueryName);
             Reference< XNameAccess > xSubQueries(_xQueryNames->getByName(rQueryName),UNO_QUERY);
diff --git a/extensions/source/propctrlr/standardcontrol.cxx b/extensions/source/propctrlr/standardcontrol.cxx
index 95b4143c76b8..9468ecc56745 100644
--- a/extensions/source/propctrlr/standardcontrol.cxx
+++ b/extensions/source/propctrlr/standardcontrol.cxx
@@ -724,9 +724,7 @@ namespace pcr
             {
                 if ( strings != _rStrings.begin() )
                     aComposed.append( ';' );
-                aComposed.append( '\"' );
-                aComposed.append( *strings );
-                aComposed.append( '\"' );
+                aComposed.append( "\"" + *strings + "\"" );
             }
             return aComposed.makeStringAndClear();
         }
diff --git a/extensions/source/propctrlr/stringrepresentation.cxx b/extensions/source/propctrlr/stringrepresentation.cxx
index 30dbde907733..6f40c09c9d84 100644
--- a/extensions/source/propctrlr/stringrepresentation.cxx
+++ b/extensions/source/propctrlr/stringrepresentation.cxx
@@ -329,8 +329,7 @@ namespace
         // (separated by a line break)
         for (const auto& rElement : _rElements)
         {
-            sCompose.append(OUString(_rTransformer(rElement)));
-            sCompose.append("\n");
+            sCompose.append(OUString(_rTransformer(rElement)) + "\n");
         }
         sCompose.stripEnd('\n');
 
-- 
cgit