From 4630157e29f565c110f4fa11223a2d2358508c26 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Thu, 18 Aug 2016 12:27:49 +0100 Subject: cppcheck: passedByValue Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc --- extensions/source/propctrlr/browserlistbox.hxx | 2 +- extensions/source/resource/ResourceIndexAccess.cxx | 6 +++--- extensions/source/scanner/scanunx.cxx | 7 +++---- 3 files changed, 7 insertions(+), 8 deletions(-) (limited to 'extensions') diff --git a/extensions/source/propctrlr/browserlistbox.hxx b/extensions/source/propctrlr/browserlistbox.hxx index 284119c97c3f..9ba18cdde797 100644 --- a/extensions/source/propctrlr/browserlistbox.hxx +++ b/extensions/source/propctrlr/browserlistbox.hxx @@ -59,7 +59,7 @@ namespace pcr css::uno::Reference< css::inspection::XPropertyHandler > xHandler; - ListBoxLine( const OUString& rName, BrowserLinePointer _pLine, const css::uno::Reference< css::inspection::XPropertyHandler >& _rxHandler ) + ListBoxLine( const OUString& rName, const BrowserLinePointer& _pLine, const css::uno::Reference< css::inspection::XPropertyHandler >& _rxHandler ) : aName( rName ), pLine( _pLine ), xHandler( _rxHandler ) diff --git a/extensions/source/resource/ResourceIndexAccess.cxx b/extensions/source/resource/ResourceIndexAccess.cxx index 5141b209834b..f8a35b859388 100644 --- a/extensions/source/resource/ResourceIndexAccess.cxx +++ b/extensions/source/resource/ResourceIndexAccess.cxx @@ -40,7 +40,7 @@ namespace class ResourceIndexAccessBase : public cppu::WeakImplHelper< css::container::XIndexAccess> { public: - explicit ResourceIndexAccessBase( std::shared_ptr pResMgr) + explicit ResourceIndexAccessBase(const std::shared_ptr& pResMgr) : m_pResMgr(pResMgr) { OSL_ENSURE(m_pResMgr, "no resource manager given"); @@ -61,7 +61,7 @@ namespace class ResourceStringIndexAccess : public ResourceIndexAccessBase { public: - explicit ResourceStringIndexAccess( std::shared_ptr pResMgr) + explicit ResourceStringIndexAccess(const std::shared_ptr& pResMgr) : ResourceIndexAccessBase(pResMgr) {} // XIndexAccess virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override; @@ -73,7 +73,7 @@ namespace class ResourceStringListIndexAccess : public ResourceIndexAccessBase { public: - explicit ResourceStringListIndexAccess( std::shared_ptr pResMgr) + explicit ResourceStringListIndexAccess(const std::shared_ptr& pResMgr) : ResourceIndexAccessBase(pResMgr) {} // XIndexAccess virtual css::uno::Any SAL_CALL getByIndex( ::sal_Int32 Index ) throw (css::lang::IndexOutOfBoundsException, css::lang::WrappedTargetException, css::uno::RuntimeException, std::exception) override; diff --git a/extensions/source/scanner/scanunx.cxx b/extensions/source/scanner/scanunx.cxx index 268ab107e91f..a57f52961673 100644 --- a/extensions/source/scanner/scanunx.cxx +++ b/extensions/source/scanner/scanunx.cxx @@ -132,17 +132,16 @@ public: virtual void run() override; virtual void onTerminated() override { delete this; } public: - ScannerThread( std::shared_ptr pHolder, + ScannerThread( const std::shared_ptr& pHolder, const Reference< css::lang::XEventListener >& listener, ScannerManager* pManager ); virtual ~ScannerThread(); }; -ScannerThread::ScannerThread( - std::shared_ptr pHolder, +ScannerThread::ScannerThread(const std::shared_ptr& pHolder, const Reference< css::lang::XEventListener >& listener, - ScannerManager* pManager ) + ScannerManager* pManager) : m_pHolder( pHolder ), m_xListener( listener ), m_pManager( pManager ) { SAL_INFO("extensions.scanner", "ScannerThread"); -- cgit tion value='distro/collabora/lof-4.3'>distro/collabora/lof-4.3 LibreOffice 核心代码仓库文档基金会
summaryrefslogtreecommitdiff
AgeCommit message (Expand)Author
2020-09-01Fix typoAndrea Gelmini
2020-07-08svgio: create instances with uno constructorsNoel Grandin
2020-07-02Upcoming improved loplugin:staticanonymous -> redundantstatic: svgioStephan Bergmann
2020-05-10compact namespace in sal..svgioNoel Grandin
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin
2019-12-20tdf#42949 Fix IWYU warnings in svgio/Gabor Kelemen
2019-11-22Extend loplugin:external to warn about classesStephan Bergmann
2019-07-31Improved loplugin:stringconstant (now that GCC 7 supports it): svgioStephan Bergmann
2019-06-18loplugin:logexceptionnicely in starmath..svgioNoel Grandin
2019-04-12Downgrade a SAL_WARN() that shows up a lot but can be ignored to SAL_INFO()Tor Lillqvist
2019-03-06use gfx namespace for DrawCommandsTomaž Vajngerl
2019-03-06svgio visitor, add draw commands and create the from svgTomaž Vajngerl
2018-09-26loplugin:useuniqueptr in SvgDocumentNoel Grandin
2018-08-02Add missing sal/log.hxx headersGabor Kelemen
2017-12-29loplugin:unnecessaryparen improve return checkNoel Grandin
2017-12-11loplugin:salcall fix functionsNoel Grandin
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
2017-01-26Remove dynamic exception specificationsStephan Bergmann
2016-12-02loplugin:unnecessaryoverride (dtors) in svgioStephan Bergmann
2016-11-09convert Primitive2DContainer to std::dequeNoel Grandin
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
2016-05-27Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist
2016-04-13tdf#94306 replace boost::noncopyable in stoc to xmlsec..Jochen Nitschke
2015-12-11tdf#69977: uno::Sequence is expensiveNoel Grandin
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
2015-11-09new loplugin: oncevarNoel Grandin
2015-10-29com::sun::star->css in starmath,stoc,svgio,svlNoel Grandin
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann
2015-07-15cppcheck: noExplicitConstructorCaolán McNamara
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin
2014-05-16fix-includes.pl: svgioThomas Arnhold
2014-04-14Clean up function declarationsStephan Bergmann
2014-04-03remove unnecessary scope qualifier from sal_Bool usesNoel Grandin
2014-03-26First batch of adding SAL_OVERRRIDE to overriding function declarationsStephan Bergmann
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
2014-02-02fdo#54938 Convert basctl, mysqlc, sdext, svgio, writerp. to cppu::supportsSer.Alexandre Vicenzi
2013-06-13Resolves: #i121656# Some more cleanups for SVG importArmin Le Grand
2013-06-13don't make it a secret what the errors areCaolán McNamara
2013-04-07remove needless forward rtl::OUString declarationsLuboš Luňák
2013-04-07mass removal of rtl:: prefixes for O(U)String*Luboš Luňák
2013-03-19removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStrings declarationsThomas Arnhold
2013-03-19automated removal of RTL_CONSTASCII_USTRINGPARAM for quoted OUStringsThomas Arnhold
2013-02-13fdo#60471: svgio, sax: enable internal entity declarations for SVGMichael Stahl
2012-11-22fix export on windowsLuboš Luňák
2012-11-22Some svgio clean-upStephan Bergmann
2012-11-06re-base on ALv2 code. Includes (at least) relevant parts of:Michael Meeks