From 465359c35fcd8c30a2bedd3d0beb07c0c1c36cba Mon Sep 17 00:00:00 2001
From: Michael Stahl <mstahl@redhat.com>
Date: Wed, 11 Mar 2015 16:39:24 +0100
Subject: do not call virtual Commit() from dtors of utl::ConfigItem subclasses

~SvtAppFilterOptions_Impl() demonstrates that this is a bad idea, by not
invoking its subclasses' ImplCommit() but its own.

Change-Id: Ic675e9cd3be1494c740a4f289be3bdbf0d1a122b
---
 extensions/source/bibliography/bibconfig.cxx | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

(limited to 'extensions')

diff --git a/extensions/source/bibliography/bibconfig.cxx b/extensions/source/bibliography/bibconfig.cxx
index 4c7b65c9a559..5a3ed541a608 100644
--- a/extensions/source/bibliography/bibconfig.cxx
+++ b/extensions/source/bibliography/bibconfig.cxx
@@ -192,8 +192,7 @@ BibConfig::BibConfig()
 
 BibConfig::~BibConfig()
 {
-    if(IsModified())
-        Commit();
+    assert(!IsModified()); // should have been committed
     delete pMappingsArr;
 }
 
-- 
cgit