From 8bd5dd43a90576f4c55a05ed2ba1af49d2168bab Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sun, 11 Sep 2016 21:01:42 +0100 Subject: coverity#1371190 Missing move assignment operator Change-Id: I20991a31a82ff96292cdd1be4fd2c4779f9f5514 --- extensions/source/abpilot/datasourcehandling.cxx | 7 +++++-- extensions/source/abpilot/datasourcehandling.hxx | 4 +++- 2 files changed, 8 insertions(+), 3 deletions(-) (limited to 'extensions') diff --git a/extensions/source/abpilot/datasourcehandling.cxx b/extensions/source/abpilot/datasourcehandling.cxx index 3b809697bdde..6c09d1dce2f4 100644 --- a/extensions/source/abpilot/datasourcehandling.cxx +++ b/extensions/source/abpilot/datasourcehandling.cxx @@ -328,7 +328,6 @@ namespace abp *this = _rSource; } - ODataSource& ODataSource::operator=( const ODataSource& _rSource ) { if( this != &_rSource ) @@ -338,13 +337,17 @@ namespace abp return *this; } + ODataSource& ODataSource::operator=( ODataSource&& _rSource ) + { + m_pImpl = std::move(_rSource.m_pImpl); + return *this; + } ODataSource::ODataSource( const Reference< XComponentContext >& _rxORB ) :m_pImpl(new ODataSourceImpl(_rxORB)) { } - ODataSource::~ODataSource( ) { } diff --git a/extensions/source/abpilot/datasourcehandling.hxx b/extensions/source/abpilot/datasourcehandling.hxx index 65a4398c6846..928bbe00fb1c 100644 --- a/extensions/source/abpilot/datasourcehandling.hxx +++ b/extensions/source/abpilot/datasourcehandling.hxx @@ -113,9 +113,11 @@ namespace abp /// dtor ~ODataSource( ); - /// assignment + /// copy assignment ODataSource& operator=( const ODataSource& _rSource ); + /// move assignment + ODataSource& operator=( ODataSource&& _rSource ); /// checks whether or not the object represents a valid data source bool isValid() const; -- cgit