From c5e4534808c03ce30c7b3e4bbed38ed5fca2d77f Mon Sep 17 00:00:00 2001 From: Jochen Nitschke Date: Thu, 6 Jul 2017 19:36:34 +0200 Subject: remove nullptr checks on STL search result iterators results are in the range of first_iterator to last_iterator. If one of those is nullptr the algorithm would fail anyway. This removes some impossible checks in sw/source/core/unocore/unochart.cxx: SwChartDataProvider::detectArguments. A sorted range still holds the same values and has the same length as the original range. Replacing raw pointers eases reading this code. Change-Id: If96bd11e9167488346a57e9e08507ac42338d3cd Reviewed-on: https://gerrit.libreoffice.org/39683 Tested-by: Jenkins Reviewed-by: Noel Grandin --- extensions/source/propctrlr/cellbindinghelper.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'extensions') diff --git a/extensions/source/propctrlr/cellbindinghelper.cxx b/extensions/source/propctrlr/cellbindinghelper.cxx index 0a20acec0ac5..6852d76fe385 100644 --- a/extensions/source/propctrlr/cellbindinghelper.cxx +++ b/extensions/source/propctrlr/cellbindinghelper.cxx @@ -386,7 +386,7 @@ namespace pcr aAvailableServices.end(), StringCompare( _rService ) ); - if ( pFound - aAvailableServices.getConstArray() < aAvailableServices.getLength() ) + if ( pFound != aAvailableServices.end() ) { bYesItIs = true; } -- cgit