From d85108355c1802c7aed1ef1d9a19f6c633c4a0f8 Mon Sep 17 00:00:00 2001 From: Mike Kaganski Date: Sat, 3 Nov 2018 21:15:48 +0300 Subject: tdf#120703 PVS: V547 Expression is always true/false Change-Id: I27bf92770431f6a1f35e1c8224c0847555a8d43f Reviewed-on: https://gerrit.libreoffice.org/62819 Tested-by: Jenkins Reviewed-by: Mike Kaganski --- extensions/source/propctrlr/formlinkdialog.cxx | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) (limited to 'extensions') diff --git a/extensions/source/propctrlr/formlinkdialog.cxx b/extensions/source/propctrlr/formlinkdialog.cxx index b9ecb6d92fc7..e52ab453d168 100644 --- a/extensions/source/propctrlr/formlinkdialog.cxx +++ b/extensions/source/propctrlr/formlinkdialog.cxx @@ -588,16 +588,11 @@ namespace pcr try { - bool bEnable = true; - // only show the button when both forms are based on the same data source - if ( bEnable ) - { - OUString sMasterDS, sDetailDS; - xMasterFormProps->getPropertyValue( PROPERTY_DATASOURCE ) >>= sMasterDS; - xDetailFormProps->getPropertyValue( PROPERTY_DATASOURCE ) >>= sDetailDS; - bEnable = ( sMasterDS == sDetailDS ); - } + OUString sMasterDS, sDetailDS; + xMasterFormProps->getPropertyValue( PROPERTY_DATASOURCE ) >>= sMasterDS; + xDetailFormProps->getPropertyValue( PROPERTY_DATASOURCE ) >>= sDetailDS; + bool bEnable = ( sMasterDS == sDetailDS ); // only show the button when the connection supports relations if ( bEnable ) -- cgit