From b6ee5cf707343e5393514a47c024535ea6c1b7d1 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Mon, 26 Jan 2015 15:09:13 +0100 Subject: external/lib{odfgen,revenge}: Declare proper symbol visibility ...not only when building the libs themselves, but also when including their header files from other code. (Omission only becomes obvious with hidden function type RTTI causing false positives from Clang -fsanitize=function.) As these external libs do not record the decision to enable visiblity in a config header file that gets included, it appears easiest to hack that knowledge into gbuild for now. (Note that libodfgen internally uses librevenge.) Change-Id: I6a3a722d561b8cbce6e5b1f27d7aa2d7602f3cdf --- external/libodfgen/ExternalProject_libodfgen.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'external') diff --git a/external/libodfgen/ExternalProject_libodfgen.mk b/external/libodfgen/ExternalProject_libodfgen.mk index 527681add8d5..066ea8662988 100644 --- a/external/libodfgen/ExternalProject_libodfgen.mk +++ b/external/libodfgen/ExternalProject_libodfgen.mk @@ -35,7 +35,7 @@ $(call gb_ExternalProject_get_state_target,libodfgen,build) : --disable-weffc \ --without-docs \ $(if $(VERBOSE)$(verbose),--disable-silent-rules,--enable-silent-rules) \ - CXXFLAGS="$(if $(SYSTEM_BOOST),$(BOOST_CPPFLAGS),-I$(call gb_UnpackedTarball_get_dir,boost))" \ + CXXFLAGS="$(if $(SYSTEM_BOOST),$(BOOST_CPPFLAGS),-I$(call gb_UnpackedTarball_get_dir,boost)) $(if $(SYSTEM_REVENGE),,$(if $(filter-out MSC,$(COM)),-DLIBREVENGE_VISIBILITY))" \ $(if $(CROSS_COMPILING),--build=$(BUILD_PLATFORM) --host=$(HOST_PLATFORM)) \ $(if $(filter MACOSX,$(OS)),--prefix=/@.__________________________________________________OOO) \ && $(MAKE) \ -- cgit