From 183c06fc02a50fb117bb6162e4d6e56cdd34fad1 Mon Sep 17 00:00:00 2001 From: László Németh Date: Wed, 3 Feb 2021 16:56:49 +0100 Subject: tdf#139301 fix OOXML-compatible preset dash styles MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Despite the purpose of the new interoperability styles added in commit b2d8093b19642038631dfb8f1ab6745a380a652c (tdf#127499 added 9 new line styles all are (var) and in line with MSO), collision with commit 57c9bdab377a00649299d1a4c9ed2f9e5e03b84e (tdf#127166, tdf#123903 improve import/export of line styles) resulted still missing interoperability on the user interface: 1) opening an OOXML document, preset styles weren't recognized on the UI, also the preview was a solid line on the Drawing Object Properties toolbar. 2) using the new compatibility preset styles, OOXML export resulted custom styles instead of the intended preset styles. On the UI, now the layout of the first 10 preset dash styles follows the OOXML standard, see 20.1.10.49 ST_PresetLineDashVal (Preset Line Dash Value) in ISO/IEC 29500-1, 2016: dash pattern name (OOXML name) 10 "Dot" (sysDot) 1000 "Long Dot" (dot) 1110 "Dash" (sysDash) 1111000 "Long Dash" (dash) 11111111000 "Double Dash" (lgDash) 111010 "Dash Dot" (sysDashDot) 11110001000 "Long Dash Dot (dashDot) 111111110001000 "Double Dash Dot" (lgDashDot) 11101010 "Dash Dot Dot" (sysDashDotDot) 1111111100010001000 "Double Dash Dot Dot" (lgDashDotDot) Note: add missing "Dash Dot Dot" (sysDashDotDot). Remove "Double Dot": it really wasn't an OOXML-compatible preset style, and it has a good replacement among the older styles, the similarly loosely dotted "Fine dotted", which is still supported for back-compatibility. Note: to start the new UI test, use $ (cd sw; make -srj8 UITest_writer_tests7 UITEST_TEST_NAME="tdf139301.tdf139301.test_tdf139301" SAL_USE_VCLPLUGIN=gen) Change-Id: Ifc3fa634f2170aada61632e0a419d35dcaaf5ef6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110386 Tested-by: Jenkins Reviewed-by: László Németh --- extras/source/palettes/standard.sod | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'extras/source/palettes') diff --git a/extras/source/palettes/standard.sod b/extras/source/palettes/standard.sod index d8b010b1ada1..3ac90cb0604a 100644 --- a/extras/source/palettes/standard.sod +++ b/extras/source/palettes/standard.sod @@ -2,14 +2,15 @@ - - - - - - - - + + + + + + + + + -- cgit