From 4e7396dbe06df9cb6d441b0cf6c245426c11ff68 Mon Sep 17 00:00:00 2001 From: Armin Le Grand Date: Fri, 22 Jul 2016 16:09:34 +0200 Subject: screenshots: add dialog test cases for filter All *.ui files create a screenshot, but not all look useful Change-Id: Idd684f1fee55eebb58b4b56a2681cd4058be2880 --- filter/CppunitTest_filter_dialogs_test.mk | 66 ++++++++++++ filter/Module_filter.mk | 4 + filter/qa/unit/data/filter-dialogs-test.txt | 50 ++++++++++ filter/qa/unit/filter-dialogs-test.cxx | 150 ++++++++++++++++++++++++++++ 4 files changed, 270 insertions(+) create mode 100644 filter/CppunitTest_filter_dialogs_test.mk create mode 100644 filter/qa/unit/data/filter-dialogs-test.txt create mode 100644 filter/qa/unit/filter-dialogs-test.cxx (limited to 'filter') diff --git a/filter/CppunitTest_filter_dialogs_test.mk b/filter/CppunitTest_filter_dialogs_test.mk new file mode 100644 index 000000000000..018bc6365f69 --- /dev/null +++ b/filter/CppunitTest_filter_dialogs_test.mk @@ -0,0 +1,66 @@ +# -*- Mode: makefile-gmake; tab-width: 4; indent-tabs-mode: t -*- +#************************************************************************* +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# +#************************************************************************* + +$(eval $(call gb_CppunitTest_CppunitTest,filter_dialogs_test)) + +$(eval $(call gb_CppunitTest_add_exception_objects,filter_dialogs_test, \ + filter/qa/unit/filter-dialogs-test \ +)) + +$(eval $(call gb_CppunitTest_use_sdk_api,filter_dialogs_test)) + +$(eval $(call gb_CppunitTest_set_include,filter_dialogs_test,\ + -I$(SRCDIR)/filter/inc \ + $$(INCLUDE) \ +)) + +$(eval $(call gb_CppunitTest_use_libraries,filter_dialogs_test, \ + basegfx \ + comphelper \ + cppu \ + cppuhelper \ + drawinglayer \ + editeng \ + i18nlangtag \ + i18nutil \ + msfilter \ + oox \ + sal \ + salhelper \ + sax \ + sfx \ + sot \ + svl \ + svt \ + test \ + tl \ + tk \ + ucbhelper \ + unotest \ + utl \ + vcl \ + xo \ + $(gb_UWINAPI) \ +)) + +$(eval $(call gb_CppunitTest_use_external,filter_dialogs_test,boost_headers)) + +$(eval $(call gb_CppunitTest_use_sdk_api,filter_dialogs_test)) + +$(eval $(call gb_CppunitTest_use_ure,filter_dialogs_test)) +$(eval $(call gb_CppunitTest_use_vcl_non_headless_with_windows,filter_dialogs_test)) + +$(eval $(call gb_CppunitTest_use_rdb,filter_dialogs_test,services)) + +# $(eval $(call gb_CppunitTest_use_configuration,filter_dialogs_test)) +$(eval $(call gb_CppunitTest_use_instdir_configuration,filter_dialogs_test)) + +# vim: set noet sw=4 ts=4: diff --git a/filter/Module_filter.mk b/filter/Module_filter.mk index 594fa117eb05..204d208bb1bb 100644 --- a/filter/Module_filter.mk +++ b/filter/Module_filter.mk @@ -84,4 +84,8 @@ endif JunitTest_filter_complex \ )) +$(eval $(call gb_Module_add_slowcheck_targets,filter,\ + CppunitTest_filter_dialogs_test \ +)) + # vim: set noet sw=4 ts=4: diff --git a/filter/qa/unit/data/filter-dialogs-test.txt b/filter/qa/unit/data/filter-dialogs-test.txt new file mode 100644 index 000000000000..1b6fcbc5b96c --- /dev/null +++ b/filter/qa/unit/data/filter-dialogs-test.txt @@ -0,0 +1,50 @@ +# -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- +# +# This file is part of the LibreOffice project. +# +# This Source Code Form is subject to the terms of the Mozilla Public +# License, v. 2.0. If a copy of the MPL was not distributed with this +# file, You can obtain one at http://mozilla.org/MPL/2.0/. +# + +# This file contains all dialogs that the unit tests in the module +# will work on if it is in script mode. It will read one-by-one, +# try to open it and create a screenshot that will be saved in +# workdir/screenshots using the pattern of the ui-file name. +# +# Syntax: +# - emty lines are allowed +# - lines starting with '#' are treated as comment +# - all other lines should contain a *.ui filename in the same +# notation as in the dialog constructors (see code) + +# +# The 'known' dialogs which have a hard-coded representation +# in registerKnownDialogsByID/createDialogByID +# + +# No known dialogs in filter for now + +# +# Dialogs without a hard-coded representation. These will +# be visualized using a fallback based on VclBuilder +# + +# currently deactivated, leads to problems and the test to not work +# This is typically a hint that these should be hard-coded in the +# test case since they need some document and model data to work + +filter/ui/pdfoptionsdialog.ui +filter/ui/xsltfilterdialog.ui +filter/ui/pdfgeneralpage.ui +filter/ui/pdfviewpage.ui +filter/ui/pdfuserinterfacepage.ui +filter/ui/pdfsecuritypage.ui +filter/ui/pdflinkspage.ui +filter/ui/pdfsignpage.ui +filter/ui/xmlfiltertabpagegeneral.ui +filter/ui/xmlfiltertabpagetransformation.ui +filter/ui/impswfdialog.ui +filter/ui/testxmlfilter.ui +filter/ui/warnpdfdialog.ui +filter/ui/xmlfiltersettings.ui diff --git a/filter/qa/unit/filter-dialogs-test.cxx b/filter/qa/unit/filter-dialogs-test.cxx new file mode 100644 index 000000000000..91a891de022f --- /dev/null +++ b/filter/qa/unit/filter-dialogs-test.cxx @@ -0,0 +1,150 @@ +/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ +/* + * This file is part of the LibreOffice project. + * + * This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at http://mozilla.org/MPL/2.0/. + */ + +#include +#include +#include +#include +#include +#include + +using namespace ::com::sun::star; + +/// Test opening a dialog in filter +class FilterDialogsTest : public ScreenshotTest +{ +private: + /// helper method to populate KnownDialogs, called in setUp(). Needs to be + /// written and has to add entries to KnownDialogs + virtual void registerKnownDialogsByID(mapType& rKnownDialogs) override; + + /// dialog creation for known dialogs by ID. Has to be implemented for + /// each registered known dialog + virtual VclAbstractDialog* createDialogByID(sal_uInt32 nID) override; + +public: + FilterDialogsTest(); + virtual ~FilterDialogsTest(); + + virtual void setUp() override; + + // try to open a dialog + void openAnyDialog(); + + CPPUNIT_TEST_SUITE(FilterDialogsTest); + CPPUNIT_TEST(openAnyDialog); + CPPUNIT_TEST_SUITE_END(); +}; + +FilterDialogsTest::FilterDialogsTest() +{ +} + +FilterDialogsTest::~FilterDialogsTest() +{ +} + +void FilterDialogsTest::setUp() +{ + ScreenshotTest::setUp(); +} + +void FilterDialogsTest::registerKnownDialogsByID(mapType& /*rKnownDialogs*/) +{ + // fill map of known dilogs +} + +VclAbstractDialog* FilterDialogsTest::createDialogByID(sal_uInt32 /*nID*/) +{ + return nullptr; +} + +void FilterDialogsTest::openAnyDialog() +{ + /// example how to process an input file containing the UXMLDescriptions of the dialogs + /// to dump + if (true) + { + test::Directories aDirectories; + OUString aURL = aDirectories.getURLFromSrc("filter/qa/unit/data/filter-dialogs-test.txt"); + SvFileStream aStream(aURL, StreamMode::READ); + OString aNextUIFile; + const OString aComment("#"); + + while (aStream.ReadLine(aNextUIFile)) + { + if (!aNextUIFile.isEmpty() && !aNextUIFile.startsWith(aComment)) + { + // first check if it's a known dialog + std::unique_ptr pDlg(createDialogByName(aNextUIFile)); + + if (pDlg) + { + // known dialog, dump screenshot to path + dumpDialogToPath(*pDlg); + } + else + { + // unknown dialog, try fallback to generic created + // VclBuilder-generated instance. Keep in mind that Dialogs + // using this mechanism will probably not be layouted well + // since the setup/initialization part is missing. Thus, + // only use for fallback when only the UI file is available. + dumpDialogToPath(aNextUIFile); + } + } + } + } + + /// example how to dump all known dialogs + if (false) + { + // example for SfxTabDialog: 5 -> "modules/sdraw/ui/drawpagedialog.ui" + // example for TabDialog: 22 -> "modules/simpress/ui/headerfooterdialog.ui" + // example for self-adapted wizard: 0 -> "modules/simpress/ui/publishingdialog.ui" + for (mapType::const_iterator i = getKnownDialogs().begin(); i != getKnownDialogs().end(); i++) + { + std::unique_ptr pDlg(createDialogByID((*i).second)); + + if (pDlg) + { + // known dialog, dump screenshot to path + dumpDialogToPath(*pDlg); + } + else + { + // unknown dialog, should not happen in this basic loop. + // You have probably forgotten to add a case and + // implementastion to createDialogByID, please do this + } + } + } + + /// example how to dump a dialog using fallback functionality + if (false) + { + // unknown dialog, try fallback to generic created + // VclBuilder-generated instance. Keep in mind that Dialogs + // using this mechanism will probably not be layouted well + // since the setup/initialization part is missing. Thus, + // only use for fallback when only the UI file is available. + // + // Take any example here, it's only for demonstration - using + // even a known one to demonstrate the fallback possibility + const OString aUIXMLDescription("filter/ui/pdfoptionsdialog.ui"); + + dumpDialogToPath(aUIXMLDescription); + } +} + +CPPUNIT_TEST_SUITE_REGISTRATION(FilterDialogsTest); + +CPPUNIT_PLUGIN_IMPLEMENT(); + +/* vim:set shiftwidth=4 softtabstop=4 expandtab: */ -- cgit