From a0b25939c403618abaedd10bf55a8e83fb8e94ea Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 22 Dec 2015 15:49:26 +0200 Subject: loplugin:unusedfields in filter Change-Id: Ic35cff139f5f180ff93fe7b1ecbd15de6c474821 --- filter/source/config/cache/configflush.cxx | 7 +++---- filter/source/config/cache/configflush.hxx | 6 +----- filter/source/graphic/GraphicExportDialog.cxx | 5 ++--- filter/source/graphic/GraphicExportDialog.hxx | 1 - filter/source/graphic/GraphicExportFilter.cxx | 5 ++--- filter/source/graphic/GraphicExportFilter.hxx | 2 -- filter/source/pdf/impdialog.hxx | 1 - filter/source/pdf/pdfexport.hxx | 2 -- filter/source/placeware/exporter.hxx | 1 - filter/source/svg/svgdialog.hxx | 1 - filter/source/t602/t602filter.cxx | 8 ++++---- filter/source/t602/t602filter.hxx | 3 +-- filter/source/textfilterdetect/filterdetect.cxx | 9 ++++----- filter/source/textfilterdetect/filterdetect.hxx | 4 +--- 14 files changed, 18 insertions(+), 37 deletions(-) (limited to 'filter') diff --git a/filter/source/config/cache/configflush.cxx b/filter/source/config/cache/configflush.cxx index 1f625367487e..2bf04cc66a6c 100644 --- a/filter/source/config/cache/configflush.cxx +++ b/filter/source/config/cache/configflush.cxx @@ -26,9 +26,8 @@ namespace filter{ namespace config{ -ConfigFlush::ConfigFlush(const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR) +ConfigFlush::ConfigFlush() : BaseLock ( ) - , m_xSMGR (xSMGR ) , m_lListener(m_aLock) { } @@ -122,9 +121,9 @@ css::uno::Sequence< OUString > ConfigFlush::impl_getSupportedServiceNames() } -css::uno::Reference< css::uno::XInterface > ConfigFlush::impl_createInstance(const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR) +css::uno::Reference< css::uno::XInterface > ConfigFlush::impl_createInstance(const css::uno::Reference< css::lang::XMultiServiceFactory >& ) { - ConfigFlush* pNew = new ConfigFlush(xSMGR); + ConfigFlush* pNew = new ConfigFlush; return css::uno::Reference< css::uno::XInterface >(static_cast< css::util::XRefreshable* >(pNew), css::uno::UNO_QUERY); } diff --git a/filter/source/config/cache/configflush.hxx b/filter/source/config/cache/configflush.hxx index 413561c3f9c6..e5bde60d7580 100644 --- a/filter/source/config/cache/configflush.hxx +++ b/filter/source/config/cache/configflush.hxx @@ -50,10 +50,6 @@ class ConfigFlush : public BaseLock protected: - /** @short reference to an uno service manager, which can be used - to create own needed services. */ - css::uno::Reference< css::lang::XMultiServiceFactory > m_xSMGR; - /** @short holds all listener, which are registered at this instance. */ ::cppu::OMultiTypeInterfaceContainerHelper m_lListener; @@ -67,7 +63,7 @@ class ConfigFlush : public BaseLock /** @short standard ctor. */ - explicit ConfigFlush(const css::uno::Reference< css::lang::XMultiServiceFactory >& xSMGR); + ConfigFlush(); diff --git a/filter/source/graphic/GraphicExportDialog.cxx b/filter/source/graphic/GraphicExportDialog.cxx index 94f02c58e62d..f2d9a8282bda 100644 --- a/filter/source/graphic/GraphicExportDialog.cxx +++ b/filter/source/graphic/GraphicExportDialog.cxx @@ -37,9 +37,8 @@ using namespace css::uno; using namespace css::beans; using namespace css::lang; -GraphicExportDialog::GraphicExportDialog( const Reference< XComponentContext >& rxContext ) - : mxContext( rxContext ) - , meFieldUnit(FUNIT_NONE) +GraphicExportDialog::GraphicExportDialog( const Reference< XComponentContext >& ) + : meFieldUnit(FUNIT_NONE) , mbExportSelection( false ) { } diff --git a/filter/source/graphic/GraphicExportDialog.hxx b/filter/source/graphic/GraphicExportDialog.hxx index 2e1726e862c5..36869afac7f1 100644 --- a/filter/source/graphic/GraphicExportDialog.hxx +++ b/filter/source/graphic/GraphicExportDialog.hxx @@ -45,7 +45,6 @@ class GraphicExportDialog : public cppu::WeakImplHelper Sequence maMediaDescriptor; Sequence maFilterDataSequence; Reference mxSourceDocument; - Reference mxContext; OUString maDialogTitle; FieldUnit meFieldUnit; diff --git a/filter/source/graphic/GraphicExportFilter.cxx b/filter/source/graphic/GraphicExportFilter.cxx index 678479e8a996..86f0d4932f5a 100644 --- a/filter/source/graphic/GraphicExportFilter.cxx +++ b/filter/source/graphic/GraphicExportFilter.cxx @@ -23,9 +23,8 @@ #include #include -GraphicExportFilter::GraphicExportFilter( const Reference& rxContext ) - : mxContext( rxContext ) - , mExportSelection(false) +GraphicExportFilter::GraphicExportFilter( const Reference& ) + : mExportSelection(false) , mTargetWidth(0) , mTargetHeight(0) {} diff --git a/filter/source/graphic/GraphicExportFilter.hxx b/filter/source/graphic/GraphicExportFilter.hxx index 157993754c16..b0ae945d0e53 100644 --- a/filter/source/graphic/GraphicExportFilter.hxx +++ b/filter/source/graphic/GraphicExportFilter.hxx @@ -41,8 +41,6 @@ class GraphicExportFilter : public cppu::WeakImplHelper < XFilter, XExporter, XInitialization > { Reference mxDocument; - Reference mxContext; - Reference mxStatusIndicator; Reference mxOutputStream; void gatherProperties( const Sequence& rDescriptor ); diff --git a/filter/source/pdf/impdialog.hxx b/filter/source/pdf/impdialog.hxx index f4d916ec92de..cd2587b3aa10 100644 --- a/filter/source/pdf/impdialog.hxx +++ b/filter/source/pdf/impdialog.hxx @@ -74,7 +74,6 @@ class ImpPDFTabLinksPage; class ImpPDFTabDialog : public SfxTabDialog { private: - css::uno::Reference< css::uno::XComponentContext> mxContext; FilterConfigItem maConfigItem; FilterConfigItem maConfigI18N; diff --git a/filter/source/pdf/pdfexport.hxx b/filter/source/pdf/pdfexport.hxx index b37cf15bb661..3f2ad4658a06 100644 --- a/filter/source/pdf/pdfexport.hxx +++ b/filter/source/pdf/pdfexport.hxx @@ -92,8 +92,6 @@ private: bool mbCanCopyOrExtract; bool mbCanExtractForAccessibility; - SvtGraphicFill maCacheFill; - //--->i56629 bool mbExportRelativeFsysLinks; sal_Int32 mnDefaultLinkAction; diff --git a/filter/source/placeware/exporter.hxx b/filter/source/placeware/exporter.hxx index de723ed37be3..c70bd7e5e8f8 100644 --- a/filter/source/placeware/exporter.hxx +++ b/filter/source/placeware/exporter.hxx @@ -46,7 +46,6 @@ private: css::uno::Reference< css::uno::XComponentContext > mxContext; css::uno::Reference< css::drawing::XGraphicExportFilter > mxGraphicExporter; - css::uno::Reference< css::task::XInteractionHandler > mxInteractionHandler; }; #endif diff --git a/filter/source/svg/svgdialog.hxx b/filter/source/svg/svgdialog.hxx index 5b88b842cd39..1f1553d71880 100644 --- a/filter/source/svg/svgdialog.hxx +++ b/filter/source/svg/svgdialog.hxx @@ -40,7 +40,6 @@ class SVGDialog : public ::svt::OGenericUnoDialog, { private: - ::std::unique_ptr< ResMgr > mapResMgr; css::uno::Sequence< css::beans::PropertyValue > maMediaDescriptor; css::uno::Sequence< css::beans::PropertyValue > maFilterData; css::uno::Reference< css::lang::XComponent > mxSrcDoc; diff --git a/filter/source/t602/t602filter.cxx b/filter/source/t602/t602filter.cxx index 86ff3a5ad769..8061a5896930 100644 --- a/filter/source/t602/t602filter.cxx +++ b/filter/source/t602/t602filter.cxx @@ -912,8 +912,8 @@ Reference< XInterface > SAL_CALL T602ImportFilter_createInstance( const Referenc return static_cast(new T602ImportFilter( rSMgr )); } -T602ImportFilterDialog::T602ImportFilterDialog(const css::uno::Reference &r ) : - mxMSF( r ), mpResMgr( nullptr ) {} +T602ImportFilterDialog::T602ImportFilterDialog() : + mpResMgr( nullptr ) {} T602ImportFilterDialog::~T602ImportFilterDialog() { @@ -1192,10 +1192,10 @@ Sequence< OUString > SAL_CALL T602ImportFilterDialog_getSupportedServiceNames( return aRet; } -Reference< XInterface > SAL_CALL T602ImportFilterDialog_createInstance( const Reference< XMultiServiceFactory > & rSMgr) +Reference< XInterface > SAL_CALL T602ImportFilterDialog_createInstance( const Reference< XMultiServiceFactory > & ) throw( Exception ) { - return static_cast(new T602ImportFilterDialog( rSMgr )); + return static_cast(new T602ImportFilterDialog); } } diff --git a/filter/source/t602/t602filter.hxx b/filter/source/t602/t602filter.hxx index d0d9d93a1cff..798a93de736c 100644 --- a/filter/source/t602/t602filter.hxx +++ b/filter/source/t602/t602filter.hxx @@ -96,7 +96,6 @@ class T602ImportFilterDialog : public cppu::WeakImplHelper < css::beans::XPropertyAccess > { - css::uno::Reference< css::lang::XMultiServiceFactory > mxMSF; css::lang::Locale meLocale; ResMgr *mpResMgr; bool OptionsDlg(); @@ -138,7 +137,7 @@ class T602ImportFilterDialog : public cppu::WeakImplHelper < css::uno::RuntimeException, std::exception) override; public: - explicit T602ImportFilterDialog(const css::uno::Reference &r ); + explicit T602ImportFilterDialog(); }; diff --git a/filter/source/textfilterdetect/filterdetect.cxx b/filter/source/textfilterdetect/filterdetect.cxx index 7d8310390473..632565f7e91a 100644 --- a/filter/source/textfilterdetect/filterdetect.cxx +++ b/filter/source/textfilterdetect/filterdetect.cxx @@ -116,8 +116,7 @@ bool IsHTMLStream( const uno::Reference& xInStream ) } -PlainTextFilterDetect::PlainTextFilterDetect(const uno::Reference& xCxt) : - mxCxt(xCxt) {} +PlainTextFilterDetect::PlainTextFilterDetect() {} PlainTextFilterDetect::~PlainTextFilterDetect() {} @@ -234,10 +233,10 @@ uno::Sequence SAL_CALL PlainTextFilterDetect::getSupportedServiceNames } extern "C" SAL_DLLPUBLIC_EXPORT css::uno::XInterface* SAL_CALL -com_sun_star_comp_filters_PlainTextFilterDetect_get_implementation(css::uno::XComponentContext* component, - css::uno::Sequence const &) +com_sun_star_comp_filters_PlainTextFilterDetect_get_implementation(css::uno::XComponentContext* , + css::uno::Sequence const &) { - return cppu::acquire(new PlainTextFilterDetect(component)); + return cppu::acquire(new PlainTextFilterDetect); } /* vim:set shiftwidth=4 softtabstop=4 expandtab: */ diff --git a/filter/source/textfilterdetect/filterdetect.hxx b/filter/source/textfilterdetect/filterdetect.hxx index 343432b44c22..200d3cd59c08 100644 --- a/filter/source/textfilterdetect/filterdetect.hxx +++ b/filter/source/textfilterdetect/filterdetect.hxx @@ -32,11 +32,9 @@ class PlainTextFilterDetect : public cppu::WeakImplHelper< css::lang::XInitialization, css::lang::XServiceInfo> { - css::uno::Reference mxCxt; - public: - explicit PlainTextFilterDetect (const css::uno::Reference& xCxt); + PlainTextFilterDetect(); virtual ~PlainTextFilterDetect(); // XExtendedFilterDetection -- cgit