From 802f2a420859f6787c86a960aa331245423d5820 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Wed, 12 Oct 2016 16:00:24 +0200 Subject: Don't allow O[U]StringBuffer in string concatenation ...as OStringBuffer b("foo"); b = "bar" + b; doesn't work as one might expect (see the mail thread starting at "concat of OUStringBuffer". That feature was LIBO_INTERNAL_ONLY, anyway. And of the affected places, MethodDescriptor::getSignature (codemaker/source/javamaker/javatype.cxx) was the only one that would actually have benefitted. Change-Id: Ib84266f43e40c42c2e428f0c0616db8cfa90adff --- forms/source/xforms/model_ui.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'forms/source/xforms') diff --git a/forms/source/xforms/model_ui.cxx b/forms/source/xforms/model_ui.cxx index 482fe7ade8a1..f8f5784c06bd 100644 --- a/forms/source/xforms/model_ui.cxx +++ b/forms/source/xforms/model_ui.cxx @@ -293,7 +293,7 @@ OUString Model::getNodeDisplayName( const XNode_t& xNode, OUString sContent = xNode->getNodeValue(); if( bDetail || ! lcl_isWhitespace( sContent ) ) { - aBuffer = aBuffer + "\"" + Convert::collapseWhitespace( sContent ) + "\""; + aBuffer.append("\"" + Convert::collapseWhitespace( sContent ) + "\""); } } break; @@ -866,7 +866,7 @@ static OUString lcl_serializeForDisplay( const Reference& xResult break; case XPathObjectType_XPATH_STRING: - aBuffer = aBuffer + "\"" + xResult->getString() + "\""; + aBuffer.append("\"" + xResult->getString() + "\""); break; case XPathObjectType_XPATH_NODESET: -- cgit