From 91b4e4531621b7afb2dbab1a8aa62c92da66951a Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Sun, 21 Jan 2018 13:07:10 +0200 Subject: new loplugin: pointerbool look for possibly bogus implicit conversions to bool when passing (normally pointer) args to bool params. this plugin comes in the wake of a couple of bugs caused by refactoring, where some of the call sites were not currently updated. Of the changes, the following are real bugs: desktop/../dp_persmap.cxx StartInputFieldDlg in sw/../fldmgr.cxx which occurred as a result of commit 39d719a80d8c87856c84e3ecd569d45fa6f8a30e Date: Tue May 3 11:39:37 2016 +0200 tdf#99529 sw: don't pop up input field dialog before inserting field CSerializationURLEncoded::encode_and_append in forms/../serialization_urlencoded.cxx XclExpCFImpl::XclExpCFImpl in sc/../xecontent.cxx I have no idea how to properly fix this, just made a guess. SwDocTest::test64kPageDescs in sw/qa/core/uwriter.cxx which looks like a simple copy/paste error. Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441 Reviewed-on: https://gerrit.libreoffice.org/48291 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- forms/source/xforms/submission/serialization_urlencoded.cxx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'forms/source/xforms') diff --git a/forms/source/xforms/submission/serialization_urlencoded.cxx b/forms/source/xforms/submission/serialization_urlencoded.cxx index 0e96edfb643c..626569aec2aa 100644 --- a/forms/source/xforms/submission/serialization_urlencoded.cxx +++ b/forms/source/xforms/submission/serialization_urlencoded.cxx @@ -80,7 +80,7 @@ void CSerializationURLEncoded::encode_and_append(const OUString& aString, OStri if( *pString < 0x80 ) { if ( is_unreserved(*pString) ) { - aBuffer.append(*pString); + aBuffer.append(char(*pString)); } else if (*pString == 0x20) { aBuffer.append('+'); } else if (*pString == 0x0d && *(pString+1) == 0x0a) { -- cgit