From e3133ae2371b6e2d4b47daa6a3487ea4f2753315 Mon Sep 17 00:00:00 2001
From: Stephan Bergmann <sbergman@redhat.com>
Date: Thu, 23 Jan 2014 18:43:53 +0100
Subject: Let C++ inline functions return bool instead of sal_Bool

...to improve diagnosing misuses of boolean expressions in client code (cf.
compilerplugins/clang/implicitboolconversion.cxx).  This change should be
transparent to client code.

Missing overloads of insert() for bool have been added to OStringBuffer and
OUStringBuffer (which required dropping one !VALID_CONVERSION check that would
now pick that overload, but would be flagged by
compilerplugins/clang/pointertobool.cxx).

Change-Id: I2d64cd923b8f47bfaa31e753def6515c29a3f8c9
---
 forms/source/xforms/model_helper.hxx | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'forms')

diff --git a/forms/source/xforms/model_helper.hxx b/forms/source/xforms/model_helper.hxx
index 28972e34aeda..72fb684228e9 100644
--- a/forms/source/xforms/model_helper.hxx
+++ b/forms/source/xforms/model_helper.hxx
@@ -120,12 +120,12 @@ public:
     {
         const com::sun::star::beans::PropertyValue* pValues = t.getConstArray();
         OUString sInstance( "Instance" );
-        sal_Bool bFound = sal_False;
+        bool bFound = false;
         for( sal_Int32 i = 0; ( ! bFound ) && ( i < t.getLength() ); i++ )
         {
             bFound |= ( pValues[i].Name == sInstance );
         }
-        return bFound ? true : false;
+        return bFound;
     }
 };
 
-- 
cgit