From 423936ffacb72f85b37961e4cd585fe2719799b7 Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 18 Oct 2016 14:42:58 +0200 Subject: loplugin:expandablemethodds in formula..framework Change-Id: I6c8b1bb3b664faa92b2dc05955c30bfd35f6dfaa Reviewed-on: https://gerrit.libreoffice.org/30015 Reviewed-by: Noel Grandin Tested-by: Noel Grandin --- framework/source/helper/oframes.cxx | 17 ++--------------- 1 file changed, 2 insertions(+), 15 deletions(-) (limited to 'framework/source/helper/oframes.cxx') diff --git a/framework/source/helper/oframes.cxx b/framework/source/helper/oframes.cxx index 3759a3adcbe7..4f96df15f476 100644 --- a/framework/source/helper/oframes.cxx +++ b/framework/source/helper/oframes.cxx @@ -62,7 +62,7 @@ void SAL_CALL OFrames::append( const css::uno::Reference< XFrame >& xFrame ) thr // Safe impossible cases // Method is not defined for ALL incoming parameters! - SAL_WARN_IF( !impldbg_checkParameter_append( xFrame ), "fwk", "OFrames::append(): Invalid parameter detected!" ); + SAL_WARN_IF( !xFrame.is(), "fwk", "OFrames::append(): Invalid parameter detected!" ); // Do the follow only, if owner instance valid! // Lock owner for follow operations - make a "hard reference"! @@ -85,7 +85,7 @@ void SAL_CALL OFrames::remove( const css::uno::Reference< XFrame >& xFrame ) thr // Safe impossible cases // Method is not defined for ALL incoming parameters! - SAL_WARN_IF( !impldbg_checkParameter_remove( xFrame ), "fwk", "OFrames::remove(): Invalid parameter detected!" ); + SAL_WARN_IF( !xFrame.is(), "fwk", "OFrames::remove(): Invalid parameter detected!" ); // Do the follow only, if owner instance valid! // Lock owner for follow operations - make a "hard reference"! @@ -354,19 +354,6 @@ bool OFrames::impldbg_checkParameter_OFramesCtor( const css::uno::Reference< return xOwner.is() && pFrameContainer != nullptr; } -// Its only allowed to add valid references to container. -// AND - alle frames must support XFrames-interface! -bool OFrames::impldbg_checkParameter_append( const css::uno::Reference< XFrame >& xFrame ) -{ - return xFrame.is(); -} - -// Its only allowed to add valid references to container... -// ... => You can only delete valid references! -bool OFrames::impldbg_checkParameter_remove( const css::uno::Reference< XFrame >& xFrame ) -{ - return xFrame.is(); -} // A search for frames must initiate with right flags. // Some one are superflous and not supported yet. But here we control only the range of incoming parameter! -- cgit