From 4347b5975283ca1a591b6c3d4559ed360e187022 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sun, 21 Oct 2018 15:53:34 +0100 Subject: pvs-studio: V728 An excessive check can be simplified MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit for... "The '(A && !B) || (!A && B)' expression is equivalent to the 'bool(A) != bool(B)' expression" subcases, where the args are already bool Change-Id: Ica8b5c4974c513f7f7ad8acf17ca931e85ebc8af Reviewed-on: https://gerrit.libreoffice.org/62146 Tested-by: Jenkins Reviewed-by: Caolán McNamara Tested-by: Caolán McNamara --- framework/source/xml/imagesdocumenthandler.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'framework') diff --git a/framework/source/xml/imagesdocumenthandler.cxx b/framework/source/xml/imagesdocumenthandler.cxx index f18df438ab4e..927e52627e97 100644 --- a/framework/source/xml/imagesdocumenthandler.cxx +++ b/framework/source/xml/imagesdocumenthandler.cxx @@ -147,8 +147,7 @@ void SAL_CALL OReadImagesDocumentHandler::endDocument() { SolarMutexGuard g; - if (( m_bImageContainerStartFound && !m_bImageContainerEndFound ) || - ( !m_bImageContainerStartFound && m_bImageContainerEndFound ) ) + if (m_bImageContainerStartFound != m_bImageContainerEndFound) { OUString aErrorMessage = getErrorLineString(); aErrorMessage += "No matching start or end element 'image:imagecontainer' found!"; -- cgit