From 7bbe74b2be45afff4418b29deca6448795d86715 Mon Sep 17 00:00:00 2001 From: Caolán McNamara Date: Sun, 27 Oct 2024 13:19:14 +0000 Subject: cid#1555789 COPY_INSTEAD_OF_MOVE MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit and cid#1556865 COPY_INSTEAD_OF_MOVE cid#1556871 COPY_INSTEAD_OF_MOVE cid#1556939 COPY_INSTEAD_OF_MOVE cid#1556951 COPY_INSTEAD_OF_MOVE cid#1556964 COPY_INSTEAD_OF_MOVE cid#1556966 COPY_INSTEAD_OF_MOVE cid#1556968 COPY_INSTEAD_OF_MOVE cid#1556971 COPY_INSTEAD_OF_MOVE cid#1556989 COPY_INSTEAD_OF_MOVE cid#1557001 COPY_INSTEAD_OF_MOVE cid#1557011 COPY_INSTEAD_OF_MOVE cid#1557032 COPY_INSTEAD_OF_MOVE cid#1557038 COPY_INSTEAD_OF_MOVE cid#1557041 COPY_INSTEAD_OF_MOVE cid#1557055 COPY_INSTEAD_OF_MOVE cid#1557056 COPY_INSTEAD_OF_MOVE cid#1557057 COPY_INSTEAD_OF_MOVE cid#1557065 COPY_INSTEAD_OF_MOVE cid#1557068 COPY_INSTEAD_OF_MOVE cid#1557087 COPY_INSTEAD_OF_MOVE cid#1557090 COPY_INSTEAD_OF_MOVE cid#1557093 COPY_INSTEAD_OF_MOVE cid#1557113 COPY_INSTEAD_OF_MOVE cid#1557122 COPY_INSTEAD_OF_MOVE cid#1557126 COPY_INSTEAD_OF_MOVE cid#1557145 COPY_INSTEAD_OF_MOVE cid#1557151 COPY_INSTEAD_OF_MOVE cid#1557152 COPY_INSTEAD_OF_MOVE cid#1557197 COPY_INSTEAD_OF_MOVE cid#1557216 COPY_INSTEAD_OF_MOVE cid#1557245 COPY_INSTEAD_OF_MOVE cid#1557272 COPY_INSTEAD_OF_MOVE cid#1557310 COPY_INSTEAD_OF_MOVE cid#1557314 COPY_INSTEAD_OF_MOVE cid#1557318 COPY_INSTEAD_OF_MOVE cid#1557333 COPY_INSTEAD_OF_MOVE cid#1557340 COPY_INSTEAD_OF_MOVE cid#1557358 COPY_INSTEAD_OF_MOVE cid#1557359 COPY_INSTEAD_OF_MOVE cid#1557365 COPY_INSTEAD_OF_MOVE cid#1557367 COPY_INSTEAD_OF_MOVE cid#1557395 COPY_INSTEAD_OF_MOVE cid#1557418 COPY_INSTEAD_OF_MOVE cid#1557488 COPY_INSTEAD_OF_MOVE cid#1557493 COPY_INSTEAD_OF_MOVE cid#1557506 COPY_INSTEAD_OF_MOVE cid#1557514 COPY_INSTEAD_OF_MOVE cid#1557528 COPY_INSTEAD_OF_MOVE cid#1557534 COPY_INSTEAD_OF_MOVE cid#1557537 COPY_INSTEAD_OF_MOVE cid#1557562 COPY_INSTEAD_OF_MOVE cid#1557563 COPY_INSTEAD_OF_MOVE cid#1557592 COPY_INSTEAD_OF_MOVE cid#1557608 COPY_INSTEAD_OF_MOVE cid#1557615 COPY_INSTEAD_OF_MOVE cid#1557619 COPY_INSTEAD_OF_MOVE cid#1557637 COPY_INSTEAD_OF_MOVE cid#1557648 COPY_INSTEAD_OF_MOVE cid#1557712 COPY_INSTEAD_OF_MOVE cid#1557750 COPY_INSTEAD_OF_MOVE cid#1557762 COPY_INSTEAD_OF_MOVE cid#1557765 COPY_INSTEAD_OF_MOVE Change-Id: I10db1910627e04a26e25836c05ad5c2707abd18b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175696 Reviewed-by: Caolán McNamara Tested-by: Jenkins --- framework/source/helper/statusindicatorfactory.cxx | 4 ++-- framework/source/helper/tagwindowasmodified.cxx | 2 +- framework/source/services/frame.cxx | 2 +- framework/source/uiconfiguration/imagemanagerimpl.cxx | 4 ++-- framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx | 4 ++-- framework/source/uiconfiguration/uiconfigurationmanager.cxx | 2 +- 6 files changed, 9 insertions(+), 9 deletions(-) (limited to 'framework') diff --git a/framework/source/helper/statusindicatorfactory.cxx b/framework/source/helper/statusindicatorfactory.cxx index fe88000996f8..b4b1366554d7 100644 --- a/framework/source/helper/statusindicatorfactory.cxx +++ b/framework/source/helper/statusindicatorfactory.cxx @@ -319,7 +319,7 @@ void StatusIndicatorFactory::implts_makeParentVisibleIfAllowed() if (xFrame.is()) xParentWindow = xFrame->getContainerWindow(); else - xParentWindow = xPluggWindow; + xParentWindow = std::move(xPluggWindow); // don't disturb user in case he put the loading document into the background! // Suppress any setVisible() or toFront() call in case the initial show was @@ -477,7 +477,7 @@ void StatusIndicatorFactory::impl_showProgress() } std::scoped_lock g(m_mutex); - m_xProgress = xProgress; + m_xProgress = std::move(xProgress); } void StatusIndicatorFactory::impl_hideProgress() diff --git a/framework/source/helper/tagwindowasmodified.cxx b/framework/source/helper/tagwindowasmodified.cxx index 5776d5cee19e..8f4fb11f02ec 100644 --- a/framework/source/helper/tagwindowasmodified.cxx +++ b/framework/source/helper/tagwindowasmodified.cxx @@ -135,7 +135,7 @@ void TagWindowAsModified::impl_update (const css::uno::Reference< css::frame::XF // Note: frame was set as member outside ! we have to refresh connections // regarding window and model only here. m_xWindow = std::move(pWindow); - m_xModel = xModel; + m_xModel = std::move(xModel); } m_xModel->addModifyListener (this); diff --git a/framework/source/services/frame.cxx b/framework/source/services/frame.cxx index 081ead8e70b7..aa9568700a5c 100644 --- a/framework/source/services/frame.cxx +++ b/framework/source/services/frame.cxx @@ -1165,7 +1165,7 @@ css::uno::Reference< css::frame::XFrame > SAL_CALL XFrameImpl::findFrame( const ) { if (xParent->getName() == sTargetFrameName) - xTarget = xParent; + xTarget = std::move(xParent); else { sal_Int32 nRightFlags = nSearchFlags & ~css::frame::FrameSearchFlag::CHILDREN; diff --git a/framework/source/uiconfiguration/imagemanagerimpl.cxx b/framework/source/uiconfiguration/imagemanagerimpl.cxx index e85d9a08789b..3dcfe40d764f 100644 --- a/framework/source/uiconfiguration/imagemanagerimpl.cxx +++ b/framework/source/uiconfiguration/imagemanagerimpl.cxx @@ -818,7 +818,7 @@ void ImageManagerImpl::replaceImages( ConfigurationEvent aReplaceEvent; aReplaceEvent.aInfo <<= nImageType; aReplaceEvent.Accessor <<= xOwner; - aReplaceEvent.Source = xOwner; + aReplaceEvent.Source = std::move(xOwner); aReplaceEvent.ResourceURL = m_aResourceString; aReplaceEvent.ReplacedElement = Any(); aReplaceEvent.Element <<= uno::Reference< XNameAccess >(pReplacedImages); @@ -1062,7 +1062,7 @@ void ImageManagerImpl::reload() ConfigurationEvent aRemoveEvent; aRemoveEvent.aInfo <<= static_cast(i); aRemoveEvent.Accessor <<= xOwner; - aRemoveEvent.Source = xOwner; + aRemoveEvent.Source = std::move(xOwner); aRemoveEvent.ResourceURL = m_aResourceString; aRemoveEvent.Element <<= uno::Reference< XNameAccess >( pRemovedImages ); implts_notifyContainerListener( aRemoveEvent, NotifyOp_Remove ); diff --git a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx index 155334b72ed1..eeebdfc73730 100644 --- a/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx +++ b/framework/source/uiconfiguration/moduleuiconfigurationmanager.cxx @@ -1313,7 +1313,7 @@ void SAL_CALL ModuleUIConfigurationManager::removeSettings( const OUString& Reso aEvent.ResourceURL = ResourceURL; aEvent.Accessor <<= xThis; - aEvent.Source = xIfac; + aEvent.Source = std::move(xIfac); aEvent.Element <<= xRemovedSettings; aEvent.ReplacedElement <<= pDefaultDataSettings->xSettings; @@ -1328,7 +1328,7 @@ void SAL_CALL ModuleUIConfigurationManager::removeSettings( const OUString& Reso aEvent.ResourceURL = ResourceURL; aEvent.Accessor <<= xThis; - aEvent.Source = xIfac; + aEvent.Source = std::move(xIfac); aEvent.Element <<= xRemovedSettings; aGuard.clear(); diff --git a/framework/source/uiconfiguration/uiconfigurationmanager.cxx b/framework/source/uiconfiguration/uiconfigurationmanager.cxx index 91b4624595ec..29be73cc0a72 100644 --- a/framework/source/uiconfiguration/uiconfigurationmanager.cxx +++ b/framework/source/uiconfiguration/uiconfigurationmanager.cxx @@ -660,7 +660,7 @@ void UIConfigurationManager::impl_Initialize() m_aUIElements[i].nElementType = i; m_aUIElements[i].bModified = false; - m_aUIElements[i].xStorage = xElementTypeStorage; + m_aUIElements[i].xStorage = std::move(xElementTypeStorage); } } else -- cgit