From 51d1ec7883444e6216f1020122084d3a996c9ecb Mon Sep 17 00:00:00 2001 From: Noel Grandin Date: Tue, 23 Oct 2018 07:50:57 +0200 Subject: clang-tidy performance-unnecessary-copy-init in editeng..i18npool Change-Id: I2ee2c8d15d8700cfaa1697363da4557c741a5f36 Reviewed-on: https://gerrit.libreoffice.org/62216 Tested-by: Jenkins Reviewed-by: Noel Grandin --- helpcompiler/source/HelpCompiler.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'helpcompiler') diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx index d7ce8cfcc5d9..9050c5f983a1 100644 --- a/helpcompiler/source/HelpCompiler.cxx +++ b/helpcompiler/source/HelpCompiler.cxx @@ -427,9 +427,8 @@ void myparser::traverse( xmlNodePtr parentNode ) //TODO: make these asserts and flush out all our broken help ids SAL_WARN_IF(hidstr.empty(), "helpcompiler", "hid='' for text:" << text); SAL_WARN_IF(!hidstr.empty() && extendedHelpText.empty(), "helpcompiler", "hid='.' with no hid bookmark branches in file: " << fileName + " for text: " << text); - for (auto const& elem : extendedHelpText) + for (const std::string& name : extendedHelpText) { - std::string name = elem; (*helptexts)[name] = text; } } -- cgit