From f020784e14a55c82418e4f231855040177ac9f82 Mon Sep 17 00:00:00 2001 From: Stephan Bergmann Date: Fri, 9 Jul 2021 13:04:19 +0200 Subject: Make loplugin:stringadd slightly more aggressive ...by assuming that all const member functions are side-effect free. (This presumably means that some of the special cases in StringAdd::isSideEffectFree are obsoleted by this more general case, but any such removal is postponed to later clean-up.) (Came across this when idly wondering why 8b7f948d9d79393bc6c1b11d239706666fd5d7de "sc, VmlFormControlExporter: avoid OStringBuffer style" had not been found by the plugin before.) Change-Id: I6bca10df53885b14a590543aabd61f23b3748572 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118675 Tested-by: Jenkins Reviewed-by: Stephan Bergmann --- i18nlangtag/qa/cppunit/test_languagetag.cxx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'i18nlangtag') diff --git a/i18nlangtag/qa/cppunit/test_languagetag.cxx b/i18nlangtag/qa/cppunit/test_languagetag.cxx index bd6f1b27bf22..4fcc05785f2e 100644 --- a/i18nlangtag/qa/cppunit/test_languagetag.cxx +++ b/i18nlangtag/qa/cppunit/test_languagetag.cxx @@ -760,8 +760,7 @@ void TestLanguageTag::testAllIsoLangEntries() LanguageTag aTagID( elem.mnLang); if (!checkMapping( elem.maBcp47, aTagString.getBcp47())) { - OString aMessage( OUStringToOString( elem.maBcp47, RTL_TEXTENCODING_ASCII_US)); - aMessage += " -> " + OUStringToOString( aTagString.getBcp47(), RTL_TEXTENCODING_ASCII_US); + OString aMessage( OUStringToOString( elem.maBcp47, RTL_TEXTENCODING_ASCII_US) + " -> " + OUStringToOString( aTagString.getBcp47(), RTL_TEXTENCODING_ASCII_US) ); CPPUNIT_ASSERT_EQUAL_MESSAGE( aMessage.getStr(), aTagString.getBcp47(), elem.maBcp47 ); } if (elem.maBcp47 != aTagID.getBcp47()) -- cgit