From c8fa03b1f565461364b9f6423b65680e09281c14 Mon Sep 17 00:00:00 2001
From: Noel Grandin <noel.grandin@collabora.co.uk>
Date: Thu, 26 Jul 2018 13:15:05 +0200
Subject: new loplugin:stringloop, and applied in various

look for OUString being appended to in a loop, better to use
OUStringBuffer to accumulate the results.

Change-Id: Ia36e06e2781a7c546ce9cbad62727aa4c5f10c4b
Reviewed-on: https://gerrit.libreoffice.org/58092
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
---
 i18npool/source/indexentry/genindex_data.cxx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

(limited to 'i18npool/source/indexentry')

diff --git a/i18npool/source/indexentry/genindex_data.cxx b/i18npool/source/indexentry/genindex_data.cxx
index d505dc9b661f..871b742d9b86 100644
--- a/i18npool/source/indexentry/genindex_data.cxx
+++ b/i18npool/source/indexentry/genindex_data.cxx
@@ -25,6 +25,7 @@
 #include <sal/main.h>
 #include <sal/types.h>
 #include <rtl/ustring.hxx>
+#include <rtl/ustrbuf.hxx>
 
 #define MAX_ADDRESS 0x30000
 #define MAX_INDEX MAX_ADDRESS/0x100
@@ -48,7 +49,7 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
     sal_Int32 address[MAX_ADDRESS];
     for (i=0; i<MAX_ADDRESS; i++) address[i]=-1;
     OUString sep=OUString('|');
-    OUString result=sep;
+    OUStringBuffer result=sep;
     sal_Int32 max=0;
 
     sal_Char str[1024];
@@ -78,7 +79,7 @@ SAL_IMPLEMENT_MAIN_WITH_ARGS(argc, argv)
             address[nChar]=idx;
         } else {
             address[nChar]=result.getLength();
-            result+=key;
+            result.append(key);
         }
     }
     fclose(fp);
-- 
cgit